From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, Vinod <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jakub Kicinski <kuba@kernel.org>, <linux-phy@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH resend v4 1/3] dt-bindings: phy: Add lan966x-serdes binding
Date: Tue, 30 Nov 2021 17:11:41 +0100 [thread overview]
Message-ID: <20211130161141.pat3h5sojddr2ne6@soft-dev3-1.localhost> (raw)
In-Reply-To: <CAMuHMdUkr3n-m8dadyzb=s7F9ns6PXMLgOkZaG=XTYNKnaaORg@mail.gmail.com>
The 11/30/2021 15:02, Geert Uytterhoeven wrote:
>
> Hi Horatio,
Hi Geert,
>
> On Tue, Nov 16, 2021 at 11:16 AM Horatiu Vultur
> <horatiu.vultur@microchip.com> wrote:
> > Document the lan966x ethernet serdes phy driver bindings.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> Thanks for your patch, which is now commit fd66e57e46a3d1b7
> ("dt-bindings: phy: Add lan966x-serdes binding") in phy/next.
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
>
> > +examples:
> > + - |
> > + serdes: serdes@e2004010 {
> > + compatible = "microchip,lan966x-serdes";
> > + reg = <0xe202c000 0x9c>, <0xe2004010 0x4>;
> > + #phy-cells = <2>;
> > + };
>
> So this overlaps with the switch registers, cfr.
> Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> in net-next/master?
>
> switch: switch@e0000000 {
> compatible = "microchip,lan966x-switch";
> reg = <0xe0000000 0x0100000>,
> <0xe2000000 0x0800000>;
> ...
> };
Well, they will overlap, but the switch will not use the registers used
by the the serdes. The 'lan966x_main_iomap' inside lan966x_main.c will
decide which parts of the resource will be used.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
/Horatiu
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, Vinod <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jakub Kicinski <kuba@kernel.org>, <linux-phy@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH resend v4 1/3] dt-bindings: phy: Add lan966x-serdes binding
Date: Tue, 30 Nov 2021 17:11:41 +0100 [thread overview]
Message-ID: <20211130161141.pat3h5sojddr2ne6@soft-dev3-1.localhost> (raw)
In-Reply-To: <CAMuHMdUkr3n-m8dadyzb=s7F9ns6PXMLgOkZaG=XTYNKnaaORg@mail.gmail.com>
The 11/30/2021 15:02, Geert Uytterhoeven wrote:
>
> Hi Horatio,
Hi Geert,
>
> On Tue, Nov 16, 2021 at 11:16 AM Horatiu Vultur
> <horatiu.vultur@microchip.com> wrote:
> > Document the lan966x ethernet serdes phy driver bindings.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> Thanks for your patch, which is now commit fd66e57e46a3d1b7
> ("dt-bindings: phy: Add lan966x-serdes binding") in phy/next.
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/microchip,lan966x-serdes.yaml
>
> > +examples:
> > + - |
> > + serdes: serdes@e2004010 {
> > + compatible = "microchip,lan966x-serdes";
> > + reg = <0xe202c000 0x9c>, <0xe2004010 0x4>;
> > + #phy-cells = <2>;
> > + };
>
> So this overlaps with the switch registers, cfr.
> Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml
> in net-next/master?
>
> switch: switch@e0000000 {
> compatible = "microchip,lan966x-switch";
> reg = <0xe0000000 0x0100000>,
> <0xe2000000 0x0800000>;
> ...
> };
Well, they will overlap, but the switch will not use the registers used
by the the serdes. The 'lan966x_main_iomap' inside lan966x_main.c will
decide which parts of the resource will be used.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
/Horatiu
next prev parent reply other threads:[~2021-11-30 16:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:08 [PATCH resend v4 0/3] phy: Add driver for lan966x Serdes driver Horatiu Vultur
2021-11-16 10:08 ` Horatiu Vultur
2021-11-16 10:08 ` [PATCH resend v4 1/3] dt-bindings: phy: Add lan966x-serdes binding Horatiu Vultur
2021-11-16 10:08 ` Horatiu Vultur
2021-11-30 14:02 ` Geert Uytterhoeven
2021-11-30 14:02 ` Geert Uytterhoeven
2021-11-30 16:11 ` Horatiu Vultur [this message]
2021-11-30 16:11 ` Horatiu Vultur
2021-11-16 10:08 ` [PATCH resend v4 2/3] dt-bindings: phy: Add constants for lan966x serdes Horatiu Vultur
2021-11-16 10:08 ` Horatiu Vultur
2021-11-16 10:08 ` [PATCH resend v4 3/3] phy: Add lan966x ethernet serdes PHY driver Horatiu Vultur
2021-11-16 10:08 ` Horatiu Vultur
2021-11-16 10:21 ` [PATCH resend v4 0/3] phy: Add driver for lan966x Serdes driver Horatiu Vultur
2021-11-16 10:21 ` Horatiu Vultur
2021-11-16 10:45 ` Vinod Koul
2021-11-16 10:45 ` Vinod Koul
2021-11-16 10:56 ` Horatiu Vultur
2021-11-16 10:56 ` Horatiu Vultur
2021-11-16 11:43 ` Vinod Koul
2021-11-16 11:43 ` Vinod Koul
2021-11-16 11:52 ` Horatiu Vultur
2021-11-16 11:52 ` Horatiu Vultur
2021-11-16 18:12 ` Alexandre Belloni
2021-11-16 18:12 ` Alexandre Belloni
2021-11-16 22:05 ` Horatiu Vultur
2021-11-16 22:05 ` Horatiu Vultur
2021-11-23 7:39 ` Vinod Koul
2021-11-23 7:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130161141.pat3h5sojddr2ne6@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.