From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "jie.deng@intel.com" <jie.deng@intel.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"wsa@kernel.org" <wsa@kernel.org>, kernel <kernel@axis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"conghui.chen@intel.com" <conghui.chen@intel.com>
Subject: Re: [PATCH v2 2/2] i2c: virtio: fix completion handling
Date: Thu, 2 Dec 2021 16:34:37 +0100 [thread overview]
Message-ID: <20211202153436.GA11644@axis.com> (raw)
In-Reply-To: <20211111114630-mutt-send-email-mst@kernel.org>
On Thu, Nov 11, 2021 at 05:57:30PM +0100, Michael S. Tsirkin wrote:
> On Thu, Nov 11, 2021 at 05:04:12PM +0100, Vincent Whitchurch wrote:
> > - wait_for_completion(&vi->completion);
> > + /*
> > + * We only need to wait for the last one since the device is required
> > + * to complete requests in order.
> > + */
>
> Hmm the spec only says:
>
> A device MUST guarantee the requests in the virtqueue being processed in order
> if multiple requests are received at a time.
>
> it does not seem to require using the buffers in order.
> In any case, just waiting for all of them in a loop
> seems cleaner and likely won't take longer ...
Thank you, I've fixed this in v3.
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"wsa@kernel.org" <wsa@kernel.org>, kernel <kernel@axis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"conghui.chen@intel.com" <conghui.chen@intel.com>
Subject: Re: [PATCH v2 2/2] i2c: virtio: fix completion handling
Date: Thu, 2 Dec 2021 16:34:37 +0100 [thread overview]
Message-ID: <20211202153436.GA11644@axis.com> (raw)
In-Reply-To: <20211111114630-mutt-send-email-mst@kernel.org>
On Thu, Nov 11, 2021 at 05:57:30PM +0100, Michael S. Tsirkin wrote:
> On Thu, Nov 11, 2021 at 05:04:12PM +0100, Vincent Whitchurch wrote:
> > - wait_for_completion(&vi->completion);
> > + /*
> > + * We only need to wait for the last one since the device is required
> > + * to complete requests in order.
> > + */
>
> Hmm the spec only says:
>
> A device MUST guarantee the requests in the virtqueue being processed in order
> if multiple requests are received at a time.
>
> it does not seem to require using the buffers in order.
> In any case, just waiting for all of them in a loop
> seems cleaner and likely won't take longer ...
Thank you, I've fixed this in v3.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-12-02 15:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 16:04 [PATCH v2 0/2] virtio-i2c: Fix buffer handling Vincent Whitchurch
2021-11-11 16:04 ` Vincent Whitchurch
2021-11-11 16:04 ` [PATCH v2 1/2] i2c: virtio: disable timeout handling Vincent Whitchurch
2021-11-11 16:04 ` Vincent Whitchurch
2021-11-11 16:46 ` Michael S. Tsirkin
2021-11-11 16:46 ` Michael S. Tsirkin
2021-11-12 2:35 ` Viresh Kumar
2021-11-12 2:35 ` Viresh Kumar
2021-11-19 15:30 ` Vincent Whitchurch
2021-11-19 15:30 ` Vincent Whitchurch
2021-11-23 9:52 ` Wolfram Sang
2021-11-23 9:54 ` Viresh Kumar
2021-11-23 9:54 ` Viresh Kumar
2021-11-23 9:55 ` Wolfram Sang
2021-11-11 16:04 ` [PATCH v2 2/2] i2c: virtio: fix completion handling Vincent Whitchurch
2021-11-11 16:04 ` Vincent Whitchurch
2021-11-11 16:57 ` Michael S. Tsirkin
2021-11-11 16:57 ` Michael S. Tsirkin
2021-12-02 15:34 ` Vincent Whitchurch [this message]
2021-12-02 15:34 ` Vincent Whitchurch
2021-11-24 23:55 ` [PATCH v2 0/2] virtio-i2c: Fix buffer handling Michael S. Tsirkin
2021-11-24 23:55 ` Michael S. Tsirkin
2021-11-25 3:21 ` Viresh Kumar
2021-11-25 3:21 ` Viresh Kumar
2021-11-25 6:24 ` Wolfram Sang
2021-11-25 6:47 ` Viresh Kumar
2021-11-25 6:47 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202153436.GA11644@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=conghui.chen@intel.com \
--cc=jie.deng@intel.com \
--cc=kernel@axis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.