* [linux-next:master 4042/4626] net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL
@ 2021-12-01 15:26 kernel test robot
2021-12-03 8:20 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-12-01 15:26 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2978 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Michal Hocko <mhocko@suse.com>
CC: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 048aeae86c3967f4c40666cd26f2c1eb73a4b805
commit: 232323e9a580d6b34f3a513602b21359a79a09dd [4042/4626] mm: allow !GFP_KERNEL allocations for kvmalloc
:::::: branch date: 10 hours ago
:::::: commit date: 2 days ago
config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211201/202112012323.erLbOTLT-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL
net/ceph/osdmap.c:983 alloc_workspace() error: kvmalloc() only makes sense with GFP_KERNEL
net/ceph/osdmap.c:1193 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
net/ceph/osdmap.c:1506 set_primary_affinity() error: kvmalloc() only makes sense with GFP_KERNEL
Old smatch warnings:
net/ceph/osdmap.c:1194 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
net/ceph/osdmap.c:1195 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
net/ceph/osdmap.c:1225 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
vim +311 net/ceph/messenger_v2.c
cd1a677cad9940 Ilya Dryomov 2020-11-19 301
cd1a677cad9940 Ilya Dryomov 2020-11-19 302 static void *alloc_conn_buf(struct ceph_connection *con, int len)
cd1a677cad9940 Ilya Dryomov 2020-11-19 303 {
cd1a677cad9940 Ilya Dryomov 2020-11-19 304 void *buf;
cd1a677cad9940 Ilya Dryomov 2020-11-19 305
cd1a677cad9940 Ilya Dryomov 2020-11-19 306 dout("%s con %p len %d\n", __func__, con, len);
cd1a677cad9940 Ilya Dryomov 2020-11-19 307
cd1a677cad9940 Ilya Dryomov 2020-11-19 308 if (WARN_ON(con->v2.conn_buf_cnt >= ARRAY_SIZE(con->v2.conn_bufs)))
cd1a677cad9940 Ilya Dryomov 2020-11-19 309 return NULL;
cd1a677cad9940 Ilya Dryomov 2020-11-19 310
232323e9a580d6 Michal Hocko 2021-11-30 @311 buf = kvmalloc(len, GFP_NOIO);
cd1a677cad9940 Ilya Dryomov 2020-11-19 312 if (!buf)
cd1a677cad9940 Ilya Dryomov 2020-11-19 313 return NULL;
cd1a677cad9940 Ilya Dryomov 2020-11-19 314
cd1a677cad9940 Ilya Dryomov 2020-11-19 315 con->v2.conn_bufs[con->v2.conn_buf_cnt++] = buf;
cd1a677cad9940 Ilya Dryomov 2020-11-19 316 return buf;
cd1a677cad9940 Ilya Dryomov 2020-11-19 317 }
cd1a677cad9940 Ilya Dryomov 2020-11-19 318
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-next:master 4042/4626] net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL
2021-12-01 15:26 [linux-next:master 4042/4626] net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL kernel test robot
@ 2021-12-03 8:20 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-12-03 8:20 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3336 bytes --]
The mm devs have modified vmalloc() to all GFP_NOIO. It's only
GFP_ATOMIC and GFP_SLEEP which aren't allowed now. I have pushed an
update for this.
regards,
dan carpenter
On Wed, Dec 01, 2021 at 11:26:46PM +0800, kernel test robot wrote:
> CC: kbuild-all(a)lists.01.org
> CC: Linux Memory Management List <linux-mm@kvack.org>
> TO: Michal Hocko <mhocko@suse.com>
> CC: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Linux Memory Management List <linux-mm@kvack.org>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 048aeae86c3967f4c40666cd26f2c1eb73a4b805
> commit: 232323e9a580d6b34f3a513602b21359a79a09dd [4042/4626] mm: allow !GFP_KERNEL allocations for kvmalloc
> :::::: branch date: 10 hours ago
> :::::: commit date: 2 days ago
> config: arm-randconfig-m031-20211128 (https://download.01.org/0day-ci/archive/20211201/202112012323.erLbOTLT-lkp(a)intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL
> net/ceph/osdmap.c:983 alloc_workspace() error: kvmalloc() only makes sense with GFP_KERNEL
> net/ceph/osdmap.c:1193 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
> net/ceph/osdmap.c:1506 set_primary_affinity() error: kvmalloc() only makes sense with GFP_KERNEL
>
> Old smatch warnings:
> net/ceph/osdmap.c:1194 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
> net/ceph/osdmap.c:1195 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
> net/ceph/osdmap.c:1225 osdmap_set_max_osd() error: kvmalloc() only makes sense with GFP_KERNEL
>
> vim +311 net/ceph/messenger_v2.c
>
> cd1a677cad9940 Ilya Dryomov 2020-11-19 301
> cd1a677cad9940 Ilya Dryomov 2020-11-19 302 static void *alloc_conn_buf(struct ceph_connection *con, int len)
> cd1a677cad9940 Ilya Dryomov 2020-11-19 303 {
> cd1a677cad9940 Ilya Dryomov 2020-11-19 304 void *buf;
> cd1a677cad9940 Ilya Dryomov 2020-11-19 305
> cd1a677cad9940 Ilya Dryomov 2020-11-19 306 dout("%s con %p len %d\n", __func__, con, len);
> cd1a677cad9940 Ilya Dryomov 2020-11-19 307
> cd1a677cad9940 Ilya Dryomov 2020-11-19 308 if (WARN_ON(con->v2.conn_buf_cnt >= ARRAY_SIZE(con->v2.conn_bufs)))
> cd1a677cad9940 Ilya Dryomov 2020-11-19 309 return NULL;
> cd1a677cad9940 Ilya Dryomov 2020-11-19 310
> 232323e9a580d6 Michal Hocko 2021-11-30 @311 buf = kvmalloc(len, GFP_NOIO);
> cd1a677cad9940 Ilya Dryomov 2020-11-19 312 if (!buf)
> cd1a677cad9940 Ilya Dryomov 2020-11-19 313 return NULL;
> cd1a677cad9940 Ilya Dryomov 2020-11-19 314
> cd1a677cad9940 Ilya Dryomov 2020-11-19 315 con->v2.conn_bufs[con->v2.conn_buf_cnt++] = buf;
> cd1a677cad9940 Ilya Dryomov 2020-11-19 316 return buf;
> cd1a677cad9940 Ilya Dryomov 2020-11-19 317 }
> cd1a677cad9940 Ilya Dryomov 2020-11-19 318
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-01 15:26 [linux-next:master 4042/4626] net/ceph/messenger_v2.c:311 alloc_conn_buf() error: kvmalloc() only makes sense with GFP_KERNEL kernel test robot
2021-12-03 8:20 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.