All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fscache, cachefiles: fix some tracing output
@ 2021-12-03  9:49 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2021-12-03  9:49 UTC (permalink / raw)
  To: David Howells; +Cc: linux-cachefs, kernel-janitors

These are cut and paste bugs.  It is using the wrong error codes.

Fixes: 5cc1b2a78318 ("cachefiles: Implement backing file wrangling")
Fixes: e19b617e438a ("cachefiles: Implement culling daemon commands")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 fs/cachefiles/namei.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cachefiles/namei.c b/fs/cachefiles/namei.c
index a651da35dcd0..a2f895f45c25 100644
--- a/fs/cachefiles/namei.c
+++ b/fs/cachefiles/namei.c
@@ -390,7 +390,7 @@ int cachefiles_bury_object(struct cachefiles_cache *cache,
 			ret = vfs_rename(&rd);
 		if (ret != 0)
 			trace_cachefiles_vfs_error(object, d_inode(dir),
-						   PTR_ERR(grave),
+						   ret,
 						   cachefiles_trace_rename_error);
 		if (ret != 0 && ret != -ENOMEM)
 			cachefiles_io_error(cache,
@@ -702,7 +702,7 @@ bool cachefiles_commit_tmpfile(struct cachefiles_cache *cache,
 		ret = vfs_link(object->file->f_path.dentry, &init_user_ns,
 			       d_inode(fan), dentry, NULL);
 	if (ret < 0) {
-		trace_cachefiles_vfs_error(object, d_inode(fan), PTR_ERR(dentry),
+		trace_cachefiles_vfs_error(object, d_inode(fan), ret,
 					   cachefiles_trace_link_error);
 		_debug("link fail %d", ret);
 	} else {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-03  9:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03  9:49 [PATCH] fscache, cachefiles: fix some tracing output Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.