From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/net/wwan/iosm/iosm_ipc_mux_codec.c:833:21: sparse: sparse: Using plain integer as NULL pointer
Date: Sun, 05 Dec 2021 03:23:45 +0800 [thread overview]
Message-ID: <202112050318.uBUvlyTo-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3632 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bbef3c7a63d2a4cb0f3f839db9e767f168c5e348
commit: f7af616c632ee2ac3af0876fe33bf9e0232e665a net: iosm: infrastructure
date: 6 months ago
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20211205/202112050318.uBUvlyTo-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7af616c632ee2ac3af0876fe33bf9e0232e665a
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout f7af616c632ee2ac3af0876fe33bf9e0232e665a
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/wwan/iosm/ drivers/staging/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/wwan/iosm/iosm_ipc_mux_codec.c:833:21: sparse: sparse: Using plain integer as NULL pointer
vim +833 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
9413491e20e1ab M Chetan Kumar 2021-06-13 814
9413491e20e1ab M Chetan Kumar 2021-06-13 815 void ipc_mux_ul_encoded_process(struct iosm_mux *ipc_mux, struct sk_buff *skb)
9413491e20e1ab M Chetan Kumar 2021-06-13 816 {
9413491e20e1ab M Chetan Kumar 2021-06-13 817 struct mux_adgh *adgh;
9413491e20e1ab M Chetan Kumar 2021-06-13 818 u16 adgh_len;
9413491e20e1ab M Chetan Kumar 2021-06-13 819
9413491e20e1ab M Chetan Kumar 2021-06-13 820 adgh = (struct mux_adgh *)skb->data;
9413491e20e1ab M Chetan Kumar 2021-06-13 821 adgh_len = le16_to_cpu(adgh->length);
9413491e20e1ab M Chetan Kumar 2021-06-13 822
9413491e20e1ab M Chetan Kumar 2021-06-13 823 if (adgh->signature == cpu_to_le32(MUX_SIG_ADGH) &&
9413491e20e1ab M Chetan Kumar 2021-06-13 824 ipc_mux->ul_flow == MUX_UL)
9413491e20e1ab M Chetan Kumar 2021-06-13 825 ipc_mux->ul_data_pend_bytes = ipc_mux->ul_data_pend_bytes -
9413491e20e1ab M Chetan Kumar 2021-06-13 826 adgh_len;
9413491e20e1ab M Chetan Kumar 2021-06-13 827
9413491e20e1ab M Chetan Kumar 2021-06-13 828 if (ipc_mux->ul_flow == MUX_UL)
9413491e20e1ab M Chetan Kumar 2021-06-13 829 dev_dbg(ipc_mux->dev, "ul_data_pend_bytes: %lld",
9413491e20e1ab M Chetan Kumar 2021-06-13 830 ipc_mux->ul_data_pend_bytes);
9413491e20e1ab M Chetan Kumar 2021-06-13 831
9413491e20e1ab M Chetan Kumar 2021-06-13 832 /* Reset the skb settings. */
9413491e20e1ab M Chetan Kumar 2021-06-13 @833 skb->tail = 0;
9413491e20e1ab M Chetan Kumar 2021-06-13 834 skb->len = 0;
9413491e20e1ab M Chetan Kumar 2021-06-13 835
9413491e20e1ab M Chetan Kumar 2021-06-13 836 /* Add the consumed ADB to the free list. */
9413491e20e1ab M Chetan Kumar 2021-06-13 837 skb_queue_tail((&ipc_mux->ul_adb.free_list), skb);
9413491e20e1ab M Chetan Kumar 2021-06-13 838 }
9413491e20e1ab M Chetan Kumar 2021-06-13 839
:::::: The code at line 833 was first introduced by commit
:::::: 9413491e20e1aba6e471d90c19cc43e523216a4d net: iosm: encode or decode datagram
:::::: TO: M Chetan Kumar <m.chetan.kumar@intel.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: M Chetan Kumar <m.chetan.kumar@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: drivers/net/wwan/iosm/iosm_ipc_mux_codec.c:833:21: sparse: sparse: Using plain integer as NULL pointer
Date: Sun, 5 Dec 2021 03:23:45 +0800 [thread overview]
Message-ID: <202112050318.uBUvlyTo-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bbef3c7a63d2a4cb0f3f839db9e767f168c5e348
commit: f7af616c632ee2ac3af0876fe33bf9e0232e665a net: iosm: infrastructure
date: 6 months ago
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20211205/202112050318.uBUvlyTo-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f7af616c632ee2ac3af0876fe33bf9e0232e665a
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout f7af616c632ee2ac3af0876fe33bf9e0232e665a
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/wwan/iosm/ drivers/staging/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/wwan/iosm/iosm_ipc_mux_codec.c:833:21: sparse: sparse: Using plain integer as NULL pointer
vim +833 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c
9413491e20e1ab M Chetan Kumar 2021-06-13 814
9413491e20e1ab M Chetan Kumar 2021-06-13 815 void ipc_mux_ul_encoded_process(struct iosm_mux *ipc_mux, struct sk_buff *skb)
9413491e20e1ab M Chetan Kumar 2021-06-13 816 {
9413491e20e1ab M Chetan Kumar 2021-06-13 817 struct mux_adgh *adgh;
9413491e20e1ab M Chetan Kumar 2021-06-13 818 u16 adgh_len;
9413491e20e1ab M Chetan Kumar 2021-06-13 819
9413491e20e1ab M Chetan Kumar 2021-06-13 820 adgh = (struct mux_adgh *)skb->data;
9413491e20e1ab M Chetan Kumar 2021-06-13 821 adgh_len = le16_to_cpu(adgh->length);
9413491e20e1ab M Chetan Kumar 2021-06-13 822
9413491e20e1ab M Chetan Kumar 2021-06-13 823 if (adgh->signature == cpu_to_le32(MUX_SIG_ADGH) &&
9413491e20e1ab M Chetan Kumar 2021-06-13 824 ipc_mux->ul_flow == MUX_UL)
9413491e20e1ab M Chetan Kumar 2021-06-13 825 ipc_mux->ul_data_pend_bytes = ipc_mux->ul_data_pend_bytes -
9413491e20e1ab M Chetan Kumar 2021-06-13 826 adgh_len;
9413491e20e1ab M Chetan Kumar 2021-06-13 827
9413491e20e1ab M Chetan Kumar 2021-06-13 828 if (ipc_mux->ul_flow == MUX_UL)
9413491e20e1ab M Chetan Kumar 2021-06-13 829 dev_dbg(ipc_mux->dev, "ul_data_pend_bytes: %lld",
9413491e20e1ab M Chetan Kumar 2021-06-13 830 ipc_mux->ul_data_pend_bytes);
9413491e20e1ab M Chetan Kumar 2021-06-13 831
9413491e20e1ab M Chetan Kumar 2021-06-13 832 /* Reset the skb settings. */
9413491e20e1ab M Chetan Kumar 2021-06-13 @833 skb->tail = 0;
9413491e20e1ab M Chetan Kumar 2021-06-13 834 skb->len = 0;
9413491e20e1ab M Chetan Kumar 2021-06-13 835
9413491e20e1ab M Chetan Kumar 2021-06-13 836 /* Add the consumed ADB to the free list. */
9413491e20e1ab M Chetan Kumar 2021-06-13 837 skb_queue_tail((&ipc_mux->ul_adb.free_list), skb);
9413491e20e1ab M Chetan Kumar 2021-06-13 838 }
9413491e20e1ab M Chetan Kumar 2021-06-13 839
:::::: The code at line 833 was first introduced by commit
:::::: 9413491e20e1aba6e471d90c19cc43e523216a4d net: iosm: encode or decode datagram
:::::: TO: M Chetan Kumar <m.chetan.kumar@intel.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2021-12-04 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 19:23 kernel test robot [this message]
2021-12-04 19:23 ` drivers/net/wwan/iosm/iosm_ipc_mux_codec.c:833:21: sparse: sparse: Using plain integer as NULL pointer kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-02-27 1:12 kernel test robot
2022-06-05 4:05 kernel test robot
2022-07-16 0:48 kernel test robot
2022-07-17 12:59 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112050318.uBUvlyTo-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.