All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Robin van der Gracht <robin@protonic.nl>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Jander <david@protonic.nl>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 2/4] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node
Date: Mon, 6 Dec 2021 09:01:37 +0800	[thread overview]
Message-ID: <20211206010137.GJ4216@dragon> (raw)
In-Reply-To: <20211122124310.2796505-2-o.rempel@pengutronix.de>

On Mon, Nov 22, 2021 at 01:43:08PM +0100, Oleksij Rempel wrote:
> From: Robin van der Gracht <robin@protonic.nl>
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  arch/arm/boot/dts/imx6dl-prtvt7.dts | 40 +++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> index be7c4cb339e7..02b53df03e6f 100644
> --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -6,6 +6,7 @@
>  /dts-v1/;
>  #include "imx6dl.dtsi"
>  #include "imx6qdl-prti6q.dtsi"
> +#include <dt-bindings/display/sdtv-standards.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/leds/common.h>
>  #include <dt-bindings/sound/fsl-imx-audmux.h>
> @@ -171,6 +172,18 @@ panel_in: endpoint {
>  		};
>  	};
>  
> +	connector {
> +		compatible = "composite-video-connector";
> +		label = "Composite0";
> +		sdtv-standards = <SDTV_STD_PAL_B>;
> +
> +		port {
> +			comp0_out: endpoint {
> +				remote-endpoint = <&tvp5150_comp0_in>;
> +			};
> +		};
> +	};
> +
>  	reg_bl_12v0: regulator-bl-12v0 {
>  		compatible = "regulator-fixed";
>  		pinctrl-names = "default";
> @@ -295,6 +308,29 @@ sgtl5000: audio-codec@a {
>  		VDDIO-supply = <&reg_3v3>;
>  		VDDD-supply = <&reg_1v8>;
>  	};
> +
> +	video@5c {
> +		compatible = "ti,tvp5150";
> +		reg = <0x5c>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;

Have a newline between property and child node.

Shawn

> +			tvp5150_comp0_in: endpoint {
> +				remote-endpoint = <&comp0_out>;
> +			};
> +		};
> +
> +		/* Output port 2 is video output pad */
> +		port@2 {
> +			reg = <2>;
> +			tvp5151_to_ipu1_csi0_mux: endpoint {
> +				remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
> +			};
> +		};
> +	};
>  };
>  
>  &i2c3 {
> @@ -322,6 +358,10 @@ &ipu1_di0_disp0 {
>  	remote-endpoint = <&display_in>;
>  };
>  
> +&ipu1_csi0_mux_from_parallel_sensor {
> +	remote-endpoint = <&tvp5151_to_ipu1_csi0_mux>;
> +};
> +
>  &pwm1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_pwm1>;
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Robin van der Gracht <robin@protonic.nl>,
	devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Jander <david@protonic.nl>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 2/4] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node
Date: Mon, 6 Dec 2021 09:01:37 +0800	[thread overview]
Message-ID: <20211206010137.GJ4216@dragon> (raw)
In-Reply-To: <20211122124310.2796505-2-o.rempel@pengutronix.de>

On Mon, Nov 22, 2021 at 01:43:08PM +0100, Oleksij Rempel wrote:
> From: Robin van der Gracht <robin@protonic.nl>
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  arch/arm/boot/dts/imx6dl-prtvt7.dts | 40 +++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> index be7c4cb339e7..02b53df03e6f 100644
> --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -6,6 +6,7 @@
>  /dts-v1/;
>  #include "imx6dl.dtsi"
>  #include "imx6qdl-prti6q.dtsi"
> +#include <dt-bindings/display/sdtv-standards.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/leds/common.h>
>  #include <dt-bindings/sound/fsl-imx-audmux.h>
> @@ -171,6 +172,18 @@ panel_in: endpoint {
>  		};
>  	};
>  
> +	connector {
> +		compatible = "composite-video-connector";
> +		label = "Composite0";
> +		sdtv-standards = <SDTV_STD_PAL_B>;
> +
> +		port {
> +			comp0_out: endpoint {
> +				remote-endpoint = <&tvp5150_comp0_in>;
> +			};
> +		};
> +	};
> +
>  	reg_bl_12v0: regulator-bl-12v0 {
>  		compatible = "regulator-fixed";
>  		pinctrl-names = "default";
> @@ -295,6 +308,29 @@ sgtl5000: audio-codec@a {
>  		VDDIO-supply = <&reg_3v3>;
>  		VDDD-supply = <&reg_1v8>;
>  	};
> +
> +	video@5c {
> +		compatible = "ti,tvp5150";
> +		reg = <0x5c>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;

Have a newline between property and child node.

Shawn

> +			tvp5150_comp0_in: endpoint {
> +				remote-endpoint = <&comp0_out>;
> +			};
> +		};
> +
> +		/* Output port 2 is video output pad */
> +		port@2 {
> +			reg = <2>;
> +			tvp5151_to_ipu1_csi0_mux: endpoint {
> +				remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
> +			};
> +		};
> +	};
>  };
>  
>  &i2c3 {
> @@ -322,6 +358,10 @@ &ipu1_di0_disp0 {
>  	remote-endpoint = <&display_in>;
>  };
>  
> +&ipu1_csi0_mux_from_parallel_sensor {
> +	remote-endpoint = <&tvp5151_to_ipu1_csi0_mux>;
> +};
> +
>  &pwm1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_pwm1>;
> -- 
> 2.30.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Airlie <airlied@linux.ie>,
	Robin van der Gracht <robin@protonic.nl>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	David Jander <david@protonic.nl>, Sam Ravnborg <sam@ravnborg.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/4] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node
Date: Mon, 6 Dec 2021 09:01:37 +0800	[thread overview]
Message-ID: <20211206010137.GJ4216@dragon> (raw)
In-Reply-To: <20211122124310.2796505-2-o.rempel@pengutronix.de>

On Mon, Nov 22, 2021 at 01:43:08PM +0100, Oleksij Rempel wrote:
> From: Robin van der Gracht <robin@protonic.nl>
> 
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>  arch/arm/boot/dts/imx6dl-prtvt7.dts | 40 +++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> index be7c4cb339e7..02b53df03e6f 100644
> --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -6,6 +6,7 @@
>  /dts-v1/;
>  #include "imx6dl.dtsi"
>  #include "imx6qdl-prti6q.dtsi"
> +#include <dt-bindings/display/sdtv-standards.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/leds/common.h>
>  #include <dt-bindings/sound/fsl-imx-audmux.h>
> @@ -171,6 +172,18 @@ panel_in: endpoint {
>  		};
>  	};
>  
> +	connector {
> +		compatible = "composite-video-connector";
> +		label = "Composite0";
> +		sdtv-standards = <SDTV_STD_PAL_B>;
> +
> +		port {
> +			comp0_out: endpoint {
> +				remote-endpoint = <&tvp5150_comp0_in>;
> +			};
> +		};
> +	};
> +
>  	reg_bl_12v0: regulator-bl-12v0 {
>  		compatible = "regulator-fixed";
>  		pinctrl-names = "default";
> @@ -295,6 +308,29 @@ sgtl5000: audio-codec@a {
>  		VDDIO-supply = <&reg_3v3>;
>  		VDDD-supply = <&reg_1v8>;
>  	};
> +
> +	video@5c {
> +		compatible = "ti,tvp5150";
> +		reg = <0x5c>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;

Have a newline between property and child node.

Shawn

> +			tvp5150_comp0_in: endpoint {
> +				remote-endpoint = <&comp0_out>;
> +			};
> +		};
> +
> +		/* Output port 2 is video output pad */
> +		port@2 {
> +			reg = <2>;
> +			tvp5151_to_ipu1_csi0_mux: endpoint {
> +				remote-endpoint = <&ipu1_csi0_mux_from_parallel_sensor>;
> +			};
> +		};
> +	};
>  };
>  
>  &i2c3 {
> @@ -322,6 +358,10 @@ &ipu1_di0_disp0 {
>  	remote-endpoint = <&display_in>;
>  };
>  
> +&ipu1_csi0_mux_from_parallel_sensor {
> +	remote-endpoint = <&tvp5151_to_ipu1_csi0_mux>;
> +};
> +
>  &pwm1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_pwm1>;
> -- 
> 2.30.2
> 

  reply	other threads:[~2021-12-06  1:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 12:43 [PATCH v1 1/4] ARM: dts: imx6dl-prtvt7: Add display and panel nodes Oleksij Rempel
2021-11-22 12:43 ` Oleksij Rempel
2021-11-22 12:43 ` Oleksij Rempel
2021-11-22 12:43 ` [PATCH v1 2/4] ARM: dts: imx6dl-prtvt7: Add missing tvp5150 video decoder node Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-12-06  1:01   ` Shawn Guo [this message]
2021-12-06  1:01     ` Shawn Guo
2021-12-06  1:01     ` Shawn Guo
2021-11-22 12:43 ` [PATCH v1 3/4] ARM: dts: imx6qdl-vicut1: add CAN termination support Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-11-22 12:43 ` [PATCH v1 4/4] ARM: dts: imx6dl: plym2m, prtvt7, victgo: make use of new resistive-adc-touch driver Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-11-22 12:43   ` Oleksij Rempel
2021-12-06  1:06   ` Shawn Guo
2021-12-06  1:06     ` Shawn Guo
2021-12-06  1:06     ` Shawn Guo
2022-01-05 11:04     ` Oleksij Rempel
2022-01-05 11:04       ` Oleksij Rempel
2022-01-05 11:04       ` Oleksij Rempel
2022-01-26  2:05       ` Shawn Guo
2022-01-26  2:05         ` Shawn Guo
2022-01-26  2:05         ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211206010137.GJ4216@dragon \
    --to=shawnguo@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.