All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: devicetree@vger.kernel.org, festevam@gmail.com,
	kernel@pengutronix.de, Abel Vesa <abel.vesa@nxp.com>,
	kernel@puri.sm, krzk@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif
Date: Mon, 6 Dec 2021 09:38:21 +0800	[thread overview]
Message-ID: <20211206013821.GP4216@dragon> (raw)
In-Reply-To: <20211124083703.730243-1-martin.kepplinger@puri.sm>

+ Abel

On Wed, Nov 24, 2021 at 09:37:03AM +0100, Martin Kepplinger wrote:
> The mxsfb driver handling imx8mq lcdif doesn't yet request the
> interconnect bandwidth that's needed at runtime when the description is
> present in the DT node.
> 
> So remove that description and bring it back when it's supported.
> 
> Fixes: ad1abc8a03fd ("arm64: dts: imx8mq: Add interconnect for lcdif")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Applied, thanks.

> ---
> 
> revision history
> ----------------
> this patch replaces the wrong 1:1 revert previously sent:
> https://lore.kernel.org/linux-arm-kernel/20211123114545.411787-1-martin.kepplinger@puri.sm/
> 
> 
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 972766b67a15..71bf497f99c2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -524,8 +524,6 @@ lcdif: lcd-controller@30320000 {
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> -				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> -				interconnect-names = "dram";
>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: devicetree@vger.kernel.org, festevam@gmail.com,
	kernel@pengutronix.de, Abel Vesa <abel.vesa@nxp.com>,
	kernel@puri.sm, krzk@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif
Date: Mon, 6 Dec 2021 09:38:21 +0800	[thread overview]
Message-ID: <20211206013821.GP4216@dragon> (raw)
In-Reply-To: <20211124083703.730243-1-martin.kepplinger@puri.sm>

+ Abel

On Wed, Nov 24, 2021 at 09:37:03AM +0100, Martin Kepplinger wrote:
> The mxsfb driver handling imx8mq lcdif doesn't yet request the
> interconnect bandwidth that's needed at runtime when the description is
> present in the DT node.
> 
> So remove that description and bring it back when it's supported.
> 
> Fixes: ad1abc8a03fd ("arm64: dts: imx8mq: Add interconnect for lcdif")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Applied, thanks.

> ---
> 
> revision history
> ----------------
> this patch replaces the wrong 1:1 revert previously sent:
> https://lore.kernel.org/linux-arm-kernel/20211123114545.411787-1-martin.kepplinger@puri.sm/
> 
> 
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 972766b67a15..71bf497f99c2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -524,8 +524,6 @@ lcdif: lcd-controller@30320000 {
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> -				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> -				interconnect-names = "dram";
>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.30.2
> 

  reply	other threads:[~2021-12-06  1:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24  8:37 [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif Martin Kepplinger
2021-11-24  8:37 ` Martin Kepplinger
2021-12-06  1:38 ` Shawn Guo [this message]
2021-12-06  1:38   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211206013821.GP4216@dragon \
    --to=shawnguo@kernel.org \
    --cc=abel.vesa@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.