* [PATCH] nvme: show subsys nqn for duplicate cntlids
@ 2021-11-29 16:24 Keith Busch
2021-11-29 18:45 ` Chaitanya Kulkarni
2021-12-06 7:54 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Keith Busch @ 2021-11-29 16:24 UTC (permalink / raw)
To: linux-nvme, hch, sagi; +Cc: Keith Busch
The driver assigned nvme handle isn't persistent across reboots, so is
not enough information to match up where the collisions are occuring.
Add the subsys nqn string to the output so that it can more easily be
identified later.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215099
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 47a941207058..96db941c01b5 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2684,8 +2684,9 @@ static bool nvme_validate_cntlid(struct nvme_subsystem *subsys,
if (tmp->cntlid == ctrl->cntlid) {
dev_err(ctrl->device,
- "Duplicate cntlid %u with %s, rejecting\n",
- ctrl->cntlid, dev_name(tmp->device));
+ "Duplicate cntlid %u with %s, subsys %s, rejecting\n",
+ ctrl->cntlid, dev_name(tmp->device),
+ subsys->subnqn);
return false;
}
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: show subsys nqn for duplicate cntlids
2021-11-29 16:24 [PATCH] nvme: show subsys nqn for duplicate cntlids Keith Busch
@ 2021-11-29 18:45 ` Chaitanya Kulkarni
2021-12-06 7:54 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2021-11-29 18:45 UTC (permalink / raw)
To: Keith Busch, linux-nvme@lists.infradead.org, hch@lst.de,
sagi@grimberg.me
On 11/29/21 8:24 AM, Keith Busch wrote:
> The driver assigned nvme handle isn't persistent across reboots, so is
> not enough information to match up where the collisions are occuring.
's/occuring/occurring/' above ?
> Add the subsys nqn string to the output so that it can more easily be
> identified later.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215099
> Signed-off-by: Keith Busch <kbusch@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: show subsys nqn for duplicate cntlids
2021-11-29 16:24 [PATCH] nvme: show subsys nqn for duplicate cntlids Keith Busch
2021-11-29 18:45 ` Chaitanya Kulkarni
@ 2021-12-06 7:54 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-12-06 7:54 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi
Thanks,
applied to nvme-5.6.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-06 7:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-29 16:24 [PATCH] nvme: show subsys nqn for duplicate cntlids Keith Busch
2021-11-29 18:45 ` Chaitanya Kulkarni
2021-12-06 7:54 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.