All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver
Date: Mon, 6 Dec 2021 10:02:43 +0100	[thread overview]
Message-ID: <20211206100243.463ef310@xps13> (raw)
In-Reply-To: <20211201211850.GA3132024@maple.netwinder.org>

Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed, 1 Dec 2021 16:18:50 -0500:

> On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote:
> >Introduce Renesas RZ/N1x NAND controller driver which supports:
> >- All ONFI timing modes
> >- Different configurations of its internal ECC controller
> >- On-die (not tested) and software ECC support
> >- Several chips (not tested)
> >- Subpage accesses
> >- DMA and PIO
> >
> >This controller was originally provided by Evatronix before being bought
> >by Cadence.
> >
> >Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> I've given it a try and all seems to be well. Thus:
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>

Great! Thanks for your feedback.

> >+	mtd = nand_to_mtd(chip);
> >+	mtd->dev.parent = nandc->dev;
> >+	if (!mtd->name) {
> >+		dev_err(nandc->dev, "Missing MTD label\n");
> >+		return -EINVAL;
> >+	}  
> 
> Minor item: could the node name be used as a fallback when label is not present?

That's not the policy that we tried to enforce so far because node
names are too generic and define the nand-controller, not the chip
itself. That is something which may evolve if we ever decide to do
things differently at some point but I guess we would need to do that
at MTD level in this case.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver
Date: Mon, 6 Dec 2021 10:02:43 +0100	[thread overview]
Message-ID: <20211206100243.463ef310@xps13> (raw)
In-Reply-To: <20211201211850.GA3132024@maple.netwinder.org>

Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed, 1 Dec 2021 16:18:50 -0500:

> On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote:
> >Introduce Renesas RZ/N1x NAND controller driver which supports:
> >- All ONFI timing modes
> >- Different configurations of its internal ECC controller
> >- On-die (not tested) and software ECC support
> >- Several chips (not tested)
> >- Subpage accesses
> >- DMA and PIO
> >
> >This controller was originally provided by Evatronix before being bought
> >by Cadence.
> >
> >Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> I've given it a try and all seems to be well. Thus:
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>

Great! Thanks for your feedback.

> >+	mtd = nand_to_mtd(chip);
> >+	mtd->dev.parent = nandc->dev;
> >+	if (!mtd->name) {
> >+		dev_err(nandc->dev, "Missing MTD label\n");
> >+		return -EINVAL;
> >+	}  
> 
> Minor item: could the node name be used as a fallback when label is not present?

That's not the policy that we tried to enforce so far because node
names are too generic and define the nand-controller, not the chip
itself. That is something which may evolve if we ever decide to do
things differently at some point but I guess we would need to do that
at MTD level in this case.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	Pratyush Yadav <p.yadav@ti.com>, Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Jimmy Lalande <jimmy.lalande@se.com>,
	Milan Stevanovic <milan.stevanovic@se.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Gareth Williams <gareth.williams.jx@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver
Date: Mon, 6 Dec 2021 10:02:43 +0100	[thread overview]
Message-ID: <20211206100243.463ef310@xps13> (raw)
In-Reply-To: <20211201211850.GA3132024@maple.netwinder.org>

Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed, 1 Dec 2021 16:18:50 -0500:

> On Fri, Nov 26, 2021 at 03:06:24PM +0100, Miquel Raynal wrote:
> >Introduce Renesas RZ/N1x NAND controller driver which supports:
> >- All ONFI timing modes
> >- Different configurations of its internal ECC controller
> >- On-die (not tested) and software ECC support
> >- Several chips (not tested)
> >- Subpage accesses
> >- DMA and PIO
> >
> >This controller was originally provided by Evatronix before being bought
> >by Cadence.
> >
> >Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> I've given it a try and all seems to be well. Thus:
> Tested-by: Ralph Siemsen <ralph.siemsen@linaro.org>

Great! Thanks for your feedback.

> >+	mtd = nand_to_mtd(chip);
> >+	mtd->dev.parent = nandc->dev;
> >+	if (!mtd->name) {
> >+		dev_err(nandc->dev, "Missing MTD label\n");
> >+		return -EINVAL;
> >+	}  
> 
> Minor item: could the node name be used as a fallback when label is not present?

That's not the policy that we tried to enforce so far because node
names are too generic and define the nand-controller, not the chip
itself. That is something which may evolve if we ever decide to do
things differently at some point but I guess we would need to do that
at MTD level in this case.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-06  9:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 14:06 [PATCH v2 0/3] Renesas RZ/N1 NAND controller support Miquel Raynal
2021-11-26 14:06 ` Miquel Raynal
2021-11-26 14:06 ` Miquel Raynal
2021-11-26 14:06 ` [PATCH v2 1/3] dt-bindings: mtd: rzn1: Describe Renesas RZ/N1 NAND controller Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal
2021-12-06  9:10   ` Geert Uytterhoeven
2021-12-06  9:10     ` Geert Uytterhoeven
2021-12-06  9:10     ` Geert Uytterhoeven
2021-11-26 14:06 ` [PATCH v2 2/3] mtd: rawnand: rzn1: Add new NAND controller driver Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal
2021-12-01 21:18   ` Ralph Siemsen
2021-12-01 21:18     ` Ralph Siemsen
2021-12-01 21:18     ` Ralph Siemsen
2021-12-06  9:02     ` Miquel Raynal [this message]
2021-12-06  9:02       ` Miquel Raynal
2021-12-06  9:02       ` Miquel Raynal
2021-11-26 14:06 ` [PATCH v2 3/3] MAINTAINERS: Add an entry for Renesas RZ/N1 NAND controller Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal
2021-11-26 14:06   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211206100243.463ef310@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=gareth.williams.jx@renesas.com \
    --cc=geert@linux-m68k.org \
    --cc=jimmy.lalande@se.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=michael@walle.cc \
    --cc=milan.stevanovic@se.com \
    --cc=p.yadav@ti.com \
    --cc=phil.edworthy@renesas.com \
    --cc=ralph.siemsen@linaro.org \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.