From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Parav Pandit <parav@nvidia.com>,
virtualization <virtualization@lists.linux-foundation.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vduse: fix memory corruption in vduse_dev_ioctl()
Date: Tue, 7 Dec 2021 14:30:12 +0300 [thread overview]
Message-ID: <20211207113012.GI1978@kadam> (raw)
In-Reply-To: <CACycT3tTao93MvoU6eGf3i7mEjfxm-kBAGdGRghUb_AuCeUnwg@mail.gmail.com>
On Tue, Dec 07, 2021 at 07:19:35PM +0800, Yongji Xie wrote:
> On Tue, Dec 7, 2021 at 6:46 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "config.offset" comes from the user. There needs to a check to
> > prevent it being out of bounds. The "config.offset" and
> > "dev->config_size" variables are both type u32. So if the offset if
> > out of bounds then the "dev->config_size - config.offset" subtraction
> > results in a very high u32 value.
> >
>
> Thanks for catching this! I think we also need a fix for
> vhost_vdpa_config_validate().
Okay. I just sent v2. I'll send a v3. vhost_vdpa_config_validate()
uses long type for "size" so the subtract works okay on a 64bit system.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
kernel-janitors@vger.kernel.org,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] vduse: fix memory corruption in vduse_dev_ioctl()
Date: Tue, 7 Dec 2021 14:30:12 +0300 [thread overview]
Message-ID: <20211207113012.GI1978@kadam> (raw)
In-Reply-To: <CACycT3tTao93MvoU6eGf3i7mEjfxm-kBAGdGRghUb_AuCeUnwg@mail.gmail.com>
On Tue, Dec 07, 2021 at 07:19:35PM +0800, Yongji Xie wrote:
> On Tue, Dec 7, 2021 at 6:46 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "config.offset" comes from the user. There needs to a check to
> > prevent it being out of bounds. The "config.offset" and
> > "dev->config_size" variables are both type u32. So if the offset if
> > out of bounds then the "dev->config_size - config.offset" subtraction
> > results in a very high u32 value.
> >
>
> Thanks for catching this! I think we also need a fix for
> vhost_vdpa_config_validate().
Okay. I just sent v2. I'll send a v3. vhost_vdpa_config_validate()
uses long type for "size" so the subtract works okay on a 64bit system.
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-12-07 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:46 [PATCH] vduse: fix memory corruption in vduse_dev_ioctl() Dan Carpenter
2021-12-07 10:46 ` Dan Carpenter
2021-12-07 11:00 ` Dan Carpenter
2021-12-07 11:00 ` Dan Carpenter
2021-12-07 11:19 ` Yongji Xie
2021-12-07 11:30 ` Dan Carpenter [this message]
2021-12-07 11:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207113012.GI1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.