From: kernel test robot <lkp@intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, kw@linux.com, bhelgaas@google.com,
michael.a.bottini@linux.intel.com, rafael@kernel.org
Cc: kbuild-all@lists.01.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [V2 1/2] PCI/ASPM: Add ASPM BIOS override function
Date: Wed, 8 Dec 2021 08:51:55 +0800 [thread overview]
Message-ID: <202112080830.ItjrEFOo-lkp@intel.com> (raw)
In-Reply-To: <20211207223050.872095-1-david.e.box@linux.intel.com>
Hi "David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v5.16-rc4]
[also build test ERROR on next-20211207]
[cannot apply to helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211208-063240
base: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
config: nds32-defconfig (https://download.01.org/0day-ci/archive/20211208/202112080830.ItjrEFOo-lkp@intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/efd5524bd4005ec84d4eb6681c54d1ba93fe9ca1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211208-063240
git checkout efd5524bd4005ec84d4eb6681c54d1ba93fe9ca1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/pci/of.c:16:
drivers/pci/pci.h: In function 'pcie_aspm_policy_override':
>> drivers/pci/pci.h:571:83: error: expected ';' before '}' token
571 | static inline int pcie_aspm_policy_override(struct pci_dev *dev) { return -EINVAL }
| ^
vim +571 drivers/pci/pci.h
553
554 /* PCI error reporting and recovery */
555 pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
556 pci_channel_state_t state,
557 pci_ers_result_t (*reset_subordinates)(struct pci_dev *pdev));
558
559 bool pcie_wait_for_link(struct pci_dev *pdev, bool active);
560 #ifdef CONFIG_PCIEASPM
561 void pcie_aspm_init_link_state(struct pci_dev *pdev);
562 void pcie_aspm_exit_link_state(struct pci_dev *pdev);
563 void pcie_aspm_pm_state_change(struct pci_dev *pdev);
564 void pcie_aspm_powersave_config_link(struct pci_dev *pdev);
565 int pcie_aspm_policy_override(struct pci_dev *dev);
566 #else
567 static inline void pcie_aspm_init_link_state(struct pci_dev *pdev) { }
568 static inline void pcie_aspm_exit_link_state(struct pci_dev *pdev) { }
569 static inline void pcie_aspm_pm_state_change(struct pci_dev *pdev) { }
570 static inline void pcie_aspm_powersave_config_link(struct pci_dev *pdev) { }
> 571 static inline int pcie_aspm_policy_override(struct pci_dev *dev) { return -EINVAL }
572 #endif
573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [V2 1/2] PCI/ASPM: Add ASPM BIOS override function
Date: Wed, 08 Dec 2021 08:51:55 +0800 [thread overview]
Message-ID: <202112080830.ItjrEFOo-lkp@intel.com> (raw)
In-Reply-To: <20211207223050.872095-1-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3190 bytes --]
Hi "David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v5.16-rc4]
[also build test ERROR on next-20211207]
[cannot apply to helgaas-pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211208-063240
base: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
config: nds32-defconfig (https://download.01.org/0day-ci/archive/20211208/202112080830.ItjrEFOo-lkp(a)intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/efd5524bd4005ec84d4eb6681c54d1ba93fe9ca1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-E-Box/PCI-ASPM-Add-ASPM-BIOS-override-function/20211208-063240
git checkout efd5524bd4005ec84d4eb6681c54d1ba93fe9ca1
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/pci/of.c:16:
drivers/pci/pci.h: In function 'pcie_aspm_policy_override':
>> drivers/pci/pci.h:571:83: error: expected ';' before '}' token
571 | static inline int pcie_aspm_policy_override(struct pci_dev *dev) { return -EINVAL }
| ^
vim +571 drivers/pci/pci.h
553
554 /* PCI error reporting and recovery */
555 pci_ers_result_t pcie_do_recovery(struct pci_dev *dev,
556 pci_channel_state_t state,
557 pci_ers_result_t (*reset_subordinates)(struct pci_dev *pdev));
558
559 bool pcie_wait_for_link(struct pci_dev *pdev, bool active);
560 #ifdef CONFIG_PCIEASPM
561 void pcie_aspm_init_link_state(struct pci_dev *pdev);
562 void pcie_aspm_exit_link_state(struct pci_dev *pdev);
563 void pcie_aspm_pm_state_change(struct pci_dev *pdev);
564 void pcie_aspm_powersave_config_link(struct pci_dev *pdev);
565 int pcie_aspm_policy_override(struct pci_dev *dev);
566 #else
567 static inline void pcie_aspm_init_link_state(struct pci_dev *pdev) { }
568 static inline void pcie_aspm_exit_link_state(struct pci_dev *pdev) { }
569 static inline void pcie_aspm_pm_state_change(struct pci_dev *pdev) { }
570 static inline void pcie_aspm_powersave_config_link(struct pci_dev *pdev) { }
> 571 static inline int pcie_aspm_policy_override(struct pci_dev *dev) { return -EINVAL }
572 #endif
573
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-08 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 22:30 [V2 1/2] PCI/ASPM: Add ASPM BIOS override function David E. Box
2021-12-07 22:30 ` [V2 2/2] PCI: vmd: Override ASPM on TGL/ADL VMD devices David E. Box
2021-12-08 0:51 ` kernel test robot [this message]
2021-12-08 0:51 ` [V2 1/2] PCI/ASPM: Add ASPM BIOS override function kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112080830.ItjrEFOo-lkp@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=jonathan.derrick@linux.dev \
--cc=kbuild-all@lists.01.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michael.a.bottini@linux.intel.com \
--cc=nirmal.patel@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.