From: "Denys Dmytriyenko" <denis@denix.org>
To: yogeshs@ti.com
Cc: Praneeth Bajjuri <praneeth@ti.com>,
Denys Dmytriyenko <denys@konsulko.com>,
meta-arago@lists.yoctoproject.org
Subject: Re: [meta-arago] [tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package
Date: Wed, 8 Dec 2021 08:08:06 -0500 [thread overview]
Message-ID: <20211208130806.GV18191@denix.org> (raw)
In-Reply-To: <20211208085841.45926-1-yogeshs@ti.com>
tisdk-build-scripts is the wrong place to update secdev. Like toolchains,
secdev package is considered an external system tool and is usually installed
in a central location systemwide (e.g. /opt). It may not be writable by a
regular user executing this build script.
On Wed, Dec 08, 2021 at 08:58:41AM +0000, Yogesh Siraswar via lists.yoctoproject.org wrote:
> Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
> ---
> build-oesdk.sh | 3 +++
> lib/oesdk/update_secdev.sh | 7 +++++++
> 2 files changed, 10 insertions(+)
> create mode 100755 lib/oesdk/update_secdev.sh
>
> diff --git a/build-oesdk.sh b/build-oesdk.sh
> index 038a7ab..3d32fb2 100755
> --- a/build-oesdk.sh
> +++ b/build-oesdk.sh
> @@ -14,6 +14,9 @@ source ./lib/oesdk/machine-specific-functions
> source ./lib/oesdk/package-sdks
> source ./lib/oesdk/generate-report
>
> +# Update secdev package
> +./lib/oesdk/update_secdev.sh
> +
> # This variable holds the architectures that are being built based
> # on the machines.
> ARCHS=""
> diff --git a/lib/oesdk/update_secdev.sh b/lib/oesdk/update_secdev.sh
> new file mode 100755
> index 0000000..1f0a409
> --- /dev/null
> +++ b/lib/oesdk/update_secdev.sh
> @@ -0,0 +1,7 @@
> +#!/bin/bash
> +
> +cd $TI_SECURE_DEV_PKG_K3
> +git pull origin master
> +if [ $? != 0 ]; then
> + echo "Updating the secdev failed"
> +fi
> --
> 2.17.1
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
next prev parent reply other threads:[~2021-12-08 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 8:58 [tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package Yogesh Siraswar
2021-12-08 13:08 ` Denys Dmytriyenko [this message]
2021-12-09 11:57 ` [meta-arago] " Yogesh Siraswar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208130806.GV18191@denix.org \
--to=denis@denix.org \
--cc=denys@konsulko.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=praneeth@ti.com \
--cc=yogeshs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.