[tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package

[tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package

[Yogesh Siraswar]

Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
---
 build-oesdk.sh             | 3 +++
 lib/oesdk/update_secdev.sh | 7 +++++++
 2 files changed, 10 insertions(+)
 create mode 100755 lib/oesdk/update_secdev.sh

diff --git a/build-oesdk.sh b/build-oesdk.sh
index 038a7ab..3d32fb2 100755
--- a/build-oesdk.sh
+++ b/build-oesdk.sh
@@ -14,6 +14,9 @@ source ./lib/oesdk/machine-specific-functions
 source ./lib/oesdk/package-sdks
 source ./lib/oesdk/generate-report
 
+# Update secdev package
+./lib/oesdk/update_secdev.sh
+
 # This variable holds the architectures that are being built based
 # on the machines.
 ARCHS=""
diff --git a/lib/oesdk/update_secdev.sh b/lib/oesdk/update_secdev.sh
new file mode 100755
index 0000000..1f0a409
--- /dev/null
+++ b/lib/oesdk/update_secdev.sh
@@ -0,0 +1,7 @@
+#!/bin/bash
+
+cd $TI_SECURE_DEV_PKG_K3
+git pull origin master
+if [ $? != 0 ]; then
+        echo "Updating the secdev failed"
+fi
-- 
2.17.1

Re: [meta-arago] [tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package

[Denys Dmytriyenko]

tisdk-build-scripts is the wrong place to update secdev. Like toolchains, 
secdev package is considered an external system tool and is usually installed 
in a central location systemwide (e.g. /opt). It may not be writable by a 
regular user executing this build script.


On Wed, Dec 08, 2021 at 08:58:41AM +0000, Yogesh Siraswar via lists.yoctoproject.org wrote:
> Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
> ---
>  build-oesdk.sh             | 3 +++
>  lib/oesdk/update_secdev.sh | 7 +++++++
>  2 files changed, 10 insertions(+)
>  create mode 100755 lib/oesdk/update_secdev.sh
> 
> diff --git a/build-oesdk.sh b/build-oesdk.sh
> index 038a7ab..3d32fb2 100755
> --- a/build-oesdk.sh
> +++ b/build-oesdk.sh
> @@ -14,6 +14,9 @@ source ./lib/oesdk/machine-specific-functions
>  source ./lib/oesdk/package-sdks
>  source ./lib/oesdk/generate-report
>  
> +# Update secdev package
> +./lib/oesdk/update_secdev.sh
> +
>  # This variable holds the architectures that are being built based
>  # on the machines.
>  ARCHS=""
> diff --git a/lib/oesdk/update_secdev.sh b/lib/oesdk/update_secdev.sh
> new file mode 100755
> index 0000000..1f0a409
> --- /dev/null
> +++ b/lib/oesdk/update_secdev.sh
> @@ -0,0 +1,7 @@
> +#!/bin/bash
> +
> +cd $TI_SECURE_DEV_PKG_K3
> +git pull origin master
> +if [ $? != 0 ]; then
> +        echo "Updating the secdev failed"
> +fi
> -- 
> 2.17.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [meta-arago] [tisdk-build-scripts][PATCH] secdev: Add script to update k3 secdev package

[Yogesh Siraswar]

On 12/8/21 7:08 AM, Denys Dmytriyenko wrote:
> tisdk-build-scripts is the wrong place to update secdev. Like toolchains,
> secdev package is considered an external system tool and is usually installed
> in a central location systemwide (e.g. /opt). It may not be writable by a
> regular user executing this build script.
> 
Agree. Will revert the patch.
> 
> On Wed, Dec 08, 2021 at 08:58:41AM +0000, Yogesh Siraswar via lists.yoctoproject.org wrote:
>> Signed-off-by: Yogesh Siraswar <yogeshs@ti.com>
>> ---
>>   build-oesdk.sh             | 3 +++
>>   lib/oesdk/update_secdev.sh | 7 +++++++
>>   2 files changed, 10 insertions(+)
>>   create mode 100755 lib/oesdk/update_secdev.sh
>>
>> diff --git a/build-oesdk.sh b/build-oesdk.sh
>> index 038a7ab..3d32fb2 100755
>> --- a/build-oesdk.sh
>> +++ b/build-oesdk.sh
>> @@ -14,6 +14,9 @@ source ./lib/oesdk/machine-specific-functions
>>   source ./lib/oesdk/package-sdks
>>   source ./lib/oesdk/generate-report
>>   
>> +# Update secdev package
>> +./lib/oesdk/update_secdev.sh
>> +
>>   # This variable holds the architectures that are being built based
>>   # on the machines.
>>   ARCHS=""
>> diff --git a/lib/oesdk/update_secdev.sh b/lib/oesdk/update_secdev.sh
>> new file mode 100755
>> index 0000000..1f0a409
>> --- /dev/null
>> +++ b/lib/oesdk/update_secdev.sh
>> @@ -0,0 +1,7 @@
>> +#!/bin/bash
>> +
>> +cd $TI_SECURE_DEV_PKG_K3
>> +git pull origin master
>> +if [ $? != 0 ]; then
>> +        echo "Updating the secdev failed"
>> +fi
>> -- 
>> 2.17.1
>