From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 11/18] tcp: ipv4: Add AO signing for skb-less replies
Date: Thu, 09 Dec 2021 07:37:45 +0800 [thread overview]
Message-ID: <202112090745.LdVOpiG4-lkp@intel.com> (raw)
In-Reply-To: <d3b625c0fadc66c92cc1065c0b9eb3af174adcdb.1638962992.git.cdleonard@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6117 bytes --]
Hi Leonard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 1fe5b01262844be03de98afdd56d1d393df04d7e]
url: https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211208-194125
base: 1fe5b01262844be03de98afdd56d1d393df04d7e
config: openrisc-randconfig-r014-20211208 (https://download.01.org/0day-ci/archive/20211209/202112090745.LdVOpiG4-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8d4bf3a9b770cb44bf4e37e794e63f7db7a08cb6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211208-194125
git checkout 8d4bf3a9b770cb44bf4e37e794e63f7db7a08cb6
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/ipv4/tcp_ipv4.c: In function 'tcp_v4_send_ack':
>> net/ipv4/tcp_ipv4.c:909:52: warning: parameter 'key' set but not used [-Wunused-but-set-parameter]
909 | struct tcp_md5sig_key *key,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~
vim +/key +909 net/ipv4/tcp_ipv4.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 901
^1da177e4c3f41 Linus Torvalds 2005-04-16 902 /* The code following below sending ACKs in SYN-RECV and TIME-WAIT states
^1da177e4c3f41 Linus Torvalds 2005-04-16 903 outside socket context is ugly, certainly. What can I do?
^1da177e4c3f41 Linus Torvalds 2005-04-16 904 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 905
e2d118a1cb5e60 Lorenzo Colitti 2016-11-04 906 static void tcp_v4_send_ack(const struct sock *sk,
e62a123b8ef7c5 Eric Dumazet 2016-01-21 907 struct sk_buff *skb, u32 seq, u32 ack,
ee684b6f283004 Andrey Vagin 2013-02-11 908 u32 win, u32 tsval, u32 tsecr, int oif,
88ef4a5a78e634 KOVACS Krisztian 2008-10-01 @909 struct tcp_md5sig_key *key,
66b13d99d96a1a Eric Dumazet 2011-10-24 910 int reply_flags, u8 tos)
^1da177e4c3f41 Linus Torvalds 2005-04-16 911 {
cf533ea53ebfae Eric Dumazet 2011-10-21 912 const struct tcphdr *th = tcp_hdr(skb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 913 struct {
^1da177e4c3f41 Linus Torvalds 2005-04-16 914 struct tcphdr th;
714e85be355722 Al Viro 2006-11-14 915 __be32 opt[(TCPOLEN_TSTAMP_ALIGNED >> 2)
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 916 #ifdef CONFIG_TCP_MD5SIG
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 917 + (TCPOLEN_MD5SIG_ALIGNED >> 2)
8d4bf3a9b770cb Leonard Crestez 2021-12-08 918 #elif defined(CONFIG_TCP_AUTHOPT)
8d4bf3a9b770cb Leonard Crestez 2021-12-08 919 + (TCPOLEN_AUTHOPT_OUTPUT >> 2)
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 920 #endif
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 921 ];
^1da177e4c3f41 Linus Torvalds 2005-04-16 922 } rep;
e2d118a1cb5e60 Lorenzo Colitti 2016-11-04 923 struct net *net = sock_net(sk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 924 struct ip_reply_arg arg;
00483690552c5f Jon Maxwell 2018-05-10 925 struct sock *ctl_sk;
d6fb396cfaa71a Eric Dumazet 2019-06-13 926 u64 transmit_time;
^1da177e4c3f41 Linus Torvalds 2005-04-16 927
^1da177e4c3f41 Linus Torvalds 2005-04-16 928 memset(&rep.th, 0, sizeof(struct tcphdr));
7174259e6ced15 Arnaldo Carvalho de Melo 2006-11-17 929 memset(&arg, 0, sizeof(arg));
^1da177e4c3f41 Linus Torvalds 2005-04-16 930
^1da177e4c3f41 Linus Torvalds 2005-04-16 931 arg.iov[0].iov_base = (unsigned char *)&rep;
^1da177e4c3f41 Linus Torvalds 2005-04-16 932 arg.iov[0].iov_len = sizeof(rep.th);
ee684b6f283004 Andrey Vagin 2013-02-11 933 if (tsecr) {
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 934 rep.opt[0] = htonl((TCPOPT_NOP << 24) | (TCPOPT_NOP << 16) |
^1da177e4c3f41 Linus Torvalds 2005-04-16 935 (TCPOPT_TIMESTAMP << 8) |
^1da177e4c3f41 Linus Torvalds 2005-04-16 936 TCPOLEN_TIMESTAMP);
ee684b6f283004 Andrey Vagin 2013-02-11 937 rep.opt[1] = htonl(tsval);
ee684b6f283004 Andrey Vagin 2013-02-11 938 rep.opt[2] = htonl(tsecr);
cb48cfe8079ddd Craig Schlenter 2007-01-09 939 arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED;
^1da177e4c3f41 Linus Torvalds 2005-04-16 940 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 941
^1da177e4c3f41 Linus Torvalds 2005-04-16 942 /* Swap the send and the receive. */
^1da177e4c3f41 Linus Torvalds 2005-04-16 943 rep.th.dest = th->source;
^1da177e4c3f41 Linus Torvalds 2005-04-16 944 rep.th.source = th->dest;
^1da177e4c3f41 Linus Torvalds 2005-04-16 945 rep.th.doff = arg.iov[0].iov_len / 4;
^1da177e4c3f41 Linus Torvalds 2005-04-16 946 rep.th.seq = htonl(seq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 947 rep.th.ack_seq = htonl(ack);
^1da177e4c3f41 Linus Torvalds 2005-04-16 948 rep.th.ack = 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 949 rep.th.window = htons(win);
^1da177e4c3f41 Linus Torvalds 2005-04-16 950
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-08 23:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 11:37 [PATCH v3 00/18] tcp: Initial support for RFC5925 auth option Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 01/18] tcp: authopt: Initial support and key management Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 02/18] docs: Add user documentation for tcp_authopt Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 03/18] tcp: authopt: Add crypto initialization Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 04/18] tcp: md5: Refactor tcp_sig_hash_skb_data for AO Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 05/18] tcp: authopt: Compute packet signatures Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 06/18] tcp: authopt: Hook into tcp core Leonard Crestez
2021-12-08 16:45 ` kernel test robot
2021-12-08 20:39 ` kernel test robot
2021-12-08 20:39 ` kernel test robot
2021-12-09 12:58 ` kernel test robot
2021-12-08 11:37 ` [PATCH v3 07/18] tcp: authopt: Disable via sysctl by default Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 08/18] tcp: authopt: Implement Sequence Number Extension Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 09/18] tcp: ipv6: Add AO signing for tcp_v6_send_response Leonard Crestez
2021-12-08 21:30 ` kernel test robot
2021-12-08 11:37 ` [PATCH v3 10/18] tcp: authopt: Add support for signing skb-less replies Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 11/18] tcp: ipv4: Add AO signing for " Leonard Crestez
2021-12-08 23:37 ` kernel test robot [this message]
2021-12-09 15:02 ` kernel test robot
2021-12-08 11:37 ` [PATCH v3 12/18] tcp: authopt: Add key selection controls Leonard Crestez
2021-12-09 16:57 ` kernel test robot
2021-12-08 11:37 ` [PATCH v3 13/18] tcp: authopt: Add initial l3index support Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 14/18] tcp: authopt: Add NOSEND/NORECV flags Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 15/18] tcp: authopt: Add prefixlen support Leonard Crestez
2021-12-09 19:01 ` kernel test robot
2021-12-08 11:37 ` [PATCH v3 16/18] selftests: nettest: Rename md5_prefix to key_addr_prefix Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 17/18] selftests: nettest: Initial tcp_authopt support Leonard Crestez
2021-12-08 11:37 ` [PATCH v3 18/18] selftests: net/fcnal: " Leonard Crestez
2021-12-13 10:31 ` [PATCH v3 00/18] tcp: Initial support for RFC5925 auth option Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112090745.LdVOpiG4-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.