From: Kees Cook <keescook@chromium.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] x86/boot/string: Add missing function declarations
Date: Thu, 9 Dec 2021 15:37:43 -0800 [thread overview]
Message-ID: <202112091536.2DDF0DF@keescook> (raw)
In-Reply-To: <20211119175325.3668419-1-keescook@chromium.org>
On Fri, Nov 19, 2021 at 09:53:25AM -0800, Kees Cook wrote:
> Silence "missing function declaration" warnings from string.h when
> building under W=1.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
Hi, just a quick ping on this little fix.
Thanks!
-Kees
> arch/x86/boot/string.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
> index a232da487cd2..e5d2c6b8c2f1 100644
> --- a/arch/x86/boot/string.h
> +++ b/arch/x86/boot/string.h
> @@ -8,8 +8,10 @@
> #undef memcmp
>
> void *memcpy(void *dst, const void *src, size_t len);
> +void *memmove(void *dst, const void *src, size_t len);
> void *memset(void *dst, int c, size_t len);
> int memcmp(const void *s1, const void *s2, size_t len);
> +int bcmp(const void *s1, const void *s2, size_t len);
>
> /* Access builtin version by default. */
> #define memcpy(d,s,l) __builtin_memcpy(d,s,l)
> @@ -25,6 +27,7 @@ extern size_t strnlen(const char *s, size_t maxlen);
> extern unsigned int atou(const char *s);
> extern unsigned long long simple_strtoull(const char *cp, char **endp,
> unsigned int base);
> +long simple_strtol(const char *cp, char **endp, unsigned int base);
>
> int kstrtoull(const char *s, unsigned int base, unsigned long long *res);
> int boot_kstrtoul(const char *s, unsigned int base, unsigned long *res);
> --
> 2.30.2
>
--
Kees Cook
next prev parent reply other threads:[~2021-12-09 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 17:53 [PATCH] x86/boot/string: Add missing function declarations Kees Cook
2021-12-09 23:37 ` Kees Cook [this message]
2021-12-09 23:47 ` Joe Perches
2021-12-10 18:57 ` [tip: x86/cleanups] x86/boot/string: Add missing function prototypes tip-bot2 for Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112091536.2DDF0DF@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.