All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"linux-mtd @ lists . infradead . org"
	<linux-mtd@lists.infradead.org>,
	linux-block <linux-block@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] mtd_blkdevs: don't scan partitions for plain mtdblock
Date: Mon, 13 Dec 2021 08:26:45 +0100	[thread overview]
Message-ID: <20211213072645.GA20552@lst.de> (raw)
In-Reply-To: <4bc1b80c-9c43-ccd6-de78-09f9a1627cc8@kernel.dk>

On Fri, Dec 10, 2021 at 11:52:26AM -0700, Jens Axboe wrote:
> > Fixes: 1ebe2e5f9d68e94c ("block: remove GENHD_FL_EXT_DEVT")
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Not sure why I didn't spot this until now, but:
> 
> drivers/mtd/mtd_blkdevs.c: In function ‘add_mtd_blktrans_dev’:
> drivers/mtd/mtd_blkdevs.c:362:30: error: ‘GENHD_FL_NO_PART’ undeclared (first use in this function); did you mean ‘GENHD_FL_NO_PART_SCAN’?
>   362 |                 gd->flags |= GENHD_FL_NO_PART;
>       |                              ^~~~~~~~~~~~~~~~
>       |                              GENHD_FL_NO_PART_SCAN
> drivers/mtd/mtd_blkdevs.c:362:30: note: each undeclared identifier is reported only once for each function it appears in
> 
> Hmm?
> 
> I'm going to revert this one for now, not sure how it could've been
> tested in this form.

It was tested in a tree that also contains the commit identified by the
Fixed tag, which is in the for-next tree but not the block-5.16 one.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	"linux-mtd @ lists . infradead . org"
	<linux-mtd@lists.infradead.org>,
	linux-block <linux-block@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] mtd_blkdevs: don't scan partitions for plain mtdblock
Date: Mon, 13 Dec 2021 08:26:45 +0100	[thread overview]
Message-ID: <20211213072645.GA20552@lst.de> (raw)
In-Reply-To: <4bc1b80c-9c43-ccd6-de78-09f9a1627cc8@kernel.dk>

On Fri, Dec 10, 2021 at 11:52:26AM -0700, Jens Axboe wrote:
> > Fixes: 1ebe2e5f9d68e94c ("block: remove GENHD_FL_EXT_DEVT")
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Not sure why I didn't spot this until now, but:
> 
> drivers/mtd/mtd_blkdevs.c: In function ‘add_mtd_blktrans_dev’:
> drivers/mtd/mtd_blkdevs.c:362:30: error: ‘GENHD_FL_NO_PART’ undeclared (first use in this function); did you mean ‘GENHD_FL_NO_PART_SCAN’?
>   362 |                 gd->flags |= GENHD_FL_NO_PART;
>       |                              ^~~~~~~~~~~~~~~~
>       |                              GENHD_FL_NO_PART_SCAN
> drivers/mtd/mtd_blkdevs.c:362:30: note: each undeclared identifier is reported only once for each function it appears in
> 
> Hmm?
> 
> I'm going to revert this one for now, not sure how it could've been
> tested in this form.

It was tested in a tree that also contains the commit identified by the
Fixed tag, which is in the for-next tree but not the block-5.16 one.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-12-13  7:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  7:04 [PATCH] mtd_blkdevs: don't scan partitions for plain mtdblock Christoph Hellwig
2021-12-06  7:04 ` Christoph Hellwig
2021-12-06 16:47 ` Jens Axboe
2021-12-06 16:47   ` Jens Axboe
2021-12-10 18:52 ` Jens Axboe
2021-12-10 18:52   ` Jens Axboe
2021-12-12 10:02   ` Geert Uytterhoeven
2021-12-12 10:02     ` Geert Uytterhoeven
2021-12-12 19:19     ` Jens Axboe
2021-12-12 19:19       ` Jens Axboe
2021-12-13  7:26   ` Christoph Hellwig [this message]
2021-12-13  7:26     ` Christoph Hellwig
2021-12-13 18:29 ` Jens Axboe
2021-12-13 18:29   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213072645.GA20552@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=geert+renesas@glider.be \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.