All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Alistair Francis" <alistair23@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-input <linux-input@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Mylene Josserand" <mylene.josserand@free-electrons.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Henrik Rydberg" <rydberg@bitmath.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mylène Josserand" <mylene.josserand@bootlin.com>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 13 Dec 2021 19:49:06 +0100	[thread overview]
Message-ID: <20211213194906.00fd028c@aktux> (raw)
In-Reply-To: <YbbeDFJERtP0mAIQ@google.com>

Hi,

On Sun, 12 Dec 2021 21:45:48 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:


> > > > +     rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq,
> > > > +                                    IRQF_TRIGGER_FALLING | IRQF_ONESHOT,  
> > >
> > > Please do not override platform setup with hardcoded triggers. Also, it
> > > is strongly recommended to use level interrupts for these peripherals.
> > >
> > > This is also likely unsafe if controller is not completely shut off and
> > > is capable of generating interrupts given input device is not yet
> > > allocated.  
> > 
> > I have dropped the `IRQF_TRIGGER_FALLING |`
> > 
> > I have tried to use level interrupts, but I can't get the device
> > working with them.  
> 
> That is weird, does the interrupt controller support level interrupts?
> 
hmm, it should, at least on the imx6 I am using them for some other
devices, I guess, on the imx7 they should work, too.
I hope I find time to give that a try the next days.

Regards,
Andreas

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Alistair Francis" <alistair23@gmail.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-input <linux-input@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Mylene Josserand" <mylene.josserand@free-electrons.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Henrik Rydberg" <rydberg@bitmath.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mylène Josserand" <mylene.josserand@bootlin.com>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>
Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen
Date: Mon, 13 Dec 2021 19:49:06 +0100	[thread overview]
Message-ID: <20211213194906.00fd028c@aktux> (raw)
In-Reply-To: <YbbeDFJERtP0mAIQ@google.com>

Hi,

On Sun, 12 Dec 2021 21:45:48 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:


> > > > +     rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq,
> > > > +                                    IRQF_TRIGGER_FALLING | IRQF_ONESHOT,  
> > >
> > > Please do not override platform setup with hardcoded triggers. Also, it
> > > is strongly recommended to use level interrupts for these peripherals.
> > >
> > > This is also likely unsafe if controller is not completely shut off and
> > > is capable of generating interrupts given input device is not yet
> > > allocated.  
> > 
> > I have dropped the `IRQF_TRIGGER_FALLING |`
> > 
> > I have tried to use level interrupts, but I can't get the device
> > working with them.  
> 
> That is weird, does the interrupt controller support level interrupts?
> 
hmm, it should, at least on the imx6 I am using them for some other
devices, I guess, on the imx7 they should work, too.
I hope I find time to give that a try the next days.

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-13 18:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 11:48 [PATCH v2 0/4] Add support for the Cypress cyttsp5 Alistair Francis
2021-11-03 11:48 ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-05 15:01   ` Andreas Kemnade
2021-11-05 15:01     ` Andreas Kemnade
2021-11-06  6:47   ` Dmitry Torokhov
2021-11-06  6:47     ` Dmitry Torokhov
2021-12-01 12:27     ` Alistair Francis
2021-12-01 12:27       ` Alistair Francis
2021-12-13  5:45       ` Dmitry Torokhov
2021-12-13  5:45         ` Dmitry Torokhov
2021-12-13 18:49         ` Andreas Kemnade [this message]
2021-12-13 18:49           ` Andreas Kemnade
2021-12-18 22:18         ` Andreas Kemnade
2021-12-18 22:18           ` Andreas Kemnade
2021-12-21 23:28           ` Alistair Francis
2021-12-21 23:28             ` Alistair Francis
2021-12-23 13:47   ` Andy Shevchenko
2021-12-23 13:47     ` Andy Shevchenko
2021-11-03 11:48 ` [PATCH v2 2/4] Documentation: DT: bindings: input: Add documentation for cyttsp5 Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-03 23:07   ` Rob Herring
2021-11-03 23:07     ` Rob Herring
2021-11-05 14:21   ` Andreas Kemnade
2021-11-05 14:21     ` Andreas Kemnade
2021-11-10 12:59     ` Alistair Francis
2021-11-10 12:59       ` Alistair Francis
2021-11-10 17:36       ` Andreas Kemnade
2021-11-10 17:36         ` Andreas Kemnade
2021-11-11 15:16         ` Linus Walleij
2021-11-11 15:16           ` Linus Walleij
2021-11-18 12:51           ` Alistair Francis
2021-11-18 12:51             ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 3/4] ARM: imx_v6_v7_defconfig: Enable the cyttsp5 touchscreen Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-03 11:48 ` [PATCH v2 4/4] ARM: dts: imx7d: remarkable2: Enable the cyttsp5 Alistair Francis
2021-11-03 11:48   ` Alistair Francis
2021-11-06  2:25   ` Dmitry Torokhov
2021-11-06  2:25     ` Dmitry Torokhov
2021-11-05 14:52 ` [PATCH v2 0/4] Add support for the Cypress cyttsp5 Andreas Kemnade
2021-11-05 14:52   ` Andreas Kemnade
2021-11-25  9:44   ` Alistair Francis
2021-11-25  9:44     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213194906.00fd028c@aktux \
    --to=andreas@kemnade.info \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mylene.josserand@bootlin.com \
    --cc=mylene.josserand@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.