All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Biwen Li <biwen.li@nxp.com>,
	Li Yang <leoyang.lil@nxp.com>
Subject: Re: [PATCH v2 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus
Date: Tue, 14 Dec 2021 13:48:05 +0800	[thread overview]
Message-ID: <20211214054805.GJ10916@dragon> (raw)
In-Reply-To: <20211204001718.8511-7-leoyang.li@nxp.com>

On Fri, Dec 03, 2021 at 06:17:16PM -0600, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> The i2c rtc is on i2c2 bus not i2c1 bus, so fix it in dts.
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.lil@nxp.com>

Do we need a Fixes tag?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 00d5b81bdef3..baa1cc9b9835 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -276,11 +276,6 @@ temperature-sensor@4c {
>  				vcc-supply = <&sb_3v3>;
>  			};
>  
> -			rtc@51 {
> -				compatible = "nxp,pcf2129";
> -				reg = <0x51>;
> -			};
> -
>  			eeprom@56 {
>  				compatible = "atmel,24c512";
>  				reg = <0x56>;
> @@ -322,6 +317,15 @@ mux: mux-controller {
>  
>  };
>  
> +&i2c1 {
> +	status = "okay";
> +
> +	rtc@51 {
> +		compatible = "nxp,pcf2129";
> +		reg = <0x51>;
> +	};
> +};
> +
>  &enetc_port1 {
>  	phy-handle = <&qds_phy1>;
>  	phy-mode = "rgmii-id";
> -- 
> 2.25.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Biwen Li <biwen.li@nxp.com>,
	Li Yang <leoyang.lil@nxp.com>
Subject: Re: [PATCH v2 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus
Date: Tue, 14 Dec 2021 13:48:05 +0800	[thread overview]
Message-ID: <20211214054805.GJ10916@dragon> (raw)
In-Reply-To: <20211204001718.8511-7-leoyang.li@nxp.com>

On Fri, Dec 03, 2021 at 06:17:16PM -0600, Li Yang wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> The i2c rtc is on i2c2 bus not i2c1 bus, so fix it in dts.
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> Signed-off-by: Li Yang <leoyang.lil@nxp.com>

Do we need a Fixes tag?

Shawn

> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 00d5b81bdef3..baa1cc9b9835 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -276,11 +276,6 @@ temperature-sensor@4c {
>  				vcc-supply = <&sb_3v3>;
>  			};
>  
> -			rtc@51 {
> -				compatible = "nxp,pcf2129";
> -				reg = <0x51>;
> -			};
> -
>  			eeprom@56 {
>  				compatible = "atmel,24c512";
>  				reg = <0x56>;
> @@ -322,6 +317,15 @@ mux: mux-controller {
>  
>  };
>  
> +&i2c1 {
> +	status = "okay";
> +
> +	rtc@51 {
> +		compatible = "nxp,pcf2129";
> +		reg = <0x51>;
> +	};
> +};
> +
>  &enetc_port1 {
>  	phy-handle = <&qds_phy1>;
>  	phy-mode = "rgmii-id";
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-12-14  5:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-04  0:17 [PATCH v2 0/8] ls1028a device tree update Li Yang
2021-12-04  0:17 ` Li Yang
2021-12-04  0:17 ` [PATCH v2 1/8] arm64: dts: ls1028a: Add PCIe EP nodes Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-14  5:42   ` Shawn Guo
2021-12-14  5:42     ` Shawn Guo
2021-12-04  0:17 ` [PATCH v2 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-14  5:46   ` Shawn Guo
2021-12-14  5:46     ` Shawn Guo
2021-12-14  6:16     ` Leo Li
2021-12-14  6:16       ` Leo Li
2021-12-14  6:20       ` Biwen Li
2021-12-14  6:20         ` Biwen Li
2021-12-04  0:17 ` [PATCH v2 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-04  0:17 ` [PATCH v2 4/8] arm64: dts: ls1028a-rdb: reorder nodes to be alphabetic Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-04  0:17 ` [PATCH v2 5/8] arm64: dts: ls1028a-rdb: enable pwm0 Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-04  0:17 ` [PATCH v2 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-14  5:48   ` Shawn Guo [this message]
2021-12-14  5:48     ` Shawn Guo
2021-12-04  0:17 ` [PATCH v2 7/8] arm64: dts: ls1028a-qds: enable lpuart1 Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-04 12:01   ` Vladimir Oltean
2021-12-04 12:01     ` Vladimir Oltean
2021-12-04  0:17 ` [PATCH v2 8/8] arm64: dts: ls1028a-qds: add overlays for various serdes protocols Li Yang
2021-12-04  0:17   ` Li Yang
2021-12-14  7:21   ` Shawn Guo
2021-12-14  7:21     ` Shawn Guo
2021-12-14  8:14     ` Leo Li
2021-12-14  8:14       ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214054805.GJ10916@dragon \
    --to=shawnguo@kernel.org \
    --cc=biwen.li@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=leoyang.lil@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.