All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Rudo <prudo@redhat.com>
To: lizhe <sensor1010@163.com>
Cc: dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/crash_core.c: No judgment required
Date: Tue, 14 Dec 2021 17:32:42 +0100	[thread overview]
Message-ID: <20211214173242.192f47e8@rhtmp> (raw)
In-Reply-To: <20211210032003.16278-1-sensor1010@163.com>

Hi lizhe,

On Thu,  9 Dec 2021 19:20:03 -0800
lizhe <sensor1010@163.com> wrote:

> No judgment required ck_cmdline is NULL
> its caller has alreadly judged, see __parse_crashkernel
> function
> 
> Signed-off-by: lizhe <sensor1010@163.com>
> ---
>  kernel/crash_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index eb53f5ec62c9..9981cf9b9fe4 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
>  		p = strstr(p+1, name);
>  	}
>  
> -	if (!ck_cmdline)
> -		return NULL;
> -
>  	return ck_cmdline;
>  }
>  

I agree that the if-block is not needed and can be removed. However, I
cannot follow your reasoning in the commit message. Could you please
explain it in more detail.

The reason why I think that the 'if' can be removed is that the
expression can only be true when ck_cmdline = NULL. But with that the
last three lines are equivalent to

	if (!ck_cmdline)
		return ck_cmdline;

	return ck_cmdline;

Which simply doesn't make any sense.

Thanks
Philipp


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Philipp Rudo <prudo@redhat.com>
To: lizhe <sensor1010@163.com>
Cc: dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/crash_core.c: No judgment required
Date: Tue, 14 Dec 2021 17:32:42 +0100	[thread overview]
Message-ID: <20211214173242.192f47e8@rhtmp> (raw)
In-Reply-To: <20211210032003.16278-1-sensor1010@163.com>

Hi lizhe,

On Thu,  9 Dec 2021 19:20:03 -0800
lizhe <sensor1010@163.com> wrote:

> No judgment required ck_cmdline is NULL
> its caller has alreadly judged, see __parse_crashkernel
> function
> 
> Signed-off-by: lizhe <sensor1010@163.com>
> ---
>  kernel/crash_core.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index eb53f5ec62c9..9981cf9b9fe4 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
>  		p = strstr(p+1, name);
>  	}
>  
> -	if (!ck_cmdline)
> -		return NULL;
> -
>  	return ck_cmdline;
>  }
>  

I agree that the if-block is not needed and can be removed. However, I
cannot follow your reasoning in the commit message. Could you please
explain it in more detail.

The reason why I think that the 'if' can be removed is that the
expression can only be true when ck_cmdline = NULL. But with that the
last three lines are equivalent to

	if (!ck_cmdline)
		return ck_cmdline;

	return ck_cmdline;

Which simply doesn't make any sense.

Thanks
Philipp


  reply	other threads:[~2021-12-14 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10  3:20 [PATCH] kernel/crash_core.c: No judgment required lizhe
2021-12-10  3:20 ` lizhe
2021-12-14 16:32 ` Philipp Rudo [this message]
2021-12-14 16:32   ` Philipp Rudo
2022-04-25  1:36   ` Baoquan He
2022-04-25  1:36     ` Baoquan He
     [not found]     ` <62058381.3b6e.1805f62c8f4.Coremail.sensor1010@163.com>
2022-04-26  8:17       ` Philipp Rudo
2022-04-26  8:17         ` Philipp Rudo
2022-04-26  8:20         ` Philipp Rudo
2022-04-26  8:20           ` Philipp Rudo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214173242.192f47e8@rhtmp \
    --to=prudo@redhat.com \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensor1010@163.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.