Re: [PATCH v7 04/14] ima: Move policy related variables into ima_namespace

[kernel test robot <lkp@intel.com>]

Hi Stefan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on zohar-integrity/next-integrity]
[also build test ERROR on linux/master linus/master v5.16-rc5]
[cannot apply to jmorris-security/next-testing next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211216-134611
base:   https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git next-integrity
config: alpha-buildonly-randconfig-r004-20211216 (https://download.01.org/0day-ci/archive/20211216/202112162247.XcCvdc6L-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4927ddb1c276a9aa164fced45c2614ec93b5b425
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stefan-Berger/ima-Namespace-IMA-with-audit-support-in-IMA-ns/20211216-134611
        git checkout 4927ddb1c276a9aa164fced45c2614ec93b5b425
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash security/integrity/ima/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   security/integrity/ima/ima_policy.c: In function 'ima_update_policy':
>> security/integrity/ima/ima_policy.c:1014:9: error: too many arguments to function 'ima_process_queued_keys'
    1014 |         ima_process_queued_keys(ns);
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from security/integrity/ima/ima_policy.c:23:
   security/integrity/ima/ima.h:276:20: note: declared here
     276 | static inline void ima_process_queued_keys(void) {}
         |                    ^~~~~~~~~~~~~~~~~~~~~~~


vim +/ima_process_queued_keys +1014 security/integrity/ima/ima_policy.c

   980	
   981	/**
   982	 * ima_update_policy - update default_rules with new measure rules
   983	 * @ns: IMA namespace that has the policy
   984	 * Called on file .release to update the default rules with a complete new
   985	 * policy.  What we do here is to splice ima_policy_rules and ima_temp_rules so
   986	 * they make a queue.  The policy may be updated multiple times and this is the
   987	 * RCU updater.
   988	 *
   989	 * Policy rules are never deleted so ima_policy_flag gets zeroed only once when
   990	 * we switch from the default policy to user defined.
   991	 */
   992	void ima_update_policy(struct ima_namespace *ns)
   993	{
   994		struct list_head *policy = &ns->ima_policy_rules;
   995	
   996		list_splice_tail_init_rcu(&ns->ima_temp_rules, policy,
   997					  synchronize_rcu);
   998	
   999		if (ns->ima_rules != (struct list_head __rcu *)policy) {
  1000			ns->ima_policy_flag = 0;
  1001	
  1002			rcu_assign_pointer(ns->ima_rules, policy);
  1003			/*
  1004			 * IMA architecture specific policy rules are specified
  1005			 * as strings and converted to an array of ima_entry_rules
  1006			 * on boot.  After loading a custom policy, free the
  1007			 * architecture specific rules stored as an array.
  1008			 */
  1009			kfree(arch_policy_entry);
  1010		}
  1011		ima_update_policy_flags(ns);
  1012	
  1013		/* Custom IMA policy has been loaded */
> 1014		ima_process_queued_keys(ns);
  1015	}
  1016	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org