From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steven Price <steven.price@arm.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH] drm/panfrost: Avoid user size passed to kvmalloc()
Date: Fri, 17 Dec 2021 12:10:46 +0300 [thread overview]
Message-ID: <20211217091046.GG1978@kadam> (raw)
In-Reply-To: <4c564c0d-7702-9dfe-910f-969fe130aba8@arm.com>
On Fri, Dec 17, 2021 at 08:55:50AM +0000, Steven Price wrote:
> However this one is harder to fix without setting an arbitrary cap on
> the number of BOs during a sumbit. I'm not sure how other drivers handle
> this - the ones I've looked at so far all have the same issue. There's
> obviously the list that Dan already sent, but e.g. msm has the same bug
> in msm_gem_submit.c:submit_create() with an amusing bug where the check
> for (sz > SIZE_MAX) will never hit, although the call is to kzalloc() so
> large allocations are going to fail anyway.
sz is u64 and SIZE_MAX is ULONG_MAX so the (sz > SIZE_MAX) condition
does work to prevent an integer overflow on 32bit systems. But it's not
beautiful.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steven Price <steven.price@arm.com>
Cc: Rob Herring <robh@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/panfrost: Avoid user size passed to kvmalloc()
Date: Fri, 17 Dec 2021 12:10:46 +0300 [thread overview]
Message-ID: <20211217091046.GG1978@kadam> (raw)
In-Reply-To: <4c564c0d-7702-9dfe-910f-969fe130aba8@arm.com>
On Fri, Dec 17, 2021 at 08:55:50AM +0000, Steven Price wrote:
> However this one is harder to fix without setting an arbitrary cap on
> the number of BOs during a sumbit. I'm not sure how other drivers handle
> this - the ones I've looked at so far all have the same issue. There's
> obviously the list that Dan already sent, but e.g. msm has the same bug
> in msm_gem_submit.c:submit_create() with an amusing bug where the check
> for (sz > SIZE_MAX) will never hit, although the call is to kzalloc() so
> large allocations are going to fail anyway.
sz is u64 and SIZE_MAX is ULONG_MAX so the (sz > SIZE_MAX) condition
does work to prevent an integer overflow on 32bit systems. But it's not
beautiful.
regards,
dan carpenter
next prev parent reply other threads:[~2021-12-17 9:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:16 [PATCH] drm/panfrost: Avoid user size passed to kvmalloc() Steven Price
2021-12-16 16:16 ` Steven Price
2021-12-16 17:12 ` Rob Herring
2021-12-16 17:12 ` Rob Herring
2021-12-17 8:55 ` Steven Price
2021-12-17 8:55 ` Steven Price
2021-12-17 9:10 ` Dan Carpenter [this message]
2021-12-17 9:10 ` Dan Carpenter
2021-12-17 9:16 ` Steven Price
2021-12-17 9:16 ` Steven Price
2021-12-17 9:28 ` Dan Carpenter
2021-12-17 9:28 ` Dan Carpenter
2021-12-17 9:48 ` Steven Price
2021-12-17 9:48 ` Steven Price
2021-12-16 17:49 ` Alyssa Rosenzweig
2021-12-16 17:49 ` Alyssa Rosenzweig
2021-12-17 6:40 ` Dan Carpenter
2021-12-17 6:40 ` Dan Carpenter
2021-12-17 7:38 ` Tomeu Vizoso
2021-12-17 7:38 ` Tomeu Vizoso
2021-12-17 8:56 ` Steven Price
2021-12-17 8:56 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211217091046.GG1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.