From: kernel test robot <lkp@intel.com>
To: Kishen Maloor <kishen.maloor@intel.com>, mptcp@lists.linux.dev
Cc: kbuild-all@lists.01.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH mptcp-next 17/21] mptcp: netlink: allow userspace-driven subflow establishment
Date: Fri, 17 Dec 2021 10:52:17 +0800 [thread overview]
Message-ID: <202112171003.GmuMEIxi-lkp@intel.com> (raw)
In-Reply-To: <20211216222314.1244708-18-kishen.maloor@intel.com>
Hi Kishen,
I love your patch! Yet something to improve:
[auto build test ERROR on f81a8b95bfe9cae8ff02739e3e263d9310422af7]
url: https://github.com/0day-ci/linux/commits/Kishen-Maloor/mptcp-support-userspace-path-management/20211217-062636
base: f81a8b95bfe9cae8ff02739e3e263d9310422af7
config: sparc-randconfig-r004-20211216 (https://download.01.org/0day-ci/archive/20211217/202112171003.GmuMEIxi-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ece3dbcf3e16211dda7bdeb0f00b2450e776814d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kishen-Maloor/mptcp-support-userspace-path-management/20211217-062636
git checkout ece3dbcf3e16211dda7bdeb0f00b2450e776814d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash net/mptcp/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mptcp/pm_netlink.c: In function 'mptcp_nl_find_ssk':
>> net/mptcp/pm_netlink.c:2613:54: error: 'const struct mptcp_addr_info' has no member named 'addr6'; did you mean 'addr'?
2613 | if (!ipv6_addr_equal(&local->addr6, &pinfo->saddr) ||
| ^~~~~
| addr
net/mptcp/pm_netlink.c:2614:55: error: 'const struct mptcp_addr_info' has no member named 'addr6'; did you mean 'addr'?
2614 | !ipv6_addr_equal(&remote->addr6, &ssk->sk_v6_daddr))
| ^~~~~
| addr
vim +2613 net/mptcp/pm_netlink.c
2579
2580 static struct sock *mptcp_nl_find_ssk(struct mptcp_sock *msk,
2581 const struct mptcp_addr_info *local,
2582 const struct mptcp_addr_info *remote)
2583 {
2584 struct sock *sk = &msk->sk.icsk_inet.sk;
2585 struct mptcp_subflow_context *subflow;
2586 struct sock *found = NULL;
2587
2588 if (local->family != remote->family)
2589 return NULL;
2590
2591 lock_sock(sk);
2592
2593 mptcp_for_each_subflow(msk, subflow) {
2594 const struct ipv6_pinfo *pinfo;
2595 const struct inet_sock *issk;
2596 struct sock *ssk;
2597
2598 ssk = mptcp_subflow_tcp_sock(subflow);
2599
2600 if (local->family != ssk->sk_family)
2601 continue;
2602
2603 issk = inet_sk(ssk);
2604
2605 switch (ssk->sk_family) {
2606 case AF_INET:
2607 if (issk->inet_saddr != local->addr.s_addr ||
2608 issk->inet_daddr != remote->addr.s_addr)
2609 continue;
2610 break;
2611 case AF_INET6:
2612 pinfo = inet6_sk(ssk);
> 2613 if (!ipv6_addr_equal(&local->addr6, &pinfo->saddr) ||
2614 !ipv6_addr_equal(&remote->addr6, &ssk->sk_v6_daddr))
2615 continue;
2616 break;
2617 default:
2618 continue;
2619 }
2620
2621 if (issk->inet_sport == local->port &&
2622 issk->inet_dport == remote->port) {
2623 found = ssk;
2624 goto found;
2625 }
2626 }
2627
2628 found:
2629 release_sock(sk);
2630
2631 return found;
2632 }
2633
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH mptcp-next 17/21] mptcp: netlink: allow userspace-driven subflow establishment
Date: Fri, 17 Dec 2021 10:52:17 +0800 [thread overview]
Message-ID: <202112171003.GmuMEIxi-lkp@intel.com> (raw)
In-Reply-To: <20211216222314.1244708-18-kishen.maloor@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3857 bytes --]
Hi Kishen,
I love your patch! Yet something to improve:
[auto build test ERROR on f81a8b95bfe9cae8ff02739e3e263d9310422af7]
url: https://github.com/0day-ci/linux/commits/Kishen-Maloor/mptcp-support-userspace-path-management/20211217-062636
base: f81a8b95bfe9cae8ff02739e3e263d9310422af7
config: sparc-randconfig-r004-20211216 (https://download.01.org/0day-ci/archive/20211217/202112171003.GmuMEIxi-lkp(a)intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ece3dbcf3e16211dda7bdeb0f00b2450e776814d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kishen-Maloor/mptcp-support-userspace-path-management/20211217-062636
git checkout ece3dbcf3e16211dda7bdeb0f00b2450e776814d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sparc SHELL=/bin/bash net/mptcp/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mptcp/pm_netlink.c: In function 'mptcp_nl_find_ssk':
>> net/mptcp/pm_netlink.c:2613:54: error: 'const struct mptcp_addr_info' has no member named 'addr6'; did you mean 'addr'?
2613 | if (!ipv6_addr_equal(&local->addr6, &pinfo->saddr) ||
| ^~~~~
| addr
net/mptcp/pm_netlink.c:2614:55: error: 'const struct mptcp_addr_info' has no member named 'addr6'; did you mean 'addr'?
2614 | !ipv6_addr_equal(&remote->addr6, &ssk->sk_v6_daddr))
| ^~~~~
| addr
vim +2613 net/mptcp/pm_netlink.c
2579
2580 static struct sock *mptcp_nl_find_ssk(struct mptcp_sock *msk,
2581 const struct mptcp_addr_info *local,
2582 const struct mptcp_addr_info *remote)
2583 {
2584 struct sock *sk = &msk->sk.icsk_inet.sk;
2585 struct mptcp_subflow_context *subflow;
2586 struct sock *found = NULL;
2587
2588 if (local->family != remote->family)
2589 return NULL;
2590
2591 lock_sock(sk);
2592
2593 mptcp_for_each_subflow(msk, subflow) {
2594 const struct ipv6_pinfo *pinfo;
2595 const struct inet_sock *issk;
2596 struct sock *ssk;
2597
2598 ssk = mptcp_subflow_tcp_sock(subflow);
2599
2600 if (local->family != ssk->sk_family)
2601 continue;
2602
2603 issk = inet_sk(ssk);
2604
2605 switch (ssk->sk_family) {
2606 case AF_INET:
2607 if (issk->inet_saddr != local->addr.s_addr ||
2608 issk->inet_daddr != remote->addr.s_addr)
2609 continue;
2610 break;
2611 case AF_INET6:
2612 pinfo = inet6_sk(ssk);
> 2613 if (!ipv6_addr_equal(&local->addr6, &pinfo->saddr) ||
2614 !ipv6_addr_equal(&remote->addr6, &ssk->sk_v6_daddr))
2615 continue;
2616 break;
2617 default:
2618 continue;
2619 }
2620
2621 if (issk->inet_sport == local->port &&
2622 issk->inet_dport == remote->port) {
2623 found = ssk;
2624 goto found;
2625 }
2626 }
2627
2628 found:
2629 release_sock(sk);
2630
2631 return found;
2632 }
2633
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2021-12-17 2:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 22:22 [PATCH mptcp-next 00/21] mptcp: support userspace path management Kishen Maloor
2021-12-16 22:22 ` [PATCH mptcp-next 01/21] mptcp: do not restrict subflows with non-kernel PMs Kishen Maloor
2021-12-16 22:22 ` [PATCH mptcp-next 02/21] mptcp: store remote id from MP_JOIN SYN/ACK in local ctx Kishen Maloor
2021-12-16 22:22 ` [PATCH mptcp-next 03/21] mptcp: reflect remote port (not 0) in ANNOUNCED events Kishen Maloor
2021-12-16 22:22 ` [PATCH mptcp-next 04/21] mptcp: establish subflows from either end of connection Kishen Maloor
2021-12-17 17:41 ` Paolo Abeni
2021-12-21 7:35 ` Kishen Maloor
2021-12-16 22:22 ` [PATCH mptcp-next 05/21] mptcp: netlink: store per namespace list of refcounted listen socks Kishen Maloor
2021-12-17 16:24 ` Matthieu Baerts
2021-12-16 22:22 ` [PATCH mptcp-next 06/21] mptcp: netlink: store lsk ref in mptcp_pm_addr_entry Kishen Maloor
2021-12-17 16:25 ` Matthieu Baerts
2021-12-21 7:29 ` Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 07/21] mptcp: netlink: process IPv6 addrs in creating listening sockets Kishen Maloor
2021-12-17 16:29 ` Matthieu Baerts
2021-12-21 7:32 ` Kishen Maloor
2021-12-21 9:45 ` Paolo Abeni
2021-12-22 20:27 ` Kishen Maloor
2021-12-29 13:52 ` Matthieu Baerts
2022-01-05 3:35 ` Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 08/21] mptcp: attempt to add listening sockets for announced addrs Kishen Maloor
2021-12-17 16:34 ` Matthieu Baerts
2021-12-21 7:34 ` Kishen Maloor
2021-12-29 14:03 ` Matthieu Baerts
2022-01-05 3:37 ` Kishen Maloor
2021-12-17 18:04 ` Paolo Abeni
2021-12-18 1:17 ` Mat Martineau
2021-12-21 7:44 ` Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 09/21] mptcp: allow ADD_ADDR reissuance by userspace PMs Kishen Maloor
2021-12-17 18:38 ` Paolo Abeni
2021-12-21 7:33 ` Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 10/21] mptcp: handle local addrs announced " Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 11/21] mptcp: read attributes of addr entries managed " Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 12/21] mptcp: netlink: split mptcp_pm_parse_addr into two functions Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 13/21] mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE Kishen Maloor
2021-12-17 18:39 ` Paolo Abeni
2021-12-16 22:23 ` [PATCH mptcp-next 14/21] mptcp: selftests: support MPTCP_PM_CMD_ANNOUNCE Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 15/21] mptcp: netlink: Add MPTCP_PM_CMD_REMOVE Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 16/21] mptcp: selftests: support MPTCP_PM_CMD_REMOVE Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 17/21] mptcp: netlink: allow userspace-driven subflow establishment Kishen Maloor
2021-12-17 2:52 ` kernel test robot [this message]
2021-12-17 2:52 ` kernel test robot
2021-12-17 5:46 ` kernel test robot
2021-12-17 5:46 ` kernel test robot
2021-12-16 22:23 ` [PATCH mptcp-next 18/21] mptcp: selftests: support MPTCP_PM_CMD_SUBFLOW_CREATE Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 19/21] mptcp: selftests: support MPTCP_PM_CMD_SUBFLOW_DESTROY Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 20/21] mptcp: selftests: capture netlink events Kishen Maloor
2021-12-16 22:23 ` [PATCH mptcp-next 21/21] selftests: mptcp: functional tests for the userspace PM type Kishen Maloor
2021-12-16 22:44 ` selftests: mptcp: functional tests for the userspace PM type: Build Failure MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112171003.GmuMEIxi-lkp@intel.com \
--to=lkp@intel.com \
--cc=fw@strlen.de \
--cc=kbuild-all@lists.01.org \
--cc=kishen.maloor@intel.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.