All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency
@ 2021-12-18 23:10 Fabrice Fontaine
  2021-12-18 23:10 ` [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9 Fabrice Fontaine
  2021-12-19  8:31 ` [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Yann E. MORIN
  0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2021-12-18 23:10 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS dependency was wrongly added to
BR2_PACKAGE_HOST_IMAGEMAGICK by commit
df20e4546384d1c249a6a0541183590671e83d77, indeed host-librsvg is only
needed by BR2_PACKAGE_HOST_IMAGEMAGICK_SVG

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/imagemagick/Config.in.host | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
index e12d82939a..671b0995dc 100644
--- a/package/imagemagick/Config.in.host
+++ b/package/imagemagick/Config.in.host
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_HOST_IMAGEMAGICK
 	bool "host imagemagick"
-	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
 	help
 	  ImageMagick(R) is a software suite to create, edit, and
 	  compose bitmap images. It can read, convert and write images
@@ -17,6 +16,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
 
 config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	bool "SVG support"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
 	help
 	  Say 'y' here is you need ImageMagick tools (like convert)
 	  to support SVG.
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9
  2021-12-18 23:10 [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Fabrice Fontaine
@ 2021-12-18 23:10 ` Fabrice Fontaine
  2021-12-19  9:04   ` Yann E. MORIN
  2021-12-19  8:31 ` [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Yann E. MORIN
  1 sibling, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2021-12-18 23:10 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

host gcc >= 4.9 is needed since bump of harfbuzz to version 3.1.2 in
commit 6861933d22006fbe8c961a41506beac826881f33 to avoid the following
build failure:

In file included from ../src/hb-serialize.hh:36:0,
                 from ../src/hb-machinery.hh:37,
                 from ../src/hb-common.cc:30:
../src/hb-map.hh:67:18: error: 'is_trivially_copyable' is not a member of 'std'
   static_assert (std::is_trivially_copyable<K>::value, "");
                  ^

Fixes:
 - http://autobuild.buildroot.org/results/89e1194c1659d7e1af9db8ffe5feee770c448f76

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/imagemagick/Config.in.host | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
index 671b0995dc..fe0ad9a748 100644
--- a/package/imagemagick/Config.in.host
+++ b/package/imagemagick/Config.in.host
@@ -17,6 +17,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
 config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	bool "SVG support"
 	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
+	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-pango -> host-harfbuzz
 	help
 	  Say 'y' here is you need ImageMagick tools (like convert)
 	  to support SVG.
@@ -24,4 +25,7 @@ config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	  This is not enabled by default, as it brings quite a few
 	  extra dependencies, and thus extra build time.
 
+comment "SVG support needs a toolchain w/ host gcc >= 4.9"
+	depends on !BR2_HOST_GCC_AT_LEAST_4_9
+
 endif
-- 
2.33.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency
  2021-12-18 23:10 [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Fabrice Fontaine
  2021-12-18 23:10 ` [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9 Fabrice Fontaine
@ 2021-12-19  8:31 ` Yann E. MORIN
  1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-12-19  8:31 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

Fabrice, All,

On 2021-12-19 00:10 +0100, Fabrice Fontaine spake thusly:
> BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS dependency was wrongly added to
> BR2_PACKAGE_HOST_IMAGEMAGICK by commit
> df20e4546384d1c249a6a0541183590671e83d77, indeed host-librsvg is only
> needed by BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/imagemagick/Config.in.host | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
> index e12d82939a..671b0995dc 100644
> --- a/package/imagemagick/Config.in.host
> +++ b/package/imagemagick/Config.in.host
> @@ -1,6 +1,5 @@
>  config BR2_PACKAGE_HOST_IMAGEMAGICK
>  	bool "host imagemagick"
> -	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
>  	help
>  	  ImageMagick(R) is a software suite to create, edit, and
>  	  compose bitmap images. It can read, convert and write images
> @@ -17,6 +16,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
>  
>  config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
>  	bool "SVG support"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
>  	help
>  	  Say 'y' here is you need ImageMagick tools (like convert)
>  	  to support SVG.
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9
  2021-12-18 23:10 ` [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9 Fabrice Fontaine
@ 2021-12-19  9:04   ` Yann E. MORIN
  0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-12-19  9:04 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Giulio Benetti, buildroot

Fabrice, All,

On 2021-12-19 00:10 +0100, Fabrice Fontaine spake thusly:
> host gcc >= 4.9 is needed since bump of harfbuzz to version 3.1.2 in
> commit 6861933d22006fbe8c961a41506beac826881f33 to avoid the following
> build failure:
> 
> In file included from ../src/hb-serialize.hh:36:0,
>                  from ../src/hb-machinery.hh:37,
>                  from ../src/hb-common.cc:30:
> ../src/hb-map.hh:67:18: error: 'is_trivially_copyable' is not a member of 'std'
>    static_assert (std::is_trivially_copyable<K>::value, "");
>                   ^

Where did you see that gcc 4.9 had it? I looked at the gcc-4_9_0-release
tag in the gcc tree, and it states:

    $ git grep is_trivially_copyable
    [...]
    libstdc++-v3/include/std/type_traits:  // is_trivially_copyable (still unimplemented)

Whereas gcc 5 has a proper implementation:

    $ git grep -A1 'is_trivially_copyable' libstdc++-v3/include/std/type_traits
    libstdc++-v3/include/std/type_traits:  // is_trivially_copyable
    libstdc++-v3/include/std/type_traits-  template<typename _Tp>
    libstdc++-v3/include/std/type_traits:    struct is_trivially_copyable
    libstdc++-v3/include/std/type_traits:    : public integral_constant<bool, __is_trivially_copyable(_Tp)>
    libstdc++-v3/include/std/type_traits-    { };

I see that 6861933d2200 (package/harfbuzz: bump to version 3.1.2) stated
that the requirement on the gcc version was bumped to 4.9 from 4.8, but
I am not sure how that can be...

Giulio, where did you get the info that gcc 4.9 was required (and not a
higher version)?

Regards,
Yann E. MORIN.

> Fixes:
>  - http://autobuild.buildroot.org/results/89e1194c1659d7e1af9db8ffe5feee770c448f76
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/imagemagick/Config.in.host | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
> index 671b0995dc..fe0ad9a748 100644
> --- a/package/imagemagick/Config.in.host
> +++ b/package/imagemagick/Config.in.host
> @@ -17,6 +17,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
>  config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
>  	bool "SVG support"
>  	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
> +	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-pango -> host-harfbuzz
>  	help
>  	  Say 'y' here is you need ImageMagick tools (like convert)
>  	  to support SVG.
> @@ -24,4 +25,7 @@ config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
>  	  This is not enabled by default, as it brings quite a few
>  	  extra dependencies, and thus extra build time.
>  
> +comment "SVG support needs a toolchain w/ host gcc >= 4.9"
> +	depends on !BR2_HOST_GCC_AT_LEAST_4_9
> +
>  endif
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-19  9:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-18 23:10 [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Fabrice Fontaine
2021-12-18 23:10 ` [Buildroot] [PATCH 178/178] package/imagemagick: host SVG support needs host gcc >= 4.9 Fabrice Fontaine
2021-12-19  9:04   ` Yann E. MORIN
2021-12-19  8:31 ` [Buildroot] [PATCH 1/2] package/imagemagick: fix dependency Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.