Re: [RFC v5 net-next 01/13] mfd: ocelot: add support for external mfd control over SPI for the VSC7512

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3718 bytes --]

Hi Colin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on next-20211217]
[also build test WARNING on v5.16-rc5]
[cannot apply to net-next/master lee-mfd/for-mfd-next linusw-pinctrl/devel net/master horms-ipvs/master linus/master v5.16-rc5 v5.16-rc4 v5.16-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Colin-Foster/add-support-for-VSC75XX-control-over-SPI/20211219-055252
base:    c122052c3cb861b3e61a01d2c2ab9069e470663e
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20211219/202112190908.GDAHmtPe-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ec7f2a8290ac0b1f74a64884f16444c56edb274f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Colin-Foster/add-support-for-VSC75XX-control-over-SPI/20211219-055252
        git checkout ec7f2a8290ac0b1f74a64884f16444c56edb274f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/mfd/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/mfd/ocelot-spi.c: In function 'ocelot_spi_reg_read':
>> drivers/mfd/ocelot-spi.c:124:28: warning: variable 'ocelot_spi' set but not used [-Wunused-but-set-variable]
     124 |         struct ocelot_spi *ocelot_spi;
         |                            ^~~~~~~~~~


vim +/ocelot_spi +124 drivers/mfd/ocelot-spi.c

   118	
   119	static int ocelot_spi_reg_read(void *context, unsigned int reg,
   120				       unsigned int *val)
   121	{
   122		struct ocelot_spi_regmap_context *regmap_context = context;
   123		struct spi_transfer tx, padding, rx;
 > 124		struct ocelot_spi *ocelot_spi;
   125		struct spi_message msg;
   126		struct spi_device *spi;
   127		unsigned int addr;
   128		u8 *tx_buf;
   129	
   130		WARN_ON(!val);
   131	
   132		spi = regmap_context->spi;
   133	
   134		ocelot_spi = spi_get_drvdata(spi);
   135	
   136		addr = ocelot_spi_translate_address(reg + regmap_context->base);
   137		tx_buf = (u8 *)&addr;
   138	
   139		spi_message_init(&msg);
   140	
   141		memset(&tx, 0, sizeof(struct spi_transfer));
   142	
   143		/* Ignore the first byte for the 24-bit address */
   144		tx.tx_buf = &tx_buf[1];
   145		tx.len = 3;
   146	
   147		spi_message_add_tail(&tx, &msg);
   148	
   149		if (regmap_context->padding_bytes > 0) {
   150			u8 dummy_buf[16] = {0};
   151	
   152			memset(&padding, 0, sizeof(struct spi_transfer));
   153	
   154			/* Just toggle the clock for padding bytes */
   155			padding.len = regmap_context->padding_bytes;
   156			padding.tx_buf = dummy_buf;
   157			padding.dummy_data = 1;
   158	
   159			spi_message_add_tail(&padding, &msg);
   160		}
   161	
   162		memset(&rx, 0, sizeof(struct spi_transfer));
   163		rx.rx_buf = val;
   164		rx.len = 4;
   165	
   166		spi_message_add_tail(&rx, &msg);
   167	
   168		return spi_sync(spi, &msg);
   169	}
   170	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org