* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-20 2:23 kernel test robot
0 siblings, 0 replies; 15+ messages in thread
From: kernel test robot @ 2021-12-20 2:23 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5546 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20211217221232.3664417-1-robh@kernel.org>
References: <20211217221232.3664417-1-robh@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: soc(a)kernel.org
TO: Nicolas Ferre <nicolas.ferre@microchip.com>
TO: Alexandre Belloni <alexandre.belloni@bootlin.com>
TO: Ludovic Desroches <ludovic.desroches@microchip.com>
TO: Shawn Guo <shawnguo@kernel.org>
TO: Sascha Hauer <s.hauer@pengutronix.de>
TO: Pengutronix Kernel Team <kernel@pengutronix.de>
TO: Fabio Estevam <festevam@gmail.com>
TO: NXP Linux Team <linux-imx@nxp.com>
TO: "Benoît Cousson" <bcousson@baylibre.com>
Hi Rob,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v5.16-rc5 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Rob-Herring/ARM-dts-Remove-spidev-nodes/20211218-061453
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce: make ARCH=arm dtbs_check
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/clock-controller(a)28000000: failed to match any schema with compatible: ['qcom,lcc-mdm9615']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml: clock-controller(a)2011000: compatible: 'anyOf' conditional failed, one must be fixed:
['syscon'] is too short
'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'brcm,cru-clkset', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'rockchip,px30-qos', 'rockchip,rk3036-qos', 'rockchip,rk3066-qos', 'rockchip,rk3228-qos', 'rockchip,rk3288-qos', 'rockchip,rk3368-qos', 'rockchip,rk3399-qos', 'rockchip,rk3568-qos', 'samsung,exynos3-sysreg', 'samsung,exynos4-sysreg', 'samsung,exynos5-sysreg', 'samsung,exynos5433-sysreg', 'samsung,exynosautov9-sysreg']
From schema: Documentation/devicetree/bindings/mfd/syscon.yaml
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/rng(a)1a500000: failed to match any schema with compatible: ['qcom,prng']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16100000: failed to match any schema with compatible: ['qcom,gsbi-v1.0.0']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16100000/i2c(a)16180000: failed to match any schema with compatible: ['qcom,i2c-qup-v1.1.1']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16200000: failed to match any schema with compatible: ['qcom,gsbi-v1.0.0']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16200000/spi(a)16280000: failed to match any schema with compatible: ['qcom,spi-qup-v1.1.1']
>> arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16200000/spi(a)16280000/spi(a)0: failed to match any schema with compatible: ['swir,mangoh-iotport-spi']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16300000: failed to match any schema with compatible: ['qcom,gsbi-v1.0.0']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16300000/serial(a)16340000: failed to match any schema with compatible: ['qcom,msm-uartdm-v1.3', 'qcom,msm-uartdm']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16300000/serial(a)16340000: failed to match any schema with compatible: ['qcom,msm-uartdm-v1.3', 'qcom,msm-uartdm']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000: failed to match any schema with compatible: ['qcom,gsbi-v1.0.0']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/i2c(a)16480000: failed to match any schema with compatible: ['qcom,i2c-qup-v1.1.1']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/i2c(a)16480000/mux(a)71/i2c(a)4/gpio(a)3e: failed to match any schema with compatible: ['semtech,sx1509q']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/i2c(a)16480000/mux(a)71/i2c(a)5/gpio(a)3f: failed to match any schema with compatible: ['semtech,sx1509q']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/i2c(a)16480000/mux(a)71/i2c(a)6/gpio(a)70: failed to match any schema with compatible: ['semtech,sx1509q']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/serial(a)16440000: failed to match any schema with compatible: ['qcom,msm-uartdm-v1.3', 'qcom,msm-uartdm']
arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml:0:0: /soc/gsbi(a)16400000/serial(a)16440000: failed to match any schema with compatible: ['qcom,msm-uartdm-v1.3', 'qcom,msm-uartdm']
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-17 22:12 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-17 22:12 UTC (permalink / raw)
To: soc, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim
Cc: Mark Brown, devicetree, linux-arm-kernel, linux-kernel,
linux-omap, linux-arm-msm
"spidev" is not a real device, but a Linux implementation detail. It has
never been documented either. The kernel has WARNed on the use of it for
over 6 years. Time to remove its usage from the tree.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Arnd, Olof, Can you please apply this directly.
arch/arm/boot/dts/at91-q5xr5.dts | 18 ----------
arch/arm/boot/dts/at91-wb50n.dts | 6 ----
arch/arm/boot/dts/imx28-tx28.dts | 36 -------------------
arch/arm/boot/dts/imx53-tx53.dtsi | 11 ------
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 12 -------
.../boot/dts/imx6ul-imx6ull-opos6uldev.dtsi | 12 -------
arch/arm/boot/dts/imx6ul-prti6g.dts | 6 ----
arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 24 -------------
arch/arm/boot/dts/omap3-tao3530.dtsi | 14 --------
.../dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-
arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
12 files changed, 1 insertion(+), 172 deletions(-)
diff --git a/arch/arm/boot/dts/at91-q5xr5.dts b/arch/arm/boot/dts/at91-q5xr5.dts
index 5827383b181b..47a00062f01f 100644
--- a/arch/arm/boot/dts/at91-q5xr5.dts
+++ b/arch/arm/boot/dts/at91-q5xr5.dts
@@ -147,12 +147,6 @@ uboot@8000 {
reg = <0x8000 0x3E000>;
};
};
-
- spidev@1 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <1>;
- };
};
&spi1 {
@@ -160,18 +154,6 @@ &spi1 {
pinctrl-0 = <&pinctrl_spi1 &pinctrl_spi1_npcs0 &pinctrl_spi1_npcs1>;
cs-gpios = <&pioB 3 GPIO_ACTIVE_HIGH>, <&pioC 5 GPIO_ACTIVE_LOW>, <0>, <0>;
status = "okay";
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <0>;
- };
-
- spidev@1 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <1>;
- };
};
&usart0 {
diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
index a5e45bb95c04..89f0f717f7ed 100644
--- a/arch/arm/boot/dts/at91-wb50n.dts
+++ b/arch/arm/boot/dts/at91-wb50n.dts
@@ -90,12 +90,6 @@ &i2c0 {
&spi1 {
status = "okay";
-
- spidev@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <8000000>;
- };
};
&usb0 {
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 164254c28f8e..9e5651c7ea6b 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -239,24 +239,6 @@ &gpio3 9 GPIO_ACTIVE_LOW
>;
/* enable this and disable ssp3 below, if you need full duplex SPI transfer */
status = "disabled";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <57600000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <57600000>;
- };
-
- spi@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <57600000>;
- };
};
};
@@ -700,24 +682,6 @@ &ssp3 {
pinctrl-0 = <&spi3_pins_a>;
clock-frequency = <57600000>;
status = "okay";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <57600000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <57600000>;
- };
-
- spi@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <57600000>;
- };
};
&usb0 {
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 7c9730f3f820..81c2726a328a 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -192,17 +192,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
&gpio3 19 GPIO_ACTIVE_HIGH
>;
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <54000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <54000000>;
- };
};
&esdhc1 {
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index 362e65ccaa78..bcc5bbcce769 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
@@ -259,18 +259,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
&gpio3 19 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <54000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <54000000>;
- };
};
&fec {
diff --git a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
index 935a77d717a6..18cac19aa9b0 100644
--- a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
+++ b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
@@ -114,18 +114,6 @@ &ecspi4 {
pinctrl-0 = <&pinctrl_ecspi4>;
cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>, <&gpio4 3 GPIO_ACTIVE_LOW>;
status = "okay";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <5000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <5000000>;
- };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts
index d62015701d0a..c18390f238e1 100644
--- a/arch/arm/boot/dts/imx6ul-prti6g.dts
+++ b/arch/arm/boot/dts/imx6ul-prti6g.dts
@@ -78,12 +78,6 @@ &ecspi2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi2>;
status = "okay";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <1000000>;
- };
};
&fec1 {
diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
index 938a32ced88d..c485d058e079 100644
--- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
@@ -227,18 +227,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
&gpio1 10 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <660000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <660000>;
- };
};
sound {
@@ -290,18 +278,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
&gpio1 10 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <60000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <60000000>;
- };
};
&fec1 {
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index 580bfa1931c8..7f440d11f7e7 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -197,25 +197,11 @@ &i2c3 {
&mcspi1 {
pinctrl-names = "default";
pinctrl-0 = <&mcspi1_pins>;
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <48000000>;
- reg = <0>;
- spi-cpha;
- };
};
&mcspi3 {
pinctrl-names = "default";
pinctrl-0 = <&mcspi3_pins>;
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <48000000>;
- reg = <0>;
- spi-cpha;
- };
};
#include "twl4030.dtsi"
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index 942e3a2cac35..0827de5426c1 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -103,7 +103,7 @@ pins {
&gsbi3_spi {
spi@0 {
- compatible = "swir,mangoh-iotport-spi", "spidev";
+ compatible = "swir,mangoh-iotport-spi";
spi-max-frequency = <24000000>;
reg = <0>;
};
diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
index 8fcb6be6e7c7..4cbadcb41084 100644
--- a/arch/arm/boot/dts/spear1310-evb.dts
+++ b/arch/arm/boot/dts/spear1310-evb.dts
@@ -395,22 +395,6 @@ m25p80@1 {
pl022,wait-state = <0>;
pl022,duplex = <0>;
};
-
- spidev@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <25000000>;
- spi-cpha;
- pl022,hierarchy = <0>;
- pl022,interface = <0>;
- pl022,slave-tx-disable;
- pl022,com-mode = <0x2>;
- pl022,rx-level-trig = <0>;
- pl022,tx-level-trig = <0>;
- pl022,ctrl-len = <0x11>;
- pl022,wait-state = <0>;
- pl022,duplex = <0>;
- };
};
wdt@ec800620 {
diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
index f70ff56d4542..fd194ebeedc9 100644
--- a/arch/arm/boot/dts/spear1340-evb.dts
+++ b/arch/arm/boot/dts/spear1340-evb.dts
@@ -489,22 +489,6 @@ stmpe_touchscreen {
ts,i-drive = <1>;
};
};
-
- spidev@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <25000000>;
- spi-cpha;
- pl022,hierarchy = <0>;
- pl022,interface = <0>;
- pl022,slave-tx-disable;
- pl022,com-mode = <0x2>;
- pl022,rx-level-trig = <0>;
- pl022,tx-level-trig = <0>;
- pl022,ctrl-len = <0x11>;
- pl022,wait-state = <0>;
- pl022,duplex = <0>;
- };
};
timer@ec800600 {
--
2.32.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-17 22:12 ` Rob Herring
0 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2021-12-17 22:12 UTC (permalink / raw)
To: soc, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim
Cc: Mark Brown, devicetree, linux-arm-kernel, linux-kernel,
linux-omap, linux-arm-msm
"spidev" is not a real device, but a Linux implementation detail. It has
never been documented either. The kernel has WARNed on the use of it for
over 6 years. Time to remove its usage from the tree.
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Arnd, Olof, Can you please apply this directly.
arch/arm/boot/dts/at91-q5xr5.dts | 18 ----------
arch/arm/boot/dts/at91-wb50n.dts | 6 ----
arch/arm/boot/dts/imx28-tx28.dts | 36 -------------------
arch/arm/boot/dts/imx53-tx53.dtsi | 11 ------
arch/arm/boot/dts/imx6qdl-tx6.dtsi | 12 -------
.../boot/dts/imx6ul-imx6ull-opos6uldev.dtsi | 12 -------
arch/arm/boot/dts/imx6ul-prti6g.dts | 6 ----
arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 24 -------------
arch/arm/boot/dts/omap3-tao3530.dtsi | 14 --------
.../dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-
arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
12 files changed, 1 insertion(+), 172 deletions(-)
diff --git a/arch/arm/boot/dts/at91-q5xr5.dts b/arch/arm/boot/dts/at91-q5xr5.dts
index 5827383b181b..47a00062f01f 100644
--- a/arch/arm/boot/dts/at91-q5xr5.dts
+++ b/arch/arm/boot/dts/at91-q5xr5.dts
@@ -147,12 +147,6 @@ uboot@8000 {
reg = <0x8000 0x3E000>;
};
};
-
- spidev@1 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <1>;
- };
};
&spi1 {
@@ -160,18 +154,6 @@ &spi1 {
pinctrl-0 = <&pinctrl_spi1 &pinctrl_spi1_npcs0 &pinctrl_spi1_npcs1>;
cs-gpios = <&pioB 3 GPIO_ACTIVE_HIGH>, <&pioC 5 GPIO_ACTIVE_LOW>, <0>, <0>;
status = "okay";
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <0>;
- };
-
- spidev@1 {
- compatible = "spidev";
- spi-max-frequency = <2000000>;
- reg = <1>;
- };
};
&usart0 {
diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
index a5e45bb95c04..89f0f717f7ed 100644
--- a/arch/arm/boot/dts/at91-wb50n.dts
+++ b/arch/arm/boot/dts/at91-wb50n.dts
@@ -90,12 +90,6 @@ &i2c0 {
&spi1 {
status = "okay";
-
- spidev@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <8000000>;
- };
};
&usb0 {
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index 164254c28f8e..9e5651c7ea6b 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -239,24 +239,6 @@ &gpio3 9 GPIO_ACTIVE_LOW
>;
/* enable this and disable ssp3 below, if you need full duplex SPI transfer */
status = "disabled";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <57600000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <57600000>;
- };
-
- spi@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <57600000>;
- };
};
};
@@ -700,24 +682,6 @@ &ssp3 {
pinctrl-0 = <&spi3_pins_a>;
clock-frequency = <57600000>;
status = "okay";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <57600000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <57600000>;
- };
-
- spi@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <57600000>;
- };
};
&usb0 {
diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
index 7c9730f3f820..81c2726a328a 100644
--- a/arch/arm/boot/dts/imx53-tx53.dtsi
+++ b/arch/arm/boot/dts/imx53-tx53.dtsi
@@ -192,17 +192,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
&gpio3 19 GPIO_ACTIVE_HIGH
>;
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <54000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <54000000>;
- };
};
&esdhc1 {
diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
index 362e65ccaa78..bcc5bbcce769 100644
--- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
@@ -259,18 +259,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
&gpio3 19 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <54000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <54000000>;
- };
};
&fec {
diff --git a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
index 935a77d717a6..18cac19aa9b0 100644
--- a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
+++ b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
@@ -114,18 +114,6 @@ &ecspi4 {
pinctrl-0 = <&pinctrl_ecspi4>;
cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>, <&gpio4 3 GPIO_ACTIVE_LOW>;
status = "okay";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <5000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <5000000>;
- };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts
index d62015701d0a..c18390f238e1 100644
--- a/arch/arm/boot/dts/imx6ul-prti6g.dts
+++ b/arch/arm/boot/dts/imx6ul-prti6g.dts
@@ -78,12 +78,6 @@ &ecspi2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi2>;
status = "okay";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <1000000>;
- };
};
&fec1 {
diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
index 938a32ced88d..c485d058e079 100644
--- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
@@ -227,18 +227,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
&gpio1 10 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <660000>;
- };
-
- spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <660000>;
- };
};
sound {
@@ -290,18 +278,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
&gpio1 10 GPIO_ACTIVE_HIGH
>;
status = "disabled";
-
- spidev0: spi@0 {
- compatible = "spidev";
- reg = <0>;
- spi-max-frequency = <60000000>;
- };
-
- spidev1: spi@1 {
- compatible = "spidev";
- reg = <1>;
- spi-max-frequency = <60000000>;
- };
};
&fec1 {
diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
index 580bfa1931c8..7f440d11f7e7 100644
--- a/arch/arm/boot/dts/omap3-tao3530.dtsi
+++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
@@ -197,25 +197,11 @@ &i2c3 {
&mcspi1 {
pinctrl-names = "default";
pinctrl-0 = <&mcspi1_pins>;
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <48000000>;
- reg = <0>;
- spi-cpha;
- };
};
&mcspi3 {
pinctrl-names = "default";
pinctrl-0 = <&mcspi3_pins>;
-
- spidev@0 {
- compatible = "spidev";
- spi-max-frequency = <48000000>;
- reg = <0>;
- spi-cpha;
- };
};
#include "twl4030.dtsi"
diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
index 942e3a2cac35..0827de5426c1 100644
--- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
+++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
@@ -103,7 +103,7 @@ pins {
&gsbi3_spi {
spi@0 {
- compatible = "swir,mangoh-iotport-spi", "spidev";
+ compatible = "swir,mangoh-iotport-spi";
spi-max-frequency = <24000000>;
reg = <0>;
};
diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
index 8fcb6be6e7c7..4cbadcb41084 100644
--- a/arch/arm/boot/dts/spear1310-evb.dts
+++ b/arch/arm/boot/dts/spear1310-evb.dts
@@ -395,22 +395,6 @@ m25p80@1 {
pl022,wait-state = <0>;
pl022,duplex = <0>;
};
-
- spidev@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <25000000>;
- spi-cpha;
- pl022,hierarchy = <0>;
- pl022,interface = <0>;
- pl022,slave-tx-disable;
- pl022,com-mode = <0x2>;
- pl022,rx-level-trig = <0>;
- pl022,tx-level-trig = <0>;
- pl022,ctrl-len = <0x11>;
- pl022,wait-state = <0>;
- pl022,duplex = <0>;
- };
};
wdt@ec800620 {
diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
index f70ff56d4542..fd194ebeedc9 100644
--- a/arch/arm/boot/dts/spear1340-evb.dts
+++ b/arch/arm/boot/dts/spear1340-evb.dts
@@ -489,22 +489,6 @@ stmpe_touchscreen {
ts,i-drive = <1>;
};
};
-
- spidev@2 {
- compatible = "spidev";
- reg = <2>;
- spi-max-frequency = <25000000>;
- spi-cpha;
- pl022,hierarchy = <0>;
- pl022,interface = <0>;
- pl022,slave-tx-disable;
- pl022,com-mode = <0x2>;
- pl022,rx-level-trig = <0>;
- pl022,tx-level-trig = <0>;
- pl022,ctrl-len = <0x11>;
- pl022,wait-state = <0>;
- pl022,duplex = <0>;
- };
};
timer@ec800600 {
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-17 22:12 ` Rob Herring
@ 2021-12-18 15:53 ` Nicolas Ferre
-1 siblings, 0 replies; 15+ messages in thread
From: Nicolas Ferre @ 2021-12-18 15:53 UTC (permalink / raw)
To: Rob Herring, soc, Alexandre Belloni, Ludovic Desroches, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim
Cc: Mark Brown, devicetree, linux-arm-kernel, linux-kernel,
linux-omap, linux-arm-msm
On 17/12/2021 at 23:12, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Olof, Can you please apply this directly.
>
> arch/arm/boot/dts/at91-q5xr5.dts | 18 ----------
> arch/arm/boot/dts/at91-wb50n.dts | 6 ----
For at91:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Sorry for having re-introduced this use recently.
Best regards,
Nicolas
> arch/arm/boot/dts/imx28-tx28.dts | 36 -------------------
> arch/arm/boot/dts/imx53-tx53.dtsi | 11 ------
> arch/arm/boot/dts/imx6qdl-tx6.dtsi | 12 -------
> .../boot/dts/imx6ul-imx6ull-opos6uldev.dtsi | 12 -------
> arch/arm/boot/dts/imx6ul-prti6g.dts | 6 ----
> arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 24 -------------
> arch/arm/boot/dts/omap3-tao3530.dtsi | 14 --------
> .../dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-
> arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
> arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
> 12 files changed, 1 insertion(+), 172 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-q5xr5.dts b/arch/arm/boot/dts/at91-q5xr5.dts
> index 5827383b181b..47a00062f01f 100644
> --- a/arch/arm/boot/dts/at91-q5xr5.dts
> +++ b/arch/arm/boot/dts/at91-q5xr5.dts
> @@ -147,12 +147,6 @@ uboot@8000 {
> reg = <0x8000 0x3E000>;
> };
> };
> -
> - spidev@1 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <1>;
> - };
> };
>
> &spi1 {
> @@ -160,18 +154,6 @@ &spi1 {
> pinctrl-0 = <&pinctrl_spi1 &pinctrl_spi1_npcs0 &pinctrl_spi1_npcs1>;
> cs-gpios = <&pioB 3 GPIO_ACTIVE_HIGH>, <&pioC 5 GPIO_ACTIVE_LOW>, <0>, <0>;
> status = "okay";
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <0>;
> - };
> -
> - spidev@1 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <1>;
> - };
> };
>
> &usart0 {
> diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
> index a5e45bb95c04..89f0f717f7ed 100644
> --- a/arch/arm/boot/dts/at91-wb50n.dts
> +++ b/arch/arm/boot/dts/at91-wb50n.dts
> @@ -90,12 +90,6 @@ &i2c0 {
>
> &spi1 {
> status = "okay";
> -
> - spidev@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <8000000>;
> - };
> };
>
> &usb0 {
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 164254c28f8e..9e5651c7ea6b 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -239,24 +239,6 @@ &gpio3 9 GPIO_ACTIVE_LOW
> >;
> /* enable this and disable ssp3 below, if you need full duplex SPI transfer */
> status = "disabled";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <57600000>;
> - };
> };
> };
>
> @@ -700,24 +682,6 @@ &ssp3 {
> pinctrl-0 = <&spi3_pins_a>;
> clock-frequency = <57600000>;
> status = "okay";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <57600000>;
> - };
> };
>
> &usb0 {
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 7c9730f3f820..81c2726a328a 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -192,17 +192,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
> &gpio3 19 GPIO_ACTIVE_HIGH
> >;
>
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <54000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <54000000>;
> - };
> };
>
> &esdhc1 {
> diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> index 362e65ccaa78..bcc5bbcce769 100644
> --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> @@ -259,18 +259,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
> &gpio3 19 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <54000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <54000000>;
> - };
> };
>
> &fec {
> diff --git a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> index 935a77d717a6..18cac19aa9b0 100644
> --- a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> @@ -114,18 +114,6 @@ &ecspi4 {
> pinctrl-0 = <&pinctrl_ecspi4>;
> cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>, <&gpio4 3 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <5000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <5000000>;
> - };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts
> index d62015701d0a..c18390f238e1 100644
> --- a/arch/arm/boot/dts/imx6ul-prti6g.dts
> +++ b/arch/arm/boot/dts/imx6ul-prti6g.dts
> @@ -78,12 +78,6 @@ &ecspi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> status = "okay";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <1000000>;
> - };
> };
>
> &fec1 {
> diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> index 938a32ced88d..c485d058e079 100644
> --- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> @@ -227,18 +227,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
> &gpio1 10 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <660000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <660000>;
> - };
> };
>
> sound {
> @@ -290,18 +278,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
> &gpio1 10 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <60000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <60000000>;
> - };
> };
>
> &fec1 {
> diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
> index 580bfa1931c8..7f440d11f7e7 100644
> --- a/arch/arm/boot/dts/omap3-tao3530.dtsi
> +++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
> @@ -197,25 +197,11 @@ &i2c3 {
> &mcspi1 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcspi1_pins>;
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <48000000>;
> - reg = <0>;
> - spi-cpha;
> - };
> };
>
> &mcspi3 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcspi3_pins>;
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <48000000>;
> - reg = <0>;
> - spi-cpha;
> - };
> };
>
> #include "twl4030.dtsi"
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> index 942e3a2cac35..0827de5426c1 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> @@ -103,7 +103,7 @@ pins {
>
> &gsbi3_spi {
> spi@0 {
> - compatible = "swir,mangoh-iotport-spi", "spidev";
> + compatible = "swir,mangoh-iotport-spi";
> spi-max-frequency = <24000000>;
> reg = <0>;
> };
> diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
> index 8fcb6be6e7c7..4cbadcb41084 100644
> --- a/arch/arm/boot/dts/spear1310-evb.dts
> +++ b/arch/arm/boot/dts/spear1310-evb.dts
> @@ -395,22 +395,6 @@ m25p80@1 {
> pl022,wait-state = <0>;
> pl022,duplex = <0>;
> };
> -
> - spidev@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <25000000>;
> - spi-cpha;
> - pl022,hierarchy = <0>;
> - pl022,interface = <0>;
> - pl022,slave-tx-disable;
> - pl022,com-mode = <0x2>;
> - pl022,rx-level-trig = <0>;
> - pl022,tx-level-trig = <0>;
> - pl022,ctrl-len = <0x11>;
> - pl022,wait-state = <0>;
> - pl022,duplex = <0>;
> - };
> };
>
> wdt@ec800620 {
> diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
> index f70ff56d4542..fd194ebeedc9 100644
> --- a/arch/arm/boot/dts/spear1340-evb.dts
> +++ b/arch/arm/boot/dts/spear1340-evb.dts
> @@ -489,22 +489,6 @@ stmpe_touchscreen {
> ts,i-drive = <1>;
> };
> };
> -
> - spidev@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <25000000>;
> - spi-cpha;
> - pl022,hierarchy = <0>;
> - pl022,interface = <0>;
> - pl022,slave-tx-disable;
> - pl022,com-mode = <0x2>;
> - pl022,rx-level-trig = <0>;
> - pl022,tx-level-trig = <0>;
> - pl022,ctrl-len = <0x11>;
> - pl022,wait-state = <0>;
> - pl022,duplex = <0>;
> - };
> };
>
> timer@ec800600 {
> --
> 2.32.0
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-18 15:53 ` Nicolas Ferre
0 siblings, 0 replies; 15+ messages in thread
From: Nicolas Ferre @ 2021-12-18 15:53 UTC (permalink / raw)
To: Rob Herring, soc, Alexandre Belloni, Ludovic Desroches, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim
Cc: Mark Brown, devicetree, linux-arm-kernel, linux-kernel,
linux-omap, linux-arm-msm
On 17/12/2021 at 23:12, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Olof, Can you please apply this directly.
>
> arch/arm/boot/dts/at91-q5xr5.dts | 18 ----------
> arch/arm/boot/dts/at91-wb50n.dts | 6 ----
For at91:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Sorry for having re-introduced this use recently.
Best regards,
Nicolas
> arch/arm/boot/dts/imx28-tx28.dts | 36 -------------------
> arch/arm/boot/dts/imx53-tx53.dtsi | 11 ------
> arch/arm/boot/dts/imx6qdl-tx6.dtsi | 12 -------
> .../boot/dts/imx6ul-imx6ull-opos6uldev.dtsi | 12 -------
> arch/arm/boot/dts/imx6ul-prti6g.dts | 6 ----
> arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 24 -------------
> arch/arm/boot/dts/omap3-tao3530.dtsi | 14 --------
> .../dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +-
> arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
> arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
> 12 files changed, 1 insertion(+), 172 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-q5xr5.dts b/arch/arm/boot/dts/at91-q5xr5.dts
> index 5827383b181b..47a00062f01f 100644
> --- a/arch/arm/boot/dts/at91-q5xr5.dts
> +++ b/arch/arm/boot/dts/at91-q5xr5.dts
> @@ -147,12 +147,6 @@ uboot@8000 {
> reg = <0x8000 0x3E000>;
> };
> };
> -
> - spidev@1 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <1>;
> - };
> };
>
> &spi1 {
> @@ -160,18 +154,6 @@ &spi1 {
> pinctrl-0 = <&pinctrl_spi1 &pinctrl_spi1_npcs0 &pinctrl_spi1_npcs1>;
> cs-gpios = <&pioB 3 GPIO_ACTIVE_HIGH>, <&pioC 5 GPIO_ACTIVE_LOW>, <0>, <0>;
> status = "okay";
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <0>;
> - };
> -
> - spidev@1 {
> - compatible = "spidev";
> - spi-max-frequency = <2000000>;
> - reg = <1>;
> - };
> };
>
> &usart0 {
> diff --git a/arch/arm/boot/dts/at91-wb50n.dts b/arch/arm/boot/dts/at91-wb50n.dts
> index a5e45bb95c04..89f0f717f7ed 100644
> --- a/arch/arm/boot/dts/at91-wb50n.dts
> +++ b/arch/arm/boot/dts/at91-wb50n.dts
> @@ -90,12 +90,6 @@ &i2c0 {
>
> &spi1 {
> status = "okay";
> -
> - spidev@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <8000000>;
> - };
> };
>
> &usb0 {
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index 164254c28f8e..9e5651c7ea6b 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -239,24 +239,6 @@ &gpio3 9 GPIO_ACTIVE_LOW
> >;
> /* enable this and disable ssp3 below, if you need full duplex SPI transfer */
> status = "disabled";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <57600000>;
> - };
> };
> };
>
> @@ -700,24 +682,6 @@ &ssp3 {
> pinctrl-0 = <&spi3_pins_a>;
> clock-frequency = <57600000>;
> status = "okay";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <57600000>;
> - };
> -
> - spi@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <57600000>;
> - };
> };
>
> &usb0 {
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index 7c9730f3f820..81c2726a328a 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -192,17 +192,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
> &gpio3 19 GPIO_ACTIVE_HIGH
> >;
>
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <54000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <54000000>;
> - };
> };
>
> &esdhc1 {
> diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> index 362e65ccaa78..bcc5bbcce769 100644
> --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> @@ -259,18 +259,6 @@ &gpio2 30 GPIO_ACTIVE_HIGH
> &gpio3 19 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <54000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <54000000>;
> - };
> };
>
> &fec {
> diff --git a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> index 935a77d717a6..18cac19aa9b0 100644
> --- a/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi
> @@ -114,18 +114,6 @@ &ecspi4 {
> pinctrl-0 = <&pinctrl_ecspi4>;
> cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>, <&gpio4 3 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <5000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <5000000>;
> - };
> };
>
> &i2c1 {
> diff --git a/arch/arm/boot/dts/imx6ul-prti6g.dts b/arch/arm/boot/dts/imx6ul-prti6g.dts
> index d62015701d0a..c18390f238e1 100644
> --- a/arch/arm/boot/dts/imx6ul-prti6g.dts
> +++ b/arch/arm/boot/dts/imx6ul-prti6g.dts
> @@ -78,12 +78,6 @@ &ecspi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> status = "okay";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <1000000>;
> - };
> };
>
> &fec1 {
> diff --git a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> index 938a32ced88d..c485d058e079 100644
> --- a/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-tx6ul.dtsi
> @@ -227,18 +227,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
> &gpio1 10 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <660000>;
> - };
> -
> - spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <660000>;
> - };
> };
>
> sound {
> @@ -290,18 +278,6 @@ &gpio1 29 GPIO_ACTIVE_HIGH
> &gpio1 10 GPIO_ACTIVE_HIGH
> >;
> status = "disabled";
> -
> - spidev0: spi@0 {
> - compatible = "spidev";
> - reg = <0>;
> - spi-max-frequency = <60000000>;
> - };
> -
> - spidev1: spi@1 {
> - compatible = "spidev";
> - reg = <1>;
> - spi-max-frequency = <60000000>;
> - };
> };
>
> &fec1 {
> diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi
> index 580bfa1931c8..7f440d11f7e7 100644
> --- a/arch/arm/boot/dts/omap3-tao3530.dtsi
> +++ b/arch/arm/boot/dts/omap3-tao3530.dtsi
> @@ -197,25 +197,11 @@ &i2c3 {
> &mcspi1 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcspi1_pins>;
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <48000000>;
> - reg = <0>;
> - spi-cpha;
> - };
> };
>
> &mcspi3 {
> pinctrl-names = "default";
> pinctrl-0 = <&mcspi3_pins>;
> -
> - spidev@0 {
> - compatible = "spidev";
> - spi-max-frequency = <48000000>;
> - reg = <0>;
> - spi-cpha;
> - };
> };
>
> #include "twl4030.dtsi"
> diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> index 942e3a2cac35..0827de5426c1 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts
> @@ -103,7 +103,7 @@ pins {
>
> &gsbi3_spi {
> spi@0 {
> - compatible = "swir,mangoh-iotport-spi", "spidev";
> + compatible = "swir,mangoh-iotport-spi";
> spi-max-frequency = <24000000>;
> reg = <0>;
> };
> diff --git a/arch/arm/boot/dts/spear1310-evb.dts b/arch/arm/boot/dts/spear1310-evb.dts
> index 8fcb6be6e7c7..4cbadcb41084 100644
> --- a/arch/arm/boot/dts/spear1310-evb.dts
> +++ b/arch/arm/boot/dts/spear1310-evb.dts
> @@ -395,22 +395,6 @@ m25p80@1 {
> pl022,wait-state = <0>;
> pl022,duplex = <0>;
> };
> -
> - spidev@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <25000000>;
> - spi-cpha;
> - pl022,hierarchy = <0>;
> - pl022,interface = <0>;
> - pl022,slave-tx-disable;
> - pl022,com-mode = <0x2>;
> - pl022,rx-level-trig = <0>;
> - pl022,tx-level-trig = <0>;
> - pl022,ctrl-len = <0x11>;
> - pl022,wait-state = <0>;
> - pl022,duplex = <0>;
> - };
> };
>
> wdt@ec800620 {
> diff --git a/arch/arm/boot/dts/spear1340-evb.dts b/arch/arm/boot/dts/spear1340-evb.dts
> index f70ff56d4542..fd194ebeedc9 100644
> --- a/arch/arm/boot/dts/spear1340-evb.dts
> +++ b/arch/arm/boot/dts/spear1340-evb.dts
> @@ -489,22 +489,6 @@ stmpe_touchscreen {
> ts,i-drive = <1>;
> };
> };
> -
> - spidev@2 {
> - compatible = "spidev";
> - reg = <2>;
> - spi-max-frequency = <25000000>;
> - spi-cpha;
> - pl022,hierarchy = <0>;
> - pl022,interface = <0>;
> - pl022,slave-tx-disable;
> - pl022,com-mode = <0x2>;
> - pl022,rx-level-trig = <0>;
> - pl022,tx-level-trig = <0>;
> - pl022,ctrl-len = <0x11>;
> - pl022,wait-state = <0>;
> - pl022,duplex = <0>;
> - };
> };
>
> timer@ec800600 {
> --
> 2.32.0
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-17 22:12 ` Rob Herring
@ 2021-12-20 4:20 ` Viresh Kumar
-1 siblings, 0 replies; 15+ messages in thread
From: Viresh Kumar @ 2021-12-20 4:20 UTC (permalink / raw)
To: Rob Herring
Cc: soc, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim, Mark Brown,
devicetree, linux-arm-kernel, linux-kernel, linux-omap,
linux-arm-msm
On 17-12-21, 16:12, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Olof, Can you please apply this directly.
>
> arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
> arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-20 4:20 ` Viresh Kumar
0 siblings, 0 replies; 15+ messages in thread
From: Viresh Kumar @ 2021-12-20 4:20 UTC (permalink / raw)
To: Rob Herring
Cc: linux-arm-msm, devicetree, Alexandre Belloni, linux-omap,
linux-kernel, Benoît Cousson, Tony Lindgren, Fabio Estevam,
Sascha Hauer, Ludovic Desroches, soc, Andy Gross, Mark Brown,
NXP Linux Team, Pengutronix Kernel Team, Viresh Kumar,
Bjorn Andersson, Shawn Guo, Shiraz Hashim, linux-arm-kernel
On 17-12-21, 16:12, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Arnd, Olof, Can you please apply this directly.
>
> arch/arm/boot/dts/spear1310-evb.dts | 16 ---------
> arch/arm/boot/dts/spear1340-evb.dts | 16 ---------
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-17 22:12 ` Rob Herring
@ 2021-12-20 12:30 ` Mark Brown
-1 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2021-12-20 12:30 UTC (permalink / raw)
To: Rob Herring
Cc: soc, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim, devicetree,
linux-arm-kernel, linux-kernel, linux-omap, linux-arm-msm
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Fri, Dec 17, 2021 at 04:12:32PM -0600, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-20 12:30 ` Mark Brown
0 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2021-12-20 12:30 UTC (permalink / raw)
To: Rob Herring
Cc: linux-arm-msm, devicetree, Alexandre Belloni, linux-omap,
linux-kernel, Benoît Cousson, Tony Lindgren, Fabio Estevam,
Sascha Hauer, Ludovic Desroches, soc, Andy Gross, NXP Linux Team,
Pengutronix Kernel Team, Viresh Kumar, Bjorn Andersson, Shawn Guo,
Shiraz Hashim, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 312 bytes --]
On Fri, Dec 17, 2021 at 04:12:32PM -0600, Rob Herring wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
Reviwed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-20 12:30 ` Mark Brown
@ 2021-12-20 19:22 ` Alexandre Belloni
-1 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2021-12-20 19:22 UTC (permalink / raw)
To: Mark Brown
Cc: Rob Herring, soc, Nicolas Ferre, Ludovic Desroches, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim, devicetree,
linux-arm-kernel, linux-kernel, linux-omap, linux-arm-msm
Hello Mark,
On 20/12/2021 12:30:30+0000, Mark Brown wrote:
> On Fri, Dec 17, 2021 at 04:12:32PM -0600, Rob Herring wrote:
> > "spidev" is not a real device, but a Linux implementation detail. It has
> > never been documented either. The kernel has WARNed on the use of it for
> > over 6 years. Time to remove its usage from the tree.
>
> Reviwed-by: Mark Brown <broonie@kernel.org>
You have a typo there so I'm not sure b4 will be able to pick that up
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-20 19:22 ` Alexandre Belloni
0 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2021-12-20 19:22 UTC (permalink / raw)
To: Mark Brown
Cc: linux-arm-msm, Rob Herring, linux-omap, linux-kernel,
Benoît Cousson, devicetree, Tony Lindgren, Fabio Estevam,
Sascha Hauer, Ludovic Desroches, soc, Andy Gross, NXP Linux Team,
Pengutronix Kernel Team, Viresh Kumar, Bjorn Andersson, Shawn Guo,
Shiraz Hashim, linux-arm-kernel
Hello Mark,
On 20/12/2021 12:30:30+0000, Mark Brown wrote:
> On Fri, Dec 17, 2021 at 04:12:32PM -0600, Rob Herring wrote:
> > "spidev" is not a real device, but a Linux implementation detail. It has
> > never been documented either. The kernel has WARNed on the use of it for
> > over 6 years. Time to remove its usage from the tree.
>
> Reviwed-by: Mark Brown <broonie@kernel.org>
You have a typo there so I'm not sure b4 will be able to pick that up
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-20 19:22 ` Alexandre Belloni
@ 2021-12-20 20:27 ` Mark Brown
-1 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2021-12-20 20:27 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Rob Herring, soc, Nicolas Ferre, Ludovic Desroches, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Benoît Cousson, Tony Lindgren, Andy Gross,
Bjorn Andersson, Viresh Kumar, Shiraz Hashim, devicetree,
linux-arm-kernel, linux-kernel, linux-omap, linux-arm-msm
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
On Mon, Dec 20, 2021 at 08:22:49PM +0100, Alexandre Belloni wrote:
> On 20/12/2021 12:30:30+0000, Mark Brown wrote:
> > Reviwed-by: Mark Brown <broonie@kernel.org>
> You have a typo there so I'm not sure b4 will be able to pick that up
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
@ 2021-12-20 20:27 ` Mark Brown
0 siblings, 0 replies; 15+ messages in thread
From: Mark Brown @ 2021-12-20 20:27 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-arm-msm, Rob Herring, linux-omap, linux-kernel,
Benoît Cousson, devicetree, Tony Lindgren, Fabio Estevam,
Sascha Hauer, Ludovic Desroches, soc, Andy Gross, NXP Linux Team,
Pengutronix Kernel Team, Viresh Kumar, Bjorn Andersson, Shawn Guo,
Shiraz Hashim, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]
On Mon, Dec 20, 2021 at 08:22:49PM +0100, Alexandre Belloni wrote:
> On 20/12/2021 12:30:30+0000, Mark Brown wrote:
> > Reviwed-by: Mark Brown <broonie@kernel.org>
> You have a typo there so I'm not sure b4 will be able to pick that up
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-17 22:12 ` Rob Herring
` (3 preceding siblings ...)
(?)
@ 2021-12-20 15:40 ` patchwork-bot+linux-soc
-1 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+linux-soc @ 2021-12-20 15:40 UTC (permalink / raw)
To: Rob Herring; +Cc: soc
Hello:
This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Fri, 17 Dec 2021 16:12:32 -0600 you wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
>
> [...]
Here is the summary with links:
- ARM: dts: Remove "spidev" nodes
https://git.kernel.org/soc/soc/c/8a3804c030e4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH] ARM: dts: Remove "spidev" nodes
2021-12-17 22:12 ` Rob Herring
` (4 preceding siblings ...)
(?)
@ 2022-01-26 20:43 ` patchwork-bot+linux-arm-msm
-1 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2022-01-26 20:43 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Fri, 17 Dec 2021 16:12:32 -0600 you wrote:
> "spidev" is not a real device, but a Linux implementation detail. It has
> never been documented either. The kernel has WARNed on the use of it for
> over 6 years. Time to remove its usage from the tree.
>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
>
> [...]
Here is the summary with links:
- ARM: dts: Remove "spidev" nodes
https://git.kernel.org/qcom/c/8a3804c030e4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-01-26 20:44 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-20 2:23 [PATCH] ARM: dts: Remove "spidev" nodes kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-12-17 22:12 Rob Herring
2021-12-17 22:12 ` Rob Herring
2021-12-18 15:53 ` Nicolas Ferre
2021-12-18 15:53 ` Nicolas Ferre
2021-12-20 4:20 ` Viresh Kumar
2021-12-20 4:20 ` Viresh Kumar
2021-12-20 12:30 ` Mark Brown
2021-12-20 12:30 ` Mark Brown
2021-12-20 19:22 ` Alexandre Belloni
2021-12-20 19:22 ` Alexandre Belloni
2021-12-20 20:27 ` Mark Brown
2021-12-20 20:27 ` Mark Brown
2021-12-20 15:40 ` patchwork-bot+linux-soc
2022-01-26 20:43 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.