From: Carel Si <beibei.si@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: "Yin, Fengwei" <fengwei.yin@intel.com>,
Joerg Roedel <jroedel@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"lkp@lists.01.org" <lkp@lists.01.org>, lkp <lkp@intel.com>,
"bfields@fieldses.org" <bfields@fieldses.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV?
Date: Tue, 21 Dec 2021 22:31:54 +0800 [thread overview]
Message-ID: <20211221143153.GA4676@linux.intel.com> (raw)
In-Reply-To: <YbyIJYzqtHPKRMFt@zn.tnic>
Hi Boris,
On Fri, Dec 17, 2021 at 08:52:53PM +0800, Borislav Petkov wrote:
> ---
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 0083464de5e3..79b3d67addcc 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -384,7 +384,7 @@ void native_write_cr0(unsigned long val)
> }
> EXPORT_SYMBOL(native_write_cr0);
>
> -void native_write_cr4(unsigned long val)
> +void __no_profile native_write_cr4(unsigned long val)
> {
> unsigned long bits_changed = 0;
>
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index 75acb6027a87..68d2b7f9a913 100644
> --- a/arch/x86/kernel/head64.c
> +++ b/arch/x86/kernel/head64.c
> @@ -483,7 +483,7 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
> /* Kill off the identity-map trampoline */
> reset_early_page_tables();
>
> - __native_tlb_flush_global(native_read_cr4());
> + __native_tlb_flush_global(this_cpu_read(cpu_tlbstate.cr4));
>
> clear_bss();
>
We tested your patch, it can fix the issue, thanks.
=========================================================================================
compiler/kconfig/rootfs/sleep/tbox_group/testcase:
clang-14/x86_64-randconfig-a013-20211207/debian-10.4-x86_64-20200603.cgz/1/vm-snb/boot
commit:
9de4999050 ("x86/realmode: Add comment for Global bit usage in trampoline_pgd")
f154f29085 ("x86/mm/64: Flush global TLB on boot and AP bringup")
d12ddfe498 ("fixup-for-f154f29085")
9de4999050b5f2e8 f154f290855b070cc94dd44ad25 d12ddfe498329a0967c008d8183
---------------- --------------------------- ---------------------------
fail:runs %reproduction fail:runs %reproduction fail:runs
| | | | |
:27 100% 27:27 0% :27 dmesg.BUG:kernel_reboot-without-warning_in_boot_stage
WARNING: multiple messages have this Message-ID (diff)
From: Carel Si <beibei.si@intel.com>
To: lkp@lists.01.org
Subject: Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV?
Date: Tue, 21 Dec 2021 22:31:54 +0800 [thread overview]
Message-ID: <20211221143153.GA4676@linux.intel.com> (raw)
In-Reply-To: <YbyIJYzqtHPKRMFt@zn.tnic>
[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]
Hi Boris,
On Fri, Dec 17, 2021 at 08:52:53PM +0800, Borislav Petkov wrote:
> ---
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 0083464de5e3..79b3d67addcc 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -384,7 +384,7 @@ void native_write_cr0(unsigned long val)
> }
> EXPORT_SYMBOL(native_write_cr0);
>
> -void native_write_cr4(unsigned long val)
> +void __no_profile native_write_cr4(unsigned long val)
> {
> unsigned long bits_changed = 0;
>
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index 75acb6027a87..68d2b7f9a913 100644
> --- a/arch/x86/kernel/head64.c
> +++ b/arch/x86/kernel/head64.c
> @@ -483,7 +483,7 @@ asmlinkage __visible void __init x86_64_start_kernel(char * real_mode_data)
> /* Kill off the identity-map trampoline */
> reset_early_page_tables();
>
> - __native_tlb_flush_global(native_read_cr4());
> + __native_tlb_flush_global(this_cpu_read(cpu_tlbstate.cr4));
>
> clear_bss();
>
We tested your patch, it can fix the issue, thanks.
=========================================================================================
compiler/kconfig/rootfs/sleep/tbox_group/testcase:
clang-14/x86_64-randconfig-a013-20211207/debian-10.4-x86_64-20200603.cgz/1/vm-snb/boot
commit:
9de4999050 ("x86/realmode: Add comment for Global bit usage in trampoline_pgd")
f154f29085 ("x86/mm/64: Flush global TLB on boot and AP bringup")
d12ddfe498 ("fixup-for-f154f29085")
9de4999050b5f2e8 f154f290855b070cc94dd44ad25 d12ddfe498329a0967c008d8183
---------------- --------------------------- ---------------------------
fail:runs %reproduction fail:runs %reproduction fail:runs
| | | | |
:27 100% 27:27 0% :27 dmesg.BUG:kernel_reboot-without-warning_in_boot_stage
next prev parent reply other threads:[~2021-12-21 14:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:41 [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage kernel test robot
2021-12-09 14:41 ` kernel test robot
2021-12-14 16:38 ` Borislav Petkov
2021-12-14 16:38 ` Borislav Petkov
2021-12-15 7:00 ` Carel Si
2021-12-15 7:00 ` [LKP] " Carel Si
2021-12-15 10:05 ` Borislav Petkov
2021-12-15 10:05 ` [LKP] " Borislav Petkov
2021-12-16 7:04 ` Yin Fengwei
2021-12-16 7:04 ` [LKP] " Yin Fengwei
2021-12-16 10:06 ` Borislav Petkov
2021-12-16 10:06 ` [LKP] " Borislav Petkov
2021-12-16 11:58 ` Carel Si
2021-12-16 11:58 ` [LKP] " Carel Si
2021-12-16 12:21 ` Yin Fengwei
2021-12-16 12:21 ` [LKP] " Yin Fengwei
2021-12-17 12:52 ` [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV? Borislav Petkov
2021-12-17 12:52 ` Borislav Petkov
2021-12-17 18:04 ` [LKP] " Nathan Chancellor
2021-12-17 18:04 ` Nathan Chancellor
2021-12-18 11:00 ` [LKP] " Borislav Petkov
2021-12-18 11:00 ` Borislav Petkov
2021-12-20 11:00 ` [PATCH] x86/mm: Prevent early boot triple-faults with instrumentation Borislav Petkov
2021-12-20 11:00 ` Borislav Petkov
2021-12-18 10:39 ` [LKP] Re: [x86/mm/64] f154f29085: BUG:kernel_reboot-without-warning_in_boot_stage - clang KCOV? Yin Fengwei
2021-12-18 10:39 ` Yin Fengwei
2021-12-18 11:01 ` [LKP] " Borislav Petkov
2021-12-18 11:01 ` Borislav Petkov
2021-12-20 1:51 ` [LKP] " Yin Fengwei
2021-12-20 1:51 ` Yin Fengwei
2021-12-21 14:31 ` Carel Si [this message]
2021-12-21 14:31 ` Carel Si
2021-12-21 15:10 ` [LKP] " Marco Elver
2021-12-21 15:10 ` Marco Elver
2021-12-21 15:22 ` [LKP] " Borislav Petkov
2021-12-21 15:22 ` Borislav Petkov
2022-01-05 2:35 ` [LKP] " Yin Fengwei
2022-01-05 2:35 ` Yin Fengwei
2022-01-05 11:36 ` [LKP] " Borislav Petkov
2022-01-05 11:36 ` Borislav Petkov
2022-01-05 12:47 ` [LKP] " Yin Fengwei
2022-01-05 12:47 ` Yin Fengwei
2022-01-05 15:21 ` [LKP] " Borislav Petkov
2022-01-05 15:21 ` Borislav Petkov
2022-01-06 6:56 ` [LKP] " Yin Fengwei
2022-01-06 6:56 ` Yin Fengwei
2021-12-21 15:14 ` [LKP] " Borislav Petkov
2021-12-21 15:14 ` Borislav Petkov
2021-12-22 10:59 ` [tip: x86/mm] x86/mm: Prevent early boot triple-faults with instrumentation tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221143153.GA4676@linux.intel.com \
--to=beibei.si@intel.com \
--cc=bfields@fieldses.org \
--cc=bp@suse.de \
--cc=fengwei.yin@intel.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.