Re: [PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4646 bytes --]

Hi "David,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on staging/staging-testing linus/master v5.16-rc6 next-20211221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211222/202112221515.JG78ViIG-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a9d461b63d0256caecd213865ac56ffb48b60c48
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
        git checkout a9d461b63d0256caecd213865ac56ffb48b60c48
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/infiniband/hw/irdma/ drivers/infiniband/hw/mlx5/ drivers/net/ethernet/mellanox/mlx5/core/ drivers/vdpa/mlx5/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/irdma/main.c: In function 'irdma_remove':
   drivers/infiniband/hw/irdma/main.c:210:38: error: implicit declaration of function 'auxiliary_get_drvdata' [-Werror=implicit-function-declaration]
     210 |         struct irdma_device *iwdev = auxiliary_get_drvdata(aux_dev);
         |                                      ^~~~~~~~~~~~~~~~~~~~~
>> drivers/infiniband/hw/irdma/main.c:210:38: warning: initialization of 'struct irdma_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
   drivers/infiniband/hw/irdma/main.c: In function 'irdma_probe':
   drivers/infiniband/hw/irdma/main.c:297:9: error: implicit declaration of function 'auxiliary_set_drvdata' [-Werror=implicit-function-declaration]
     297 |         auxiliary_set_drvdata(aux_dev, iwdev);
         |         ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   drivers/infiniband/hw/mlx5/main.c: In function 'mlx5r_mp_probe':
   drivers/infiniband/hw/mlx5/main.c:4425:9: error: implicit declaration of function 'auxiliary_set_drvdata' [-Werror=implicit-function-declaration]
    4425 |         auxiliary_set_drvdata(adev, mpi);
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/infiniband/hw/mlx5/main.c: In function 'mlx5r_mp_remove':
   drivers/infiniband/hw/mlx5/main.c:4433:15: error: implicit declaration of function 'auxiliary_get_drvdata' [-Werror=implicit-function-declaration]
    4433 |         mpi = auxiliary_get_drvdata(adev);
         |               ^~~~~~~~~~~~~~~~~~~~~
>> drivers/infiniband/hw/mlx5/main.c:4433:13: warning: assignment to 'struct mlx5_ib_multiport_info *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    4433 |         mpi = auxiliary_get_drvdata(adev);
         |             ^
   drivers/infiniband/hw/mlx5/main.c: In function 'mlx5r_remove':
>> drivers/infiniband/hw/mlx5/main.c:4491:13: warning: assignment to 'struct mlx5_ib_dev *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    4491 |         dev = auxiliary_get_drvdata(adev);
         |             ^
   cc1: some warnings being treated as errors


vim +210 drivers/infiniband/hw/irdma/main.c

   203	
   204	static void irdma_remove(struct auxiliary_device *aux_dev)
   205	{
   206		struct iidc_auxiliary_dev *iidc_adev = container_of(aux_dev,
   207								    struct iidc_auxiliary_dev,
   208								    adev);
   209		struct ice_pf *pf = iidc_adev->pf;
 > 210		struct irdma_device *iwdev = auxiliary_get_drvdata(aux_dev);
   211	
   212		irdma_ib_unregister_device(iwdev);
   213		ice_rdma_update_vsi_filter(pf, iwdev->vsi_num, false);
   214	
   215		pr_debug("INIT: Gen2 PF[%d] device remove success\n", PCI_FUNC(pf->pdev->devfn));
   216	}
   217	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org