Re: [PATCH 4/4] vdpa/mlx5: Use auxiliary_device driver data helpers

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3125 bytes --]

Hi "David,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on staging/staging-testing linus/master v5.16-rc6 next-20211221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211222/202112222008.UErq9RfO-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2d64ea213a12338ed3706a0ebf6fd7b356bc5a5f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-E-Box/driver_core-Auxiliary-drvdata-helper-cleanup/20211222-080023
        git checkout 2d64ea213a12338ed3706a0ebf6fd7b356bc5a5f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/infiniband/hw/irdma/ drivers/infiniband/hw/mlx5/ drivers/net/ethernet/mellanox/mlx5/core/ drivers/vdpa/mlx5/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/vdpa/mlx5/net/mlx5_vnet.c: In function 'mlx5v_probe':
   drivers/vdpa/mlx5/net/mlx5_vnet.c:2686:9: error: implicit declaration of function 'auxiliary_set_drvdata' [-Werror=implicit-function-declaration]
    2686 |         auxiliary_set_drvdata(adev, mgtdev);
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/vdpa/mlx5/net/mlx5_vnet.c: In function 'mlx5v_remove':
   drivers/vdpa/mlx5/net/mlx5_vnet.c:2699:18: error: implicit declaration of function 'auxiliary_get_drvdata' [-Werror=implicit-function-declaration]
    2699 |         mgtdev = auxiliary_get_drvdata(adev);
         |                  ^~~~~~~~~~~~~~~~~~~~~
>> drivers/vdpa/mlx5/net/mlx5_vnet.c:2699:16: warning: assignment to 'struct mlx5_vdpa_mgmtdev *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    2699 |         mgtdev = auxiliary_get_drvdata(adev);
         |                ^
   cc1: some warnings being treated as errors


vim +2699 drivers/vdpa/mlx5/net/mlx5_vnet.c

  2694	
  2695	static void mlx5v_remove(struct auxiliary_device *adev)
  2696	{
  2697		struct mlx5_vdpa_mgmtdev *mgtdev;
  2698	
> 2699		mgtdev = auxiliary_get_drvdata(adev);
  2700		vdpa_mgmtdev_unregister(&mgtdev->mgtdev);
  2701		kfree(mgtdev);
  2702	}
  2703	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org