All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
	linux-actions@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 07/13] mmc: owl: fix deferred probing
Date: Thu, 23 Dec 2021 23:02:30 +0530	[thread overview]
Message-ID: <20211223173230.GB5159@thinkpad> (raw)
In-Reply-To: <20211223171202.8224-8-s.shtylyov@omp.ru>

On Thu, Dec 23, 2021 at 08:11:56PM +0300, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
> 
> Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/mmc/host/owl-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..679b8b0b310e 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
>  
>  	owl_host->irq = platform_get_irq(pdev, 0);
>  	if (owl_host->irq < 0) {
> -		ret = -EINVAL;
> +		ret = owl_host->irq;
>  		goto err_release_channel;
>  	}
>  
> -- 
> 2.26.3
> 

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
	linux-actions@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 07/13] mmc: owl: fix deferred probing
Date: Thu, 23 Dec 2021 23:02:30 +0530	[thread overview]
Message-ID: <20211223173230.GB5159@thinkpad> (raw)
In-Reply-To: <20211223171202.8224-8-s.shtylyov@omp.ru>

On Thu, Dec 23, 2021 at 08:11:56PM +0300, Sergey Shtylyov wrote:
> The driver overrides the error codes returned by platform_get_irq() to
> -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream.
> 
> Fixes: ff65ffe46d28 ("mmc: Add Actions Semi Owl SoCs SD/MMC driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/mmc/host/owl-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..679b8b0b310e 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -638,7 +638,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
>  
>  	owl_host->irq = platform_get_irq(pdev, 0);
>  	if (owl_host->irq < 0) {
> -		ret = -EINVAL;
> +		ret = owl_host->irq;
>  		goto err_release_channel;
>  	}
>  
> -- 
> 2.26.3
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-23 17:32 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 17:11 [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 01/13] mmc: bcm2835: fix deferred probing Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-24 22:08   ` Florian Fainelli
2021-12-24 22:08     ` Florian Fainelli
2021-12-23 17:11 ` [PATCH RFC 02/13] mmc: meson-gx: " Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-24 17:35   ` Martin Blumenstingl
2021-12-24 17:35     ` Martin Blumenstingl
2021-12-24 17:35     ` Martin Blumenstingl
2021-12-24 17:37     ` Sergey Shtylyov
2021-12-24 17:37       ` Sergey Shtylyov
2021-12-24 17:37       ` Sergey Shtylyov
2023-04-01  6:38   ` Christian Hewitt
2023-04-01  6:38     ` Christian Hewitt
2023-04-01  6:38     ` Christian Hewitt
2023-04-02 17:58     ` Sergey Shtylyov
2023-04-02 17:58       ` Sergey Shtylyov
2023-04-02 17:58       ` Sergey Shtylyov
2023-06-08 20:07       ` Sergey Shtylyov
2023-06-08 20:07         ` Sergey Shtylyov
2023-06-08 20:07         ` Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 03/13] mmc: mtk-sd: " Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2022-01-04 11:00   ` AngeloGioacchino Del Regno
2022-01-04 11:00     ` AngeloGioacchino Del Regno
2022-01-04 11:00     ` AngeloGioacchino Del Regno
2021-12-23 17:11 ` [PATCH RFC 04/13] mmc: mvsdio: " Sergey Shtylyov
2021-12-23 18:48   ` Nicolas Pitre
2021-12-23 17:11 ` [PATCH RFC 05/13] mmc: omap: " Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 06/13] mmc: omap_hsmmc: " Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 07/13] mmc: owl: " Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-23 17:32   ` Manivannan Sadhasivam [this message]
2021-12-23 17:32     ` Manivannan Sadhasivam
2021-12-23 17:11 ` [PATCH RFC 08/13] mmc: s3mci: " Sergey Shtylyov
2021-12-23 17:11   ` Sergey Shtylyov
2021-12-23 17:11 ` [PATCH RFC 09/13] mmc: sdhci-acpi: " Sergey Shtylyov
2022-01-03  8:25   ` Adrian Hunter
2021-12-23 17:11 ` [PATCH RFC 10/13] mmc: sdhci-spear: " Sergey Shtylyov
2021-12-27  4:16   ` Viresh Kumar
2022-01-03  8:30   ` Adrian Hunter
2021-12-23 17:12 ` [PATCH RFC 11/13] mmc: sh_mmcif: " Sergey Shtylyov
2021-12-23 17:12 ` [PATCH RFC 12/13] mmc: sunxi: " Sergey Shtylyov
2021-12-23 17:12   ` Sergey Shtylyov
2021-12-23 17:12 ` [PATCH RFC 13/13] mmc: usdhi60rol0: " Sergey Shtylyov
2021-12-27 10:45   ` Jesper Nilsson
2021-12-28 16:40 ` [PATCH RFC 0/13] Fix deferred probing in the MMC/SD drivers Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223173230.GB5159@thinkpad \
    --to=mani@kernel.org \
    --cc=afaerber@suse.de \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.shtylyov@omp.ru \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.