All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/harfbuzz: fix host build failure due to C++11
Date: Mon, 27 Dec 2021 22:24:35 +0100	[thread overview]
Message-ID: <20211227222435.393248e5@windsurf> (raw)
In-Reply-To: <20211225214638.105114-1-giulio.benetti@benettiengineering.com>

On Sat, 25 Dec 2021 22:46:38 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Package harfbuzz fails to build for host with error:
> ```
> ../src/hb-map.hh:67:18: error: 'is_trivially_copyable' is not a member of 'std'
>    static_assert (std::is_trivially_copyable<K>::value, "");
> ```
> 
> Only starting from gcc version 5.0 we have 'is_trivially_copyable' member
> of std. So let's depend on BR2_HOST_GCC_AT_LEAST_5 for harfbuzz. Let's
> also depend on it in pango package which is the only one which needs
> host-harfbuzz.
> 
> Fixes:
> http://autobuild.buildroot.net/results/89e1194c1659d7e1af9db8ffe5feee770c448f76
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/harfbuzz/Config.in | 6 ++++--
>  package/pango/Config.in    | 4 +++-
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/package/harfbuzz/Config.in b/package/harfbuzz/Config.in
> index 2e4219ee22..81acebce46 100644
> --- a/package/harfbuzz/Config.in
> +++ b/package/harfbuzz/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_HARFBUZZ
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +	depends on BR2_HOST_GCC_AT_LEAST_5 # C++11

It is kind of hard to believe that it would require gcc 5.0 on the
host, but only gcc 4.9 for the target.

Could you clarify this?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-12-27 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-25 21:46 [Buildroot] [PATCH] package/harfbuzz: fix host build failure due to C++11 Giulio Benetti
2021-12-27 21:24 ` Thomas Petazzoni [this message]
2021-12-27 22:40   ` Giulio Benetti
2021-12-28  0:22   ` [Buildroot] [PATCH v2] " Giulio Benetti
2021-12-28  9:25     ` Fabrice Fontaine
2021-12-28  9:36       ` Giulio Benetti
2021-12-28  9:55       ` [Buildroot] [PATCH v3] " Giulio Benetti
2022-07-22 21:31         ` Thomas Petazzoni via buildroot
2022-07-22 22:24           ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227222435.393248e5@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.