Re: [Buildroot] [PATCH v3] package/harfbuzz: fix host build failure due to C++11

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "Bernd Kuhls" <bernd.kuhls@t-online.de>,
	"Eric Le Bihan" <eric.le.bihan.dev@free.fr>,
	"Raphaël Mélotte" <raphael.melotte@mind.be>,
	"Samuel Martin" <s.martin49@gmail.com>,
	"Asaf Kahlon" <asafka7@gmail.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Simon Dawson" <spdawson@gmail.com>,
	"Julien Corjon" <corjon.j@ecagroup.com>,
	"James Knight" <james.knight@collins.com>,
	buildroot@buildroot.org, "Romain Naour" <romain.naour@gmail.com>,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>
Subject: Re: [Buildroot] [PATCH v3] package/harfbuzz: fix host build failure due to C++11
Date: Fri, 22 Jul 2022 23:31:12 +0200	[thread overview]
Message-ID: <20220722233112.7c00f940@windsurf> (raw)
In-Reply-To: <20211228095539.25395-1-giulio.benetti@benettiengineering.com>

Hello Giulio,

On Tue, 28 Dec 2021 10:55:39 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Package harfbuzz fails to build for host with error:
> ```
> ../src/hb-map.hh:67:18: error: 'is_trivially_copyable' is not a member of 'std'
>    static_assert (std::is_trivially_copyable<K>::value, "");
> ```
> 
> Only starting from gcc version 5.0 we have 'is_trivially_copyable' member
> of std. So let's depend on BR2_HOST_GCC_AT_LEAST_5 for harfbuzz itself
> and all host-harfbuzz dependencies, but let's also depend on
> BR2_TOOLCHAIN_GCC_AT_LEAST_5 for all the harfbuzz direct and reverse
> dependencies since the configure/build statements are the same for host
> and target harfbuzz package.
> 
> Fixes:
> http://autobuild.buildroot.net/results/89e1194c1659d7e1af9db8ffe5feee770c448f76
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add BR2_TOOLCHAIN_GCC_AT_LEAST_5 to harfbuzz and its dependencies
> V2->V3:
> * add BR2_HOST_GCC_AT_LEAST_5 to all host-harfbuzz dependencies
> ---
>  package/adwaita-icon-theme/Config.in           |  5 +++++
>  package/cwiid/Config.in                        |  2 +-
>  package/efl/Config.in                          |  1 +
>  package/enlightenment/Config.in                |  6 +++---
>  package/gstreamer1/gst1-plugins-bad/Config.in  | 17 +++++++++--------
>  package/gstreamer1/gst1-plugins-base/Config.in |  6 +++---
>  package/gtkmm3/Config.in                       |  2 +-
>  package/harfbuzz/Config.in                     |  8 +++++---
>  package/imagemagick/Config.in.host             |  4 ++++
>  package/kodi/Config.in                         |  2 +-
>  package/libass/Config.in                       |  6 +++---
>  package/libfm/Config.in                        |  6 +++---
>  package/libgtk2/Config.in                      |  6 +++---
>  package/libgtk3/Config.in                      |  2 +-
>  package/librsvg/Config.in                      |  6 +++---
>  package/mupdf/Config.in                        |  6 +++---
>  package/openbox/Config.in                      |  6 +++---
>  package/pango/Config.in                        |  8 +++++---
>  package/pangomm/Config.in                      |  8 ++++----
>  package/pcmanfm/Config.in                      |  6 +++---
>  package/pinentry/Config.in                     |  6 +++---
>  package/python-pymupdf/Config.in               |  6 +++---
>  package/qt5/qt5base/Config.in                  |  2 +-
>  package/rrdtool/Config.in                      |  6 +++---
>  package/supertuxkart/Config.in                 |  6 +++---
>  package/xscreensaver/Config.in                 |  6 +++---
>  26 files changed, 80 insertions(+), 65 deletions(-)

This patch is no longer needed since harfbuzz upstream commit
c657c4e1f8e6f23828fefbc441b01f7bee685c79, which is upstream since
release 4.3.0.

This commit goes like this:

commit c657c4e1f8e6f23828fefbc441b01f7bee685c79
Author: Thomas Devoogdt <thomas.devoogdt@barco.com>
Date:   Tue May 10 10:00:06 2022 +0200

    [meta] fix type traits on gcc 4.9 #3526

    Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Much simpler than having to propagate this crazy host gcc dependency!
:-)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot