From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used
Date: Sat, 1 Jan 2022 09:49:32 +0100 [thread overview]
Message-ID: <20220101084937.3411-3-straube.linux@gmail.com> (raw)
In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com>
The field UsbRxHighSpeedMode of struct hal_data_8188e is set but
never used. Remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v3: no changes
v2: no changes
drivers/staging/r8188eu/hal/usb_halinit.c | 5 -----
drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index 104705ef170e..96db9a8e7667 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -502,16 +502,11 @@ usb_AggSettingRxUpdate(
static void InitUsbAggregationSetting(struct adapter *Adapter)
{
- struct hal_data_8188e *haldata = &Adapter->haldata;
-
/* Tx aggregation setting */
usb_AggSettingTxUpdate(Adapter);
/* Rx aggregation setting */
usb_AggSettingRxUpdate(Adapter);
-
- /* 201/12/10 MH Add for USB agg mode dynamic switch. */
- haldata->UsbRxHighSpeedMode = false;
}
static void _InitOperationMode(struct adapter *Adapter)
diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index e8cb093abb62..8b54f52f49e2 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -262,9 +262,6 @@ struct hal_data_8188e {
u8 OutEpQueueSel;
u8 OutEpNumber;
- /* Add for USB aggreation mode dynamic shceme. */
- bool UsbRxHighSpeedMode;
-
/* 2010/11/22 MH Add for slim combo debug mode selective. */
/* This is used for fix the drawback of CU TSMC-A/UMC-A cut.
* HW auto suspend ability. Close BT clock. */
--
2.34.1
next prev parent reply other threads:[~2022-01-01 8:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 8:49 [PATCH v3 0/7] staging: r8188eu: clean up struct hal_data_8188e Michael Straube
2022-01-01 8:49 ` [PATCH v3 1/7] staging: r8188eu: bRDGEnable is always false Michael Straube
2022-01-02 17:02 ` Martin Kaiser
2022-01-01 8:49 ` Michael Straube [this message]
2022-01-02 17:06 ` [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM " Michael Straube
2022-01-02 17:16 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore " Michael Straube
2022-01-02 17:17 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2022-01-02 17:23 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Michael Straube
2022-01-02 17:27 ` Martin Kaiser
2022-01-01 8:49 ` [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is " Michael Straube
2022-01-02 17:28 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220101084937.3411-3-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.