All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore is set but never used
Date: Sat,  1 Jan 2022 09:49:34 +0100	[thread overview]
Message-ID: <20220101084937.3411-5-straube.linux@gmail.com> (raw)
In-Reply-To: <20220101084937.3411-1-straube.linux@gmail.com>

The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but
never used. Remove it.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
v3: no changes
v2: no changes

 drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ++---
 drivers/staging/r8188eu/include/rtl8188e_hal.h  | 1 -
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
index 065c2701077d..cce291ca44b1 100644
--- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
@@ -1230,9 +1230,8 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter, u8 *PROMContent, bool Aut
 	else
 		pHalData->EEPROMThermalMeter = EEPROM_Default_ThermalMeter_88E;
 
-	if (pHalData->EEPROMThermalMeter == 0xff || AutoloadFail) {
-		pHalData->bAPKThermalMeterIgnore = true;
+	if (pHalData->EEPROMThermalMeter == 0xff || AutoloadFail)
 		pHalData->EEPROMThermalMeter = EEPROM_Default_ThermalMeter_88E;
-	}
+
 	DBG_88E("ThermalMeter = 0x%x\n", pHalData->EEPROMThermalMeter);
 }
diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
index de58c85b8bdc..40b3db34b8f2 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
@@ -181,7 +181,6 @@ struct hal_data_8188e {
 	u8	EEPROMRegulatory;
 
 	u8	EEPROMThermalMeter;
-	u8	bAPKThermalMeterIgnore;
 
 	bool	EepromOrEfuse;
 
-- 
2.34.1


  parent reply	other threads:[~2022-01-01  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-01  8:49 [PATCH v3 0/7] staging: r8188eu: clean up struct hal_data_8188e Michael Straube
2022-01-01  8:49 ` [PATCH v3 1/7] staging: r8188eu: bRDGEnable is always false Michael Straube
2022-01-02 17:02   ` Martin Kaiser
2022-01-01  8:49 ` [PATCH v3 2/7] staging: r8188eu: UsbRxHighSpeedMode is set but never used Michael Straube
2022-01-02 17:06   ` Martin Kaiser
2022-01-01  8:49 ` [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM " Michael Straube
2022-01-02 17:16   ` Martin Kaiser
2022-01-01  8:49 ` Michael Straube [this message]
2022-01-02 17:17   ` [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore " Martin Kaiser
2022-01-01  8:49 ` [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data_8188e Michael Straube
2022-01-02 17:23   ` Martin Kaiser
2022-01-01  8:49 ` [PATCH v3 6/7] staging: r8188eu: IntArray and C2hArray are set but never used Michael Straube
2022-01-02 17:27   ` Martin Kaiser
2022-01-01  8:49 ` [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is " Michael Straube
2022-01-02 17:28   ` Martin Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220101084937.3411-5-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.