[PATCH v2 1/1] Fix reserved Feature bits numbering

[PATCH v2 1/1] Fix reserved Feature bits numbering

[Max Gurtovoy]

This should have been updated during VIRTIO_F_NOTIFICATION_DATA,
VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---

changes from v1:
 - added "Reviewed-by" signature (Stefan)
 - include VIRTIO_F_RING_RESET feature bit (Cornelia)

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/content.tex b/content.tex
index cf20570..32de668 100644
--- a/content.tex
+++ b/content.tex
@@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 \begin{description}
 \item[0 to 23] Feature bits for the specific device type
 
-\item[24 to 37] Feature bits reserved for extensions to the queue and
+\item[24 to 40] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[38 and above] Feature bits reserved for future extensions.
+\item[41 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}
-- 
2.21.0

[virtio-comment] Re: [PATCH v2 1/1] Fix reserved Feature bits numbering

[Cornelia Huck]

On Mon, Jan 03 2022, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:

> This should have been updated during VIRTIO_F_NOTIFICATION_DATA,
> VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>

Fixes: https://github.com/oasis-tcs/virtio-spec/issues/128

Can you please also update the archive link in the issue, once the mail
shows up there?

> ---
>
> changes from v1:
>  - added "Reviewed-by" signature (Stefan)
>  - include VIRTIO_F_RING_RESET feature bit (Cornelia)
>
> ---
>  content.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index cf20570..32de668 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
>  \begin{description}
>  \item[0 to 23] Feature bits for the specific device type
>  
> -\item[24 to 37] Feature bits reserved for extensions to the queue and
> +\item[24 to 40] Feature bits reserved for extensions to the queue and
>    feature negotiation mechanisms
>  
> -\item[38 and above] Feature bits reserved for future extensions.
> +\item[41 and above] Feature bits reserved for future extensions.
>  \end{description}
>  
>  \begin{note}

LGTM.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [PATCH v2 1/1] Fix reserved Feature bits numbering

[Max Gurtovoy]

On 1/3/2022 7:20 PM, Cornelia Huck wrote:
> On Mon, Jan 03 2022, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>
>> This should have been updated during VIRTIO_F_NOTIFICATION_DATA,
>> VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.
>>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/128
>
> Can you please also update the archive link in the issue, once the mail
> shows up there?

Done.

Please let me know if there is something else, or you can take it from 
here ?


>
>> ---
>>
>> changes from v1:
>>   - added "Reviewed-by" signature (Stefan)
>>   - include VIRTIO_F_RING_RESET feature bit (Cornelia)
>>
>> ---
>>   content.tex | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/content.tex b/content.tex
>> index cf20570..32de668 100644
>> --- a/content.tex
>> +++ b/content.tex
>> @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
>>   \begin{description}
>>   \item[0 to 23] Feature bits for the specific device type
>>   
>> -\item[24 to 37] Feature bits reserved for extensions to the queue and
>> +\item[24 to 40] Feature bits reserved for extensions to the queue and
>>     feature negotiation mechanisms
>>   
>> -\item[38 and above] Feature bits reserved for future extensions.
>> +\item[41 and above] Feature bits reserved for future extensions.
>>   \end{description}
>>   
>>   \begin{note}
> LGTM.
>

Re: [PATCH v2 1/1] Fix reserved Feature bits numbering

[Michael S. Tsirkin]

On Mon, Jan 03, 2022 at 06:20:45PM +0100, Cornelia Huck wrote:
> On Mon, Jan 03 2022, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
> 
> > This should have been updated during VIRTIO_F_NOTIFICATION_DATA,
> > VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/128
> 
> Can you please also update the archive link in the issue, once the mail
> shows up there?


Wish we had a cleaner way to do it than updating this each time we
add a generic feature bit.

> > ---
> >
> > changes from v1:
> >  - added "Reviewed-by" signature (Stefan)
> >  - include VIRTIO_F_RING_RESET feature bit (Cornelia)
> >
> > ---
> >  content.tex | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/content.tex b/content.tex
> > index cf20570..32de668 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -99,10 +99,10 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
> >  \begin{description}
> >  \item[0 to 23] Feature bits for the specific device type
> >  
> > -\item[24 to 37] Feature bits reserved for extensions to the queue and
> > +\item[24 to 40] Feature bits reserved for extensions to the queue and
> >    feature negotiation mechanisms
> >  
> > -\item[38 and above] Feature bits reserved for future extensions.
> > +\item[41 and above] Feature bits reserved for future extensions.
> >  \end{description}
> >  
> >  \begin{note}
> 
> LGTM.

[virtio-comment] Re: [PATCH v2 1/1] Fix reserved Feature bits numbering

[Cornelia Huck]

On Mon, Jan 03 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jan 03, 2022 at 06:20:45PM +0100, Cornelia Huck wrote:
>> On Mon, Jan 03 2022, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>> 
>> > This should have been updated during VIRTIO_F_NOTIFICATION_DATA,
>> > VIRTIO_F_NOTIF_CONFIG_DATA and VIRTIO_F_RING_RESET standartization.
>> >
>> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> > Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> 
>> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/128
>> 
>> Can you please also update the archive link in the issue, once the mail
>> shows up there?
>
>
> Wish we had a cleaner way to do it than updating this each time we
> add a generic feature bit.

Indeed. But let's just go with this fixup until we come up with a better
way.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/