* [PATCH -next] NTFS: Fix one kernel-doc comment
@ 2022-01-06 1:51 Yang Li
2022-01-06 2:01 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-01-06 1:51 UTC (permalink / raw)
To: anton; +Cc: linux-ntfs-dev, linux-kernel, Yang Li, Abaci Robot
/**
* attrib.c - NTFS attribute operations. Part of the Linux-NTFS
The comments for the file should not be in kernel-doc format, which causes
it to be incorrectly identified for function ntfs_map_runlist_nolock(),
causing some warnings found by running scripts/kernel-doc.
fs/ntfs/attrib.c:25: warning: Incorrect use of kernel-doc format: *
ntfs_map_runlist_nolock - map (a part of) a runlist of an ntfs inode
fs/ntfs/attrib.c:71: warning: Function parameter or member 'ni' not
described in 'ntfs_map_runlist_nolock'
fs/ntfs/attrib.c:71: warning: Function parameter or member 'vcn' not
described in 'ntfs_map_runlist_nolock'
fs/ntfs/attrib.c:71: warning: Function parameter or member 'ctx' not
described in 'ntfs_map_runlist_nolock'
fs/ntfs/attrib.c:71: warning: expecting prototype for attrib.c - NTFS
attribute operations. Part of the Linux(). Prototype was for
ntfs_map_runlist_nolock() instead
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/ntfs/attrib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index d563abc3e136..2911c04a33e0 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
* attrib.c - NTFS attribute operations. Part of the Linux-NTFS project.
*
* Copyright (c) 2001-2012 Anton Altaparmakov and Tuxera Inc.
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] NTFS: Fix one kernel-doc comment
2022-01-06 1:51 [PATCH -next] NTFS: Fix one kernel-doc comment Yang Li
@ 2022-01-06 2:01 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-01-06 2:01 UTC (permalink / raw)
To: Yang Li, anton; +Cc: linux-ntfs-dev, linux-kernel, Abaci Robot, akpm
On 1/5/22 17:51, Yang Li wrote:
> /**
> * attrib.c - NTFS attribute operations. Part of the Linux-NTFS
>
> The comments for the file should not be in kernel-doc format, which causes
> it to be incorrectly identified for function ntfs_map_runlist_nolock(),
> causing some warnings found by running scripts/kernel-doc.
>
> fs/ntfs/attrib.c:25: warning: Incorrect use of kernel-doc format: *
> ntfs_map_runlist_nolock - map (a part of) a runlist of an ntfs inode
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'ni' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'vcn' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: Function parameter or member 'ctx' not
> described in 'ntfs_map_runlist_nolock'
> fs/ntfs/attrib.c:71: warning: expecting prototype for attrib.c - NTFS
> attribute operations. Part of the Linux(). Prototype was for
> ntfs_map_runlist_nolock() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
[adding akpm]
> ---
> fs/ntfs/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index d563abc3e136..2911c04a33e0 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> -/**
> +/*
> * attrib.c - NTFS attribute operations. Part of the Linux-NTFS project.
> *
> * Copyright (c) 2001-2012 Anton Altaparmakov and Tuxera Inc.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-06 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-06 1:51 [PATCH -next] NTFS: Fix one kernel-doc comment Yang Li
2022-01-06 2:01 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.