From: Bjorn Helgaas <helgaas@kernel.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Intel-gfx] [PATCH v2 2/2] x86/quirks: better wrap quirk conditions
Date: Thu, 6 Jan 2022 16:23:25 -0600 [thread overview]
Message-ID: <20220106222325.GA329826@bhelgaas> (raw)
In-Reply-To: <20220106003654.770316-2-lucas.demarchi@intel.com>
On Wed, Jan 05, 2022 at 04:36:54PM -0800, Lucas De Marchi wrote:
> Remove extra parenthesis and wrap lines so it's easier to read what are
> the conditions being checked. The call to the hook also had an extra
> indentation: remove here to conform to coding style.
It's nice when your subject lines are consistent. These look like:
x86/quirks: Fix logic to apply quirk once
x86/quirks: better wrap quirk conditions
The second isn't capitalized like the first. Obviously if you split
the first patch, you'll have three subject lines, and one will mention
Alderlake.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: x86@kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>
Subject: Re: [PATCH v2 2/2] x86/quirks: better wrap quirk conditions
Date: Thu, 6 Jan 2022 16:23:25 -0600 [thread overview]
Message-ID: <20220106222325.GA329826@bhelgaas> (raw)
In-Reply-To: <20220106003654.770316-2-lucas.demarchi@intel.com>
On Wed, Jan 05, 2022 at 04:36:54PM -0800, Lucas De Marchi wrote:
> Remove extra parenthesis and wrap lines so it's easier to read what are
> the conditions being checked. The call to the hook also had an extra
> indentation: remove here to conform to coding style.
It's nice when your subject lines are consistent. These look like:
x86/quirks: Fix logic to apply quirk once
x86/quirks: better wrap quirk conditions
The second isn't capitalized like the first. Obviously if you split
the first patch, you'll have three subject lines, and one will mention
Alderlake.
Bjorn
next prev parent reply other threads:[~2022-01-06 22:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 0:36 [Intel-gfx] [PATCH v2 1/2] x86/quirks: Fix logic to apply quirk once Lucas De Marchi
2022-01-06 0:36 ` Lucas De Marchi
2022-01-06 0:36 ` [Intel-gfx] [PATCH v2 2/2] x86/quirks: better wrap quirk conditions Lucas De Marchi
2022-01-06 0:36 ` Lucas De Marchi
2022-01-06 22:23 ` Bjorn Helgaas [this message]
2022-01-06 22:23 ` Bjorn Helgaas
2022-01-06 22:45 ` [Intel-gfx] " Lucas De Marchi
2022-01-06 22:45 ` Lucas De Marchi
2022-01-06 1:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] x86/quirks: Fix logic to apply quirk once Patchwork
2022-01-06 21:58 ` [Intel-gfx] [PATCH v2 1/2] " Bjorn Helgaas
2022-01-06 21:58 ` Bjorn Helgaas
2022-01-06 22:30 ` [Intel-gfx] " Lucas De Marchi
2022-01-06 22:30 ` Lucas De Marchi
2022-01-06 23:16 ` [Intel-gfx] " Bjorn Helgaas
2022-01-06 23:16 ` Bjorn Helgaas
2022-01-07 12:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106222325.GA329826@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.