[ammarfaizi2-block:paulmck/linux-rcu/dev 50/53] kernel/time/tick-sched.c:1453:1: sparse: sparse: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

[ammarfaizi2-block:paulmck/linux-rcu/dev 50/53] kernel/time/tick-sched.c:1453:1: sparse: sparse: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

tree:   https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head:   56b8a9dc5e8aa4d625a09ce87015016ae339d44d
commit: 3cda34a0004e965b08daf04fb0f2cee935654e9f [50/53] EXP timers: Non-nohz_full last-resort jiffies update on IRQ entry
config: i386-randconfig-s001-20220107 (https://download.01.org/0day-ci/archive/20220107/202201071509.qlXBeLQz-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/ammarfaizi2/linux-block/commit/3cda34a0004e965b08daf04fb0f2cee935654e9f
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
        git checkout 3cda34a0004e965b08daf04fb0f2cee935654e9f
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash kernel/time/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> kernel/time/tick-sched.c:1453:1: sparse: sparse: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[ammarfaizi2-block:paulmck/linux-rcu/dev 50/53] kernel/time/tick-sched.c:1453:1: sparse: sparse: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

[kernel test robot]

tree:   https://github.com/ammarfaizi2/linux-block paulmck/linux-rcu/dev
head:   56b8a9dc5e8aa4d625a09ce87015016ae339d44d
commit: 3cda34a0004e965b08daf04fb0f2cee935654e9f [50/53] EXP timers: Non-nohz_full last-resort jiffies update on IRQ entry
config: i386-randconfig-s001-20220107 (https://download.01.org/0day-ci/archive/20220107/202201071509.qlXBeLQz-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/ammarfaizi2/linux-block/commit/3cda34a0004e965b08daf04fb0f2cee935654e9f
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block paulmck/linux-rcu/dev
        git checkout 3cda34a0004e965b08daf04fb0f2cee935654e9f
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash kernel/time/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> kernel/time/tick-sched.c:1453:1: sparse: sparse: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[RFC PATCH ammarfaizi2-block] EXP timers: __pcpu_scope_tick_setup_sched_timer_help_needed can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

kernel/time/tick-sched.c:1453:1: warning: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

Fixes: 3cda34a0004e ("EXP timers: Non-nohz_full last-resort jiffies update on IRQ entry")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 tick-sched.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 8790cd4834887c..1af62743be63e8 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1450,7 +1450,7 @@ early_param("skew_tick", skew_tick);
 
 static DEFINE_PER_CPU(unsigned long, tick_setup_sched_timer_jiffies);
 static DEFINE_PER_CPU(int, tick_setup_sched_timer_jiffies_count);
-DEFINE_PER_CPU(bool, tick_setup_sched_timer_help_needed);
+static DEFINE_PER_CPU(bool, tick_setup_sched_timer_help_needed);
 
 /**
  * tick_setup_sched_timer - setup the tick emulation timer

[RFC PATCH ammarfaizi2-block] EXP timers: __pcpu_scope_tick_setup_sched_timer_help_needed can be static

[kernel test robot]

kernel/time/tick-sched.c:1453:1: warning: symbol '__pcpu_scope_tick_setup_sched_timer_help_needed' was not declared. Should it be static?

Fixes: 3cda34a0004e ("EXP timers: Non-nohz_full last-resort jiffies update on IRQ entry")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 tick-sched.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 8790cd4834887c..1af62743be63e8 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1450,7 +1450,7 @@ early_param("skew_tick", skew_tick);
 
 static DEFINE_PER_CPU(unsigned long, tick_setup_sched_timer_jiffies);
 static DEFINE_PER_CPU(int, tick_setup_sched_timer_jiffies_count);
-DEFINE_PER_CPU(bool, tick_setup_sched_timer_help_needed);
+static DEFINE_PER_CPU(bool, tick_setup_sched_timer_help_needed);
 
 /**
  * tick_setup_sched_timer - setup the tick emulation timer