From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id
Date: Fri, 7 Jan 2022 20:00:43 +0000 [thread overview]
Message-ID: <20220107200042.ee3ceehrio2k3dui@skbuf> (raw)
In-Reply-To: <abc74eaa-dd76-a022-d09d-3845e7e9c7d2@gmail.com>
On Fri, Jan 07, 2022 at 11:48:30AM -0800, Florian Fainelli wrote:
> On 1/7/22 11:37 AM, Andrew Lunn wrote:
> > On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
> >> There are no legacy ports, DSA registers a devlink instance with ports
> >> unconditionally for all switch drivers. Therefore, delete the old-style
> >> ndo operations used for determining bridge forwarding domains.
> >>
> >> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >
> > Hi Vladimir
> >
> > Maybe ask Ido or Jiri to review this? But none of the Mellanox drivers
> > use use these ndo's, suggesting it is correct.
>
> I confirmed that /sys/class/net/*/phys_port_name continues to work
> before and after this patch, so:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Hi Jiri, Ido, could you please take a look? Patch content got cut, but
it's right here:
https://patchwork.kernel.org/project/netdevbpf/patch/20220107184842.550334-2-vladimir.oltean@nxp.com/
next prev parent reply other threads:[~2022-01-07 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 18:48 [RFC PATCH net-next 0/2] More aggressive DSA cleanup Vladimir Oltean
2022-01-07 18:48 ` [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id Vladimir Oltean
2022-01-07 19:37 ` Andrew Lunn
2022-01-07 19:48 ` Florian Fainelli
2022-01-07 20:00 ` Vladimir Oltean [this message]
2022-01-09 17:25 ` Ido Schimmel
2022-01-10 9:33 ` Jiri Pirko
2022-01-07 18:48 ` [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list Vladimir Oltean
2022-01-07 19:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107200042.ee3ceehrio2k3dui@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.