From: Ido Schimmel <idosch@idosch.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id
Date: Sun, 9 Jan 2022 19:25:38 +0200 [thread overview]
Message-ID: <YdsakgRku3ZgF77f@shredder> (raw)
In-Reply-To: <20220107184842.550334-2-vladimir.oltean@nxp.com>
On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
> There are no legacy ports, DSA registers a devlink instance with ports
> unconditionally for all switch drivers. Therefore, delete the old-style
> ndo operations used for determining bridge forwarding domains.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Looks correct to me.
If ndo_get_phys_port_name() is not implemented, then
devlink_compat_phys_port_name_get() is called which invokes
ndo_get_devlink_port() that you have implemented. Similarly, for
ndo_get_port_parent_id().
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2022-01-09 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 18:48 [RFC PATCH net-next 0/2] More aggressive DSA cleanup Vladimir Oltean
2022-01-07 18:48 ` [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id Vladimir Oltean
2022-01-07 19:37 ` Andrew Lunn
2022-01-07 19:48 ` Florian Fainelli
2022-01-07 20:00 ` Vladimir Oltean
2022-01-09 17:25 ` Ido Schimmel [this message]
2022-01-10 9:33 ` Jiri Pirko
2022-01-07 18:48 ` [RFC PATCH net-next 2/2] net: dsa: remove lockdep class for DSA master address list Vladimir Oltean
2022-01-07 19:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdsakgRku3ZgF77f@shredder \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.