All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Zong Li <zong.li@sifive.com>,
	lee.jones@linaro.org, linux-clk@vger.kernel.org,
	linux-riscv@lists.infradead.org, mturquette@baylibre.com,
	palmer@dabbelt.com, paul.walmsley@sifive.com
Cc: Zong Li <zong.li@sifive.com>
Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning
Date: Fri, 07 Jan 2022 16:45:13 -0800	[thread overview]
Message-ID: <20220108004514.C331AC36AE9@smtp.kernel.org> (raw)
In-Reply-To: <20220107090715.2601-1-zong.li@sifive.com>

Quoting Zong Li (2022-01-07 01:07:15)
> This commit reverts commit 487dc7bb6a0c ("clk: sifive: fu540-prci:
> Declare static const variable 'prci_clk_fu540' where it's used").
> For fixing W=1 kernel build warning(s) about ‘prci_clk_fu540’ defined
> but not used [-Wunused-const-variable=], the problem is that the C file
> of fu540 and fu740 doesn't use these variables, but they includes the
> header files. We could refine the code by moving the definition of these
> variables into fu540 and fu740 implementation respectively instead of
> common core code, then we could still separate the SoCs-dependent data
> in their own implementation.
> 
> Fixes: 487dc7bb6a0c ("clk: sifive: fu540-prci: Declare static
> const variable 'prci_clk_fu540' where it's used")

The fixes tag should be on one line, not split across two.

> Signed-off-by: Zong Li <zong.li@sifive.com>
>

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Zong Li <zong.li@sifive.com>,
	lee.jones@linaro.org, linux-clk@vger.kernel.org,
	linux-riscv@lists.infradead.org, mturquette@baylibre.com,
	palmer@dabbelt.com, paul.walmsley@sifive.com
Cc: Zong Li <zong.li@sifive.com>
Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning
Date: Fri, 07 Jan 2022 16:45:13 -0800	[thread overview]
Message-ID: <20220108004514.C331AC36AE9@smtp.kernel.org> (raw)
In-Reply-To: <20220107090715.2601-1-zong.li@sifive.com>

Quoting Zong Li (2022-01-07 01:07:15)
> This commit reverts commit 487dc7bb6a0c ("clk: sifive: fu540-prci:
> Declare static const variable 'prci_clk_fu540' where it's used").
> For fixing W=1 kernel build warning(s) about ‘prci_clk_fu540’ defined
> but not used [-Wunused-const-variable=], the problem is that the C file
> of fu540 and fu740 doesn't use these variables, but they includes the
> header files. We could refine the code by moving the definition of these
> variables into fu540 and fu740 implementation respectively instead of
> common core code, then we could still separate the SoCs-dependent data
> in their own implementation.
> 
> Fixes: 487dc7bb6a0c ("clk: sifive: fu540-prci: Declare static
> const variable 'prci_clk_fu540' where it's used")

The fixes tag should be on one line, not split across two.

> Signed-off-by: Zong Li <zong.li@sifive.com>
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2022-01-08  0:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07  9:07 [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning Zong Li
2022-01-07  9:07 ` Zong Li
2022-01-08  0:45 ` Stephen Boyd [this message]
2022-01-08  0:45   ` Stephen Boyd
2022-01-10  1:52   ` Zong Li
2022-01-10  1:52     ` Zong Li
2022-01-10  9:50 ` Lee Jones
2022-01-10  9:50   ` Lee Jones
2022-01-11  3:21   ` Zong Li
2022-01-11  3:21     ` Zong Li
2022-01-11  9:32     ` Lee Jones
2022-01-11  9:32       ` Lee Jones
2022-01-12  2:47       ` Zong Li
2022-01-12  2:47         ` Zong Li
2022-01-12  9:09         ` Lee Jones
2022-01-12  9:09           ` Lee Jones
2022-01-13  6:47           ` Zong Li
2022-01-13  6:47             ` Zong Li
2022-01-13 17:21             ` Lee Jones
2022-01-13 17:21               ` Lee Jones
2022-01-13 17:22               ` Lee Jones
2022-01-13 17:22                 ` Lee Jones
2022-01-13 17:51               ` Jessica Clarke
2022-01-13 17:51                 ` Jessica Clarke
2022-01-13 18:13                 ` Lee Jones
2022-01-13 18:13                   ` Lee Jones
2022-01-14  9:45                   ` Zong Li
2022-01-14  9:45                     ` Zong Li
2022-01-14 10:07                     ` Lee Jones
2022-01-14 10:07                       ` Lee Jones
2022-01-14 14:59                       ` Zong Li
2022-01-14 14:59                         ` Zong Li
2022-01-14 16:34                         ` Lee Jones
2022-01-14 16:34                           ` Lee Jones
2022-01-15  6:19                           ` Zong Li
2022-01-15  6:19                             ` Zong Li
2022-01-19  9:38                             ` Zong Li
2022-01-19  9:38                               ` Zong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220108004514.C331AC36AE9@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.