* [PATCH 0/2] GitHub workflow fixes
@ 2022-01-09 6:17 Josh Soref
2022-01-09 6:17 ` [PATCH 1/2] Fix lockdown comment argument Josh Soref
2022-01-09 6:17 ` [PATCH 2/2] Limit lockdown to qemu Josh Soref
0 siblings, 2 replies; 4+ messages in thread
From: Josh Soref @ 2022-01-09 6:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Josh Soref, Richard Henderson
The current workflow fails to provide a comment explaining why
it has closed a PR. This is not friendly.
Also, while it's perfectly reasonable to close PRs to the qemu
organization, it's a bit much to close them in forks.
These patches address both of these issues.
Josh Soref (2):
Fix lockdown comment argument
Limit lockdown to qemu
.github/workflows/lockdown.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.32.0 (Apple Git-132)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] Fix lockdown comment argument
2022-01-09 6:17 [PATCH 0/2] GitHub workflow fixes Josh Soref
@ 2022-01-09 6:17 ` Josh Soref
2022-01-09 6:17 ` [PATCH 2/2] Limit lockdown to qemu Josh Soref
1 sibling, 0 replies; 4+ messages in thread
From: Josh Soref @ 2022-01-09 6:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Josh Soref, Richard Henderson
Signed-off-by: Josh Soref <jsoref@gmail.com>
---
.github/workflows/lockdown.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index ad8b8f7..37c6065 100644
--- a/.github/workflows/lockdown.yml
+++ b/.github/workflows/lockdown.yml
@@ -15,7 +15,7 @@ jobs:
steps:
- uses: dessant/repo-lockdown@v2
with:
- pull-comment: |
+ pr-comment: |
Thank you for your interest in the QEMU project.
This repository is a read-only mirror of the project's repostories hosted
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Limit lockdown to qemu
2022-01-09 6:17 [PATCH 0/2] GitHub workflow fixes Josh Soref
2022-01-09 6:17 ` [PATCH 1/2] Fix lockdown comment argument Josh Soref
@ 2022-01-09 6:17 ` Josh Soref
2022-01-09 14:30 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Josh Soref @ 2022-01-09 6:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Josh Soref, Richard Henderson
Signed-off-by: Josh Soref <jsoref@gmail.com>
---
.github/workflows/lockdown.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index 37c6065..b924b25 100644
--- a/.github/workflows/lockdown.yml
+++ b/.github/workflows/lockdown.yml
@@ -12,6 +12,7 @@ permissions:
jobs:
action:
runs-on: ubuntu-latest
+ if: github.repository_owner == 'qemu'
steps:
- uses: dessant/repo-lockdown@v2
with:
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Limit lockdown to qemu
2022-01-09 6:17 ` [PATCH 2/2] Limit lockdown to qemu Josh Soref
@ 2022-01-09 14:30 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-01-09 14:30 UTC (permalink / raw)
To: Josh Soref, qemu-devel
Cc: Alex Bennée, Richard Henderson, Daniel P. Berrangé
On 1/9/22 07:17, Josh Soref wrote:
> Signed-off-by: Josh Soref <jsoref@gmail.com>
> ---
> .github/workflows/lockdown.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
> index 37c6065..b924b25 100644
> --- a/.github/workflows/lockdown.yml
> +++ b/.github/workflows/lockdown.yml
> @@ -12,6 +12,7 @@ permissions:
> jobs:
> action:
> runs-on: ubuntu-latest
> + if: github.repository_owner == 'qemu'
> steps:
> - uses: dessant/repo-lockdown@v2
> with:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-09 14:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 6:17 [PATCH 0/2] GitHub workflow fixes Josh Soref
2022-01-09 6:17 ` [PATCH 1/2] Fix lockdown comment argument Josh Soref
2022-01-09 6:17 ` [PATCH 2/2] Limit lockdown to qemu Josh Soref
2022-01-09 14:30 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.