From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Wolfgang Bumiller <w.bumiller-YTcQvvOqK21BDgjK7y7TUQ@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] blk-cgroup: stop using seq_get_buf
Date: Mon, 10 Jan 2022 17:39:06 +0100 [thread overview]
Message-ID: <20220110163906.GA6775@lst.de> (raw)
In-Reply-To: <20220107092023.iaz57fai5kj47fqf-s3XsXwYL7y0UH/FJlhLpNw@public.gmane.org>
On Fri, Jan 07, 2022 at 10:20:23AM +0100, Wolfgang Bumiller wrote:
> 253:10 253:5 rbytes=0 wbytes=0 rios=0 wios=1 dbytes=0 dios=0
> ^~~~~~ ^~~~~
>
> I'm not sure if a separate temporary buffer would make more sense or
> switching back to seq_get_buf?
> Figuring out `has_stats` first doesn't seem to be trivial due to the
> `pd_stat_fn` calls.
>
> Or of course, just include the newlines unconditionally?
>
> Unless seq_file has/gets another way to roll back the buffer?
No, there is no good way to roll back the buffer.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, tj@kernel.org, cgroups@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] blk-cgroup: stop using seq_get_buf
Date: Mon, 10 Jan 2022 17:39:06 +0100 [thread overview]
Message-ID: <20220110163906.GA6775@lst.de> (raw)
In-Reply-To: <20220107092023.iaz57fai5kj47fqf@olga.proxmox.com>
On Fri, Jan 07, 2022 at 10:20:23AM +0100, Wolfgang Bumiller wrote:
> 253:10 253:5 rbytes=0 wbytes=0 rios=0 wios=1 dbytes=0 dios=0
> ^~~~~~ ^~~~~
>
> I'm not sure if a separate temporary buffer would make more sense or
> switching back to seq_get_buf?
> Figuring out `has_stats` first doesn't seem to be trivial due to the
> `pd_stat_fn` calls.
>
> Or of course, just include the newlines unconditionally?
>
> Unless seq_file has/gets another way to roll back the buffer?
No, there is no good way to roll back the buffer.
next prev parent reply other threads:[~2022-01-10 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 15:26 [PATCH 1/2] blk-cgroup: refactor blkcg_print_stat Christoph Hellwig
[not found] ` <20210810152623.1796144-1-hch-jcswGhMUV9g@public.gmane.org>
2021-08-10 15:26 ` [PATCH 2/2] blk-cgroup: stop using seq_get_buf Christoph Hellwig
2021-08-10 15:26 ` Christoph Hellwig
2021-08-11 17:56 ` Tejun Heo
2022-01-07 9:20 ` Wolfgang Bumiller
[not found] ` <20220107092023.iaz57fai5kj47fqf-s3XsXwYL7y0UH/FJlhLpNw@public.gmane.org>
2022-01-10 16:39 ` Christoph Hellwig [this message]
2022-01-10 16:39 ` Christoph Hellwig
2021-08-11 17:56 ` [PATCH 1/2] blk-cgroup: refactor blkcg_print_stat Tejun Heo
2021-08-11 17:56 ` Tejun Heo
2021-08-16 12:39 ` Christoph Hellwig
2021-08-16 12:39 ` Christoph Hellwig
2021-08-16 16:53 ` Jens Axboe
2021-08-16 16:53 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220110163906.GA6775@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=w.bumiller-YTcQvvOqK21BDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.