* [PATCH] drm/amdgpu: Indent some if statements
@ 2022-01-13 6:17 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-01-13 6:17 UTC (permalink / raw)
To: Alex Deucher
Cc: Mukul Joshi, Tao Zhou, David Airlie, kernel-janitors, Pan, Xinhui,
Nirmoy Das, amd-gfx, yipechai, Luben Tuikov, Stanley.Yang,
Daniel Vetter, John Clements, Christian König, Dennis Li,
Hawking Zhang
These if statements need to be indented.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index d4d9b9ea8bbd..777def770dc8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1714,8 +1714,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev,
}
if (block_obj->hw_ops->query_ras_error_status)
- block_obj->hw_ops->query_ras_error_status(adev);
-
+ block_obj->hw_ops->query_ras_error_status(adev);
}
static void amdgpu_ras_query_err_status(struct amdgpu_device *adev)
@@ -2722,7 +2721,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev)
int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con)
{
if (!adev)
- return -EINVAL;;
+ return -EINVAL;
adev->psp.ras_context.ras = ras_con;
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu: Indent some if statements
@ 2022-01-13 6:17 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-01-13 6:17 UTC (permalink / raw)
To: Alex Deucher
Cc: Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Hawking Zhang, John Clements, Luben Tuikov, Tao Zhou,
Stanley.Yang, yipechai, Dennis Li, Mukul Joshi, Nirmoy Das,
amd-gfx, kernel-janitors
These if statements need to be indented.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index d4d9b9ea8bbd..777def770dc8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1714,8 +1714,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev,
}
if (block_obj->hw_ops->query_ras_error_status)
- block_obj->hw_ops->query_ras_error_status(adev);
-
+ block_obj->hw_ops->query_ras_error_status(adev);
}
static void amdgpu_ras_query_err_status(struct amdgpu_device *adev)
@@ -2722,7 +2721,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev)
int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con)
{
if (!adev)
- return -EINVAL;;
+ return -EINVAL;
adev->psp.ras_context.ras = ras_con;
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Indent some if statements
2022-01-13 6:17 ` Dan Carpenter
@ 2022-01-13 12:19 ` Das, Nirmoy
-1 siblings, 0 replies; 4+ messages in thread
From: Das, Nirmoy @ 2022-01-13 12:19 UTC (permalink / raw)
To: Dan Carpenter, Alex Deucher
Cc: Mukul Joshi, Tao Zhou, David Airlie, Pan, Xinhui, kernel-janitors,
amd-gfx, yipechai, Luben Tuikov, Stanley.Yang, Daniel Vetter,
John Clements, Christian König, Dennis Li, Hawking Zhang
Reviewed-by: Nirmoy Das <nirmoy.das@amd.com>
On 1/13/2022 7:17 AM, Dan Carpenter wrote:
> These if statements need to be indented.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index d4d9b9ea8bbd..777def770dc8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -1714,8 +1714,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev,
> }
>
> if (block_obj->hw_ops->query_ras_error_status)
> - block_obj->hw_ops->query_ras_error_status(adev);
> -
> + block_obj->hw_ops->query_ras_error_status(adev);
> }
>
> static void amdgpu_ras_query_err_status(struct amdgpu_device *adev)
> @@ -2722,7 +2721,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev)
> int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con)
> {
> if (!adev)
> - return -EINVAL;;
> + return -EINVAL;
>
> adev->psp.ras_context.ras = ras_con;
> return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Indent some if statements
@ 2022-01-13 12:19 ` Das, Nirmoy
0 siblings, 0 replies; 4+ messages in thread
From: Das, Nirmoy @ 2022-01-13 12:19 UTC (permalink / raw)
To: Dan Carpenter, Alex Deucher
Cc: Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Hawking Zhang, John Clements, Luben Tuikov, Tao Zhou,
Stanley.Yang, yipechai, Dennis Li, Mukul Joshi, amd-gfx,
kernel-janitors
Reviewed-by: Nirmoy Das <nirmoy.das@amd.com>
On 1/13/2022 7:17 AM, Dan Carpenter wrote:
> These if statements need to be indented.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index d4d9b9ea8bbd..777def770dc8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -1714,8 +1714,7 @@ static void amdgpu_ras_error_status_query(struct amdgpu_device *adev,
> }
>
> if (block_obj->hw_ops->query_ras_error_status)
> - block_obj->hw_ops->query_ras_error_status(adev);
> -
> + block_obj->hw_ops->query_ras_error_status(adev);
> }
>
> static void amdgpu_ras_query_err_status(struct amdgpu_device *adev)
> @@ -2722,7 +2721,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev)
> int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con)
> {
> if (!adev)
> - return -EINVAL;;
> + return -EINVAL;
>
> adev->psp.ras_context.ras = ras_con;
> return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-13 12:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-13 6:17 [PATCH] drm/amdgpu: Indent some if statements Dan Carpenter
2022-01-13 6:17 ` Dan Carpenter
2022-01-13 12:19 ` Das, Nirmoy
2022-01-13 12:19 ` Das, Nirmoy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.