From: Stephen Boyd <sboyd@kernel.org>
To: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-mediatek@lists.infradead.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nick Fan <Nick.Fan@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH] clk: mediatek: Disable ACP to fix 3D on MT8192
Date: Thu, 13 Jan 2022 18:08:23 -0800 [thread overview]
Message-ID: <20220114020825.5064DC36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110181330.3224-1-alyssa.rosenzweig@collabora.com>
Quoting Alyssa Rosenzweig (2022-01-10 10:13:30)
> @@ -1238,6 +1265,10 @@ static int clk_mt8192_infra_probe(struct platform_device *pdev)
> if (r)
> return r;
>
> + r = clk_mt8192_infra_disable_mfg2acp(pdev);
> + if (r)
> + return r;
If this fails it leaves a bunch of allocations around that never get
freed. It's a problem before this patch so it's mostly just making me
grumpy that proper cleanup isn't already here. Can this be the first
thing done in probe instead?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-mediatek@lists.infradead.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nick Fan <Nick.Fan@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH] clk: mediatek: Disable ACP to fix 3D on MT8192
Date: Thu, 13 Jan 2022 18:08:23 -0800 [thread overview]
Message-ID: <20220114020825.5064DC36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110181330.3224-1-alyssa.rosenzweig@collabora.com>
Quoting Alyssa Rosenzweig (2022-01-10 10:13:30)
> @@ -1238,6 +1265,10 @@ static int clk_mt8192_infra_probe(struct platform_device *pdev)
> if (r)
> return r;
>
> + r = clk_mt8192_infra_disable_mfg2acp(pdev);
> + if (r)
> + return r;
If this fails it leaves a bunch of allocations around that never get
freed. It's a problem before this patch so it's mostly just making me
grumpy that proper cleanup isn't already here. Can this be the first
thing done in probe instead?
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-mediatek@lists.infradead.org
Cc: Michael Turquette <mturquette@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Weiyi Lu <weiyi.lu@mediatek.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nick Fan <Nick.Fan@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH] clk: mediatek: Disable ACP to fix 3D on MT8192
Date: Thu, 13 Jan 2022 18:08:23 -0800 [thread overview]
Message-ID: <20220114020825.5064DC36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110181330.3224-1-alyssa.rosenzweig@collabora.com>
Quoting Alyssa Rosenzweig (2022-01-10 10:13:30)
> @@ -1238,6 +1265,10 @@ static int clk_mt8192_infra_probe(struct platform_device *pdev)
> if (r)
> return r;
>
> + r = clk_mt8192_infra_disable_mfg2acp(pdev);
> + if (r)
> + return r;
If this fails it leaves a bunch of allocations around that never get
freed. It's a problem before this patch so it's mostly just making me
grumpy that proper cleanup isn't already here. Can this be the first
thing done in probe instead?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-14 2:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 18:13 [PATCH] clk: mediatek: Disable ACP to fix 3D on MT8192 Alyssa Rosenzweig
2022-01-10 18:13 ` Alyssa Rosenzweig
2022-01-10 18:13 ` Alyssa Rosenzweig
2022-01-14 2:08 ` Stephen Boyd [this message]
2022-01-14 2:08 ` Stephen Boyd
2022-01-14 2:08 ` Stephen Boyd
2022-01-14 13:23 ` Robin Murphy
2022-01-14 13:23 ` Robin Murphy
2022-01-14 13:23 ` Robin Murphy
2022-01-14 13:47 ` Alyssa Rosenzweig
2022-01-14 13:47 ` Alyssa Rosenzweig
2022-01-14 13:47 ` Alyssa Rosenzweig
2022-01-18 7:19 ` Chen-Yu Tsai
2022-01-18 7:19 ` Chen-Yu Tsai
2022-01-18 7:19 ` Chen-Yu Tsai
2022-01-18 15:01 ` Robin Murphy
2022-01-18 15:01 ` Robin Murphy
2022-01-18 15:01 ` Robin Murphy
2022-01-19 2:18 ` Stephen Boyd
2022-01-19 2:18 ` Stephen Boyd
2022-01-19 2:18 ` Stephen Boyd
2022-01-20 14:22 ` Robin Murphy
2022-01-20 14:22 ` Robin Murphy
2022-01-20 14:22 ` Robin Murphy
2022-01-20 14:27 ` Alyssa Rosenzweig
2022-01-20 14:27 ` Alyssa Rosenzweig
2022-01-20 14:27 ` Alyssa Rosenzweig
2022-02-15 10:44 ` AngeloGioacchino Del Regno
2022-02-15 10:44 ` AngeloGioacchino Del Regno
2022-02-15 10:44 ` AngeloGioacchino Del Regno
2022-02-15 15:21 ` Robin Murphy
2022-02-15 15:21 ` Robin Murphy
2022-02-15 15:21 ` Robin Murphy
2022-02-15 16:12 ` AngeloGioacchino Del Regno
2022-02-15 16:12 ` AngeloGioacchino Del Regno
2022-02-15 16:12 ` AngeloGioacchino Del Regno
2022-02-17 21:40 ` Stephen Boyd
2022-02-17 21:40 ` Stephen Boyd
2022-02-17 21:40 ` Stephen Boyd
2022-01-14 22:55 ` Stephen Boyd
2022-01-14 22:55 ` Stephen Boyd
2022-01-14 22:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114020825.5064DC36AEA@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=Nick.Fan@mediatek.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.