From: Stephen Boyd <sboyd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Miles Chen <miles.chen@mediatek.com>
Cc: Miles Chen <miles.chen@mediatek.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
Date: Thu, 13 Jan 2022 18:11:29 -0800 [thread overview]
Message-ID: <20220114021131.1F7C9C36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110171000.24316-4-miles.chen@mediatek.com>
Quoting Miles Chen (2022-01-10 09:09:59)
> To support COMMON_CLK_MT8192* module build,
> add MODULE_LICENSE and include module.h.
>
> Cc: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> Cc: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Have you tried removing the modules? And then reloading them? I also see
that mtk_clk_simple_probe() doesn't actually unregister anything, it
just frees some allocations. Please fix this before making these
modules.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Miles Chen <miles.chen@mediatek.com>
Cc: Miles Chen <miles.chen@mediatek.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
Date: Thu, 13 Jan 2022 18:11:29 -0800 [thread overview]
Message-ID: <20220114021131.1F7C9C36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110171000.24316-4-miles.chen@mediatek.com>
Quoting Miles Chen (2022-01-10 09:09:59)
> To support COMMON_CLK_MT8192* module build,
> add MODULE_LICENSE and include module.h.
>
> Cc: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> Cc: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Have you tried removing the modules? And then reloading them? I also see
that mtk_clk_simple_probe() doesn't actually unregister anything, it
just frees some allocations. Please fix this before making these
modules.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Miles Chen <miles.chen@mediatek.com>
Cc: Miles Chen <miles.chen@mediatek.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
Date: Thu, 13 Jan 2022 18:11:29 -0800 [thread overview]
Message-ID: <20220114021131.1F7C9C36AEA@smtp.kernel.org> (raw)
In-Reply-To: <20220110171000.24316-4-miles.chen@mediatek.com>
Quoting Miles Chen (2022-01-10 09:09:59)
> To support COMMON_CLK_MT8192* module build,
> add MODULE_LICENSE and include module.h.
>
> Cc: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> Cc: Chen-Yu Tsai <wenst@chromium.org>
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Have you tried removing the modules? And then reloading them? I also see
that mtk_clk_simple_probe() doesn't actually unregister anything, it
just frees some allocations. Please fix this before making these
modules.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-14 2:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:09 clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-10 17:09 ` [PATCH 1/3] clk: mediatek: export mtk_clk_simple_probe Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-14 2:12 ` Stephen Boyd
2022-01-14 2:12 ` Stephen Boyd
2022-01-14 2:12 ` Stephen Boyd
2022-01-14 8:36 ` Miles Chen
2022-01-14 8:36 ` Miles Chen
2022-01-10 17:09 ` [PATCH 2/3] clk: mediatek: clk-mt8192: drop CLK_OF_DECLARE_DRIVER Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-10 17:09 ` [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-10 17:09 ` Miles Chen
2022-01-14 2:11 ` Stephen Boyd [this message]
2022-01-14 2:11 ` Stephen Boyd
2022-01-14 2:11 ` Stephen Boyd
2022-01-14 8:35 ` Miles Chen
2022-01-14 8:35 ` Miles Chen
2022-01-14 22:19 ` Stephen Boyd
2022-01-14 22:19 ` Stephen Boyd
2022-01-14 22:19 ` Stephen Boyd
2022-01-17 9:18 ` Miles Chen
2022-01-17 9:18 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114021131.1F7C9C36AEA@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.