All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH V4] notifier/panic: Introduce panic_notifier_filter
Date: Sun, 16 Jan 2022 21:11:29 +0800	[thread overview]
Message-ID: <20220116131129.GD2388@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220108153451.195121-1-gpiccoli@igalia.com>

On 01/08/22 at 12:34pm, Guilherme G. Piccoli wrote:
...... 
> So, this patch aims to ease this decision: we hereby introduce a filter
> for the panic notifier list, in which users may select specifically
> which callbacks they wish to run, allowing a safer kdump. The allowlist
> should be provided using the parameter "panic_notifier_filter=a,b,..."
> where a, b are valid callback names. Invalid symbols are discarded.
> 
> Currently up to 16 symbols may be passed in this list, we consider
> that this numbers allows enough flexibility (and no matter what
> architecture is used, at most 30 panic callbacks are registered).
> In an experiment using a qemu x86 virtual machine, by default only
> six callbacks are registered in the panic notifier list.
> Once a valid callback name is provided in the list, such function
> is allowed to be registered/unregistered in the panic_notifier_list;
> all other panic callbacks are ignored. Notice that this filter is
> only for the panic notifiers and has no effect in the other notifiers.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

This patch looks good to me, thx.

Acked-by: Baoquan He <bhe@redhat.com>



WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	dyoung@redhat.com, linux-doc@vger.kernel.org, vgoyal@redhat.com,
	stern@rowland.harvard.edu, akpm@linux-foundation.org,
	andriy.shevchenko@linux.intel.com, corbet@lwn.net,
	halves@canonical.com, kernel@gpiccoli.net
Subject: Re: [PATCH V4] notifier/panic: Introduce panic_notifier_filter
Date: Sun, 16 Jan 2022 21:11:29 +0800	[thread overview]
Message-ID: <20220116131129.GD2388@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20220108153451.195121-1-gpiccoli@igalia.com>

On 01/08/22 at 12:34pm, Guilherme G. Piccoli wrote:
...... 
> So, this patch aims to ease this decision: we hereby introduce a filter
> for the panic notifier list, in which users may select specifically
> which callbacks they wish to run, allowing a safer kdump. The allowlist
> should be provided using the parameter "panic_notifier_filter=a,b,..."
> where a, b are valid callback names. Invalid symbols are discarded.
> 
> Currently up to 16 symbols may be passed in this list, we consider
> that this numbers allows enough flexibility (and no matter what
> architecture is used, at most 30 panic callbacks are registered).
> In an experiment using a qemu x86 virtual machine, by default only
> six callbacks are registered in the panic notifier list.
> Once a valid callback name is provided in the list, such function
> is allowed to be registered/unregistered in the panic_notifier_list;
> all other panic callbacks are ignored. Notice that this filter is
> only for the panic notifiers and has no effect in the other notifiers.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>

This patch looks good to me, thx.

Acked-by: Baoquan He <bhe@redhat.com>


  parent reply	other threads:[~2022-01-16 13:11 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-08 15:34 [PATCH V4] notifier/panic: Introduce panic_notifier_filter Guilherme G. Piccoli
2022-01-08 15:34 ` Guilherme G. Piccoli
2022-01-14 19:03 ` Guilherme G. Piccoli
2022-01-14 19:03   ` Guilherme G. Piccoli
     [not found]   ` <CALu+AoR+GrCpf0gqsx_XYETBGUAfRyP+SPNarK179hT7iQmCqQ@mail.gmail.com>
2022-01-18 13:22     ` Guilherme G. Piccoli
2022-01-18 13:22       ` Guilherme G. Piccoli
2022-01-16 13:11 ` Baoquan He [this message]
2022-01-16 13:11   ` Baoquan He
2022-01-17 12:59   ` Guilherme G. Piccoli
2022-01-17 12:59     ` Guilherme G. Piccoli
2022-01-20 15:14 ` Petr Mladek
2022-01-20 15:14   ` Petr Mladek
2022-01-21 20:31   ` Guilherme G. Piccoli
2022-01-21 20:31     ` Guilherme G. Piccoli
2022-01-22 10:55     ` Baoquan He
2022-01-22 10:55       ` Baoquan He
2022-01-23 13:07       ` Masami Hiramatsu
2022-01-23 13:07         ` Masami Hiramatsu
2022-01-24 13:59         ` Baoquan He
2022-01-24 13:59           ` Baoquan He
2022-01-24 14:48           ` Guilherme G. Piccoli
2022-01-24 14:48             ` Guilherme G. Piccoli
2022-01-26  3:10             ` Baoquan He
2022-01-26  3:10               ` Baoquan He
2022-01-26 12:20               ` d.hatayama
2022-01-26 12:20                 ` d.hatayama
2022-01-26 13:20               ` Petr Mladek
2022-01-26 13:20                 ` Petr Mladek
2022-01-30  8:50                 ` Baoquan He
2022-01-30  8:50                   ` Baoquan He
2022-01-24 11:43       ` d.hatayama
2022-01-24 11:43         ` d.hatayama
2022-01-24 14:15         ` Baoquan He
2022-01-24 14:15           ` Baoquan He
2022-01-25 11:50 ` d.hatayama
2022-01-25 11:50   ` d.hatayama
2022-01-25 12:34   ` Guilherme G. Piccoli
2022-01-25 12:34     ` Guilherme G. Piccoli
2022-01-25 13:06     ` d.hatayama
2022-01-25 13:06       ` d.hatayama
2022-01-27 17:16       ` Guilherme G. Piccoli
2022-01-27 17:16         ` Guilherme G. Piccoli
2022-01-28 13:38         ` Petr Mladek
2022-01-28 13:38           ` Petr Mladek
2022-02-08 18:51           ` Guilherme G. Piccoli
2022-02-08 18:51             ` Guilherme G. Piccoli
2022-02-09  0:31             ` bhe
2022-02-09  0:31               ` bhe
2022-02-10 16:39               ` Guilherme G. Piccoli
2022-02-10 16:39                 ` Guilherme G. Piccoli
2022-02-10 17:26                 ` Michael Kelley
2022-02-10 17:26                   ` Michael Kelley (LINUX)
2022-02-10 17:50                   ` Guilherme G. Piccoli
2022-02-10 17:50                     ` Guilherme G. Piccoli
2022-03-06 14:21           ` Guilherme G. Piccoli
2022-03-06 14:21             ` Guilherme G. Piccoli
2022-03-07  3:42             ` bhe
2022-03-07  3:42               ` bhe
2022-03-07 13:11               ` Guilherme G. Piccoli
2022-03-07 13:11                 ` Guilherme G. Piccoli
2022-03-07 14:04                 ` bhe
2022-03-07 14:04                   ` bhe
2022-03-07 14:25                   ` Guilherme G. Piccoli
2022-03-07 14:25                     ` Guilherme G. Piccoli
2022-03-08 12:54                     ` Petr Mladek
2022-03-08 12:54                       ` Petr Mladek
2022-03-08 13:04                       ` Guilherme G. Piccoli
2022-03-08 13:04                         ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220116131129.GD2388@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.