From: kernel test robot <lkp@intel.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used
Date: Tue, 18 Jan 2022 19:14:10 +0800 [thread overview]
Message-ID: <202201181811.egJXbMCF-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee
commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/or new parent+name in FAN_RENAME event
date: 5 weeks ago
config: hexagon-randconfig-r045-20220117 (https://download.01.org/0day-ci/archive/20220118/202201181811.egJXbMCF-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c10cbb243cafc0cf42c3e922cb29183279444432)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7326e382c21e9c23c89c88369afdc90b82a14da8
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/notify/fanotify/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used [-Wunused-but-set-variable]
struct fanotify_info *info;
^
1 warning generated.
vim +/info +154 fs/notify/fanotify/fanotify_user.c
7326e382c21e9c Amir Goldstein 2021-11-29 149
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 150 static size_t fanotify_event_len(unsigned int info_mode,
929943b38daf81 Amir Goldstein 2020-07-16 151 struct fanotify_event *event)
5e469c830fdb5a Amir Goldstein 2019-01-10 152 {
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 153 size_t event_len = FAN_EVENT_METADATA_LEN;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154 struct fanotify_info *info;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 155 int fh_len;
929943b38daf81 Amir Goldstein 2020-07-16 156 int dot_len = 0;
f454fa610a69b9 Amir Goldstein 2020-07-16 157
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 158 if (!info_mode)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 159 return event_len;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 160
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 161 if (fanotify_is_error_event(event->mask))
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 162 event_len += FANOTIFY_ERROR_INFO_LEN;
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 163
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 164 info = fanotify_event_info(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 165
7326e382c21e9c Amir Goldstein 2021-11-29 166 if (fanotify_event_has_any_dir_fh(event)) {
7326e382c21e9c Amir Goldstein 2021-11-29 167 event_len += fanotify_dir_name_info_len(event);
d3424c9bac893b Matthew Bobrowski 2021-08-08 168 } else if ((info_mode & FAN_REPORT_NAME) &&
d3424c9bac893b Matthew Bobrowski 2021-08-08 169 (event->mask & FAN_ONDIR)) {
929943b38daf81 Amir Goldstein 2020-07-16 170 /*
929943b38daf81 Amir Goldstein 2020-07-16 171 * With group flag FAN_REPORT_NAME, if name was not recorded in
929943b38daf81 Amir Goldstein 2020-07-16 172 * event on a directory, we will report the name ".".
929943b38daf81 Amir Goldstein 2020-07-16 173 */
929943b38daf81 Amir Goldstein 2020-07-16 174 dot_len = 1;
929943b38daf81 Amir Goldstein 2020-07-16 175 }
afc894c784c84c Jan Kara 2020-03-24 176
af579beb666aef Matthew Bobrowski 2021-08-08 177 if (info_mode & FAN_REPORT_PIDFD)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 178 event_len += FANOTIFY_PIDFD_INFO_HDR_LEN;
af579beb666aef Matthew Bobrowski 2021-08-08 179
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 180 if (fanotify_event_has_object_fh(event)) {
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 181 fh_len = fanotify_event_object_fh_len(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 182 event_len += fanotify_fid_info_len(fh_len, dot_len);
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 183 }
5e469c830fdb5a Amir Goldstein 2019-01-10 184
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 185 return event_len;
5e469c830fdb5a Amir Goldstein 2019-01-10 186 }
5e469c830fdb5a Amir Goldstein 2019-01-10 187
:::::: The code at line 154 was first introduced by commit
:::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size calculation to its own function
:::::: TO: Gabriel Krisman Bertazi <krisman@collabora.com>
:::::: CC: Jan Kara <jack@suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used
Date: Tue, 18 Jan 2022 19:14:10 +0800 [thread overview]
Message-ID: <202201181811.egJXbMCF-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5216 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e3a8b6a1e70c37702054ae3c7c07ed828435d8ee
commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/or new parent+name in FAN_RENAME event
date: 5 weeks ago
config: hexagon-randconfig-r045-20220117 (https://download.01.org/0day-ci/archive/20220118/202201181811.egJXbMCF-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c10cbb243cafc0cf42c3e922cb29183279444432)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7326e382c21e9c23c89c88369afdc90b82a14da8
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/notify/fanotify/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used [-Wunused-but-set-variable]
struct fanotify_info *info;
^
1 warning generated.
vim +/info +154 fs/notify/fanotify/fanotify_user.c
7326e382c21e9c Amir Goldstein 2021-11-29 149
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 150 static size_t fanotify_event_len(unsigned int info_mode,
929943b38daf81 Amir Goldstein 2020-07-16 151 struct fanotify_event *event)
5e469c830fdb5a Amir Goldstein 2019-01-10 152 {
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 153 size_t event_len = FAN_EVENT_METADATA_LEN;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154 struct fanotify_info *info;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 155 int fh_len;
929943b38daf81 Amir Goldstein 2020-07-16 156 int dot_len = 0;
f454fa610a69b9 Amir Goldstein 2020-07-16 157
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 158 if (!info_mode)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 159 return event_len;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 160
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 161 if (fanotify_is_error_event(event->mask))
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 162 event_len += FANOTIFY_ERROR_INFO_LEN;
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25 163
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 164 info = fanotify_event_info(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 165
7326e382c21e9c Amir Goldstein 2021-11-29 166 if (fanotify_event_has_any_dir_fh(event)) {
7326e382c21e9c Amir Goldstein 2021-11-29 167 event_len += fanotify_dir_name_info_len(event);
d3424c9bac893b Matthew Bobrowski 2021-08-08 168 } else if ((info_mode & FAN_REPORT_NAME) &&
d3424c9bac893b Matthew Bobrowski 2021-08-08 169 (event->mask & FAN_ONDIR)) {
929943b38daf81 Amir Goldstein 2020-07-16 170 /*
929943b38daf81 Amir Goldstein 2020-07-16 171 * With group flag FAN_REPORT_NAME, if name was not recorded in
929943b38daf81 Amir Goldstein 2020-07-16 172 * event on a directory, we will report the name ".".
929943b38daf81 Amir Goldstein 2020-07-16 173 */
929943b38daf81 Amir Goldstein 2020-07-16 174 dot_len = 1;
929943b38daf81 Amir Goldstein 2020-07-16 175 }
afc894c784c84c Jan Kara 2020-03-24 176
af579beb666aef Matthew Bobrowski 2021-08-08 177 if (info_mode & FAN_REPORT_PIDFD)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 178 event_len += FANOTIFY_PIDFD_INFO_HDR_LEN;
af579beb666aef Matthew Bobrowski 2021-08-08 179
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 180 if (fanotify_event_has_object_fh(event)) {
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 181 fh_len = fanotify_event_object_fh_len(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 182 event_len += fanotify_fid_info_len(fh_len, dot_len);
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25 183 }
5e469c830fdb5a Amir Goldstein 2019-01-10 184
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 185 return event_len;
5e469c830fdb5a Amir Goldstein 2019-01-10 186 }
5e469c830fdb5a Amir Goldstein 2019-01-10 187
:::::: The code at line 154 was first introduced by commit
:::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size calculation to its own function
:::::: TO: Gabriel Krisman Bertazi <krisman@collabora.com>
:::::: CC: Jan Kara <jack@suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next reply other threads:[~2022-01-18 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 11:14 kernel test robot [this message]
2022-01-18 11:14 ` fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-18 20:34 kernel test robot
2022-01-18 20:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201181811.egJXbMCF-lkp@intel.com \
--to=lkp@intel.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.