From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: sumit.semwal@linaro.org, gustavo@padovan.org, daniel.vetter@ffwll.ch
Cc: linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org
Subject: [PATCH 4/4] dma-buf: warn about containers in dma_resv object
Date: Wed, 19 Jan 2022 14:43:39 +0100 [thread overview]
Message-ID: <20220119134339.3102-4-christian.koenig@amd.com> (raw)
In-Reply-To: <20220119134339.3102-1-christian.koenig@amd.com>
Drivers should not add containers as shared fences to the dma_resv
object, instead each fence should be added individually.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/dma-buf/dma-resv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 6dd9a40b55d4..e8a0c1d51da2 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -256,6 +256,11 @@ void dma_resv_add_shared_fence(struct dma_resv *obj, struct dma_fence *fence)
dma_resv_assert_held(obj);
+ /* Drivers should not add containers here, instead add each fence
+ * individually.
+ */
+ WARN_ON(dma_fence_is_container(fence));
+
fobj = dma_resv_shared_list(obj);
count = fobj->shared_count;
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: sumit.semwal@linaro.org, gustavo@padovan.org, daniel.vetter@ffwll.ch
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: [PATCH 4/4] dma-buf: warn about containers in dma_resv object
Date: Wed, 19 Jan 2022 14:43:39 +0100 [thread overview]
Message-ID: <20220119134339.3102-4-christian.koenig@amd.com> (raw)
In-Reply-To: <20220119134339.3102-1-christian.koenig@amd.com>
Drivers should not add containers as shared fences to the dma_resv
object, instead each fence should be added individually.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/dma-buf/dma-resv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 6dd9a40b55d4..e8a0c1d51da2 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -256,6 +256,11 @@ void dma_resv_add_shared_fence(struct dma_resv *obj, struct dma_fence *fence)
dma_resv_assert_held(obj);
+ /* Drivers should not add containers here, instead add each fence
+ * individually.
+ */
+ WARN_ON(dma_fence_is_container(fence));
+
fobj = dma_resv_shared_list(obj);
count = fobj->shared_count;
--
2.25.1
next prev parent reply other threads:[~2022-01-19 13:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 13:43 [PATCH 1/4] dma-buf: consolidate dma_fence subclass checking Christian König
2022-01-19 13:43 ` Christian König
2022-01-19 13:43 ` [PATCH 2/4] dma-buf: warn about dma_fence_array container rules Christian König
2022-01-19 13:43 ` Christian König
2022-01-19 17:18 ` Daniel Vetter
2022-01-19 17:18 ` Daniel Vetter
2022-01-19 13:43 ` [PATCH 3/4] dma-buf: Warn about dma_fence_chain " Christian König
2022-01-19 13:43 ` Christian König
2022-01-19 17:18 ` Daniel Vetter
2022-01-19 17:18 ` Daniel Vetter
2022-01-19 13:43 ` Christian König [this message]
2022-01-19 13:43 ` [PATCH 4/4] dma-buf: warn about containers in dma_resv object Christian König
2022-01-19 17:19 ` Daniel Vetter
2022-01-19 17:19 ` Daniel Vetter
2022-01-19 17:16 ` [PATCH 1/4] dma-buf: consolidate dma_fence subclass checking Daniel Vetter
2022-01-19 17:16 ` Daniel Vetter
2022-01-20 8:50 ` Christian König
2022-01-20 8:50 ` Christian König
2022-01-20 11:28 ` Daniel Vetter
2022-01-20 11:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119134339.3102-4-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.