From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v2 0/5] kexec: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
Date: Thu, 20 Jan 2022 17:50:19 +0800 [thread overview]
Message-ID: <20220120095019.GA4579@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211206160514.2000-1-jszhang@kernel.org>
On 12/07/21 at 12:05am, Jisheng Zhang wrote:
> Replace the conditional compilation using "#ifdef CONFIG_KEXEC_CORE"
> by a check for "IS_ENABLED(CONFIG_KEXEC_CORE)", to simplify the code
> and increase compile coverage.
Only checked the x86 patch, but the whole patchset looks good to me,
thanks, Jisheng.
Acked-by: Baoquan He <bhe@redhat.com>
Maybe Andrew can help pick this whole series lest each patch need be taken
care of by its own ARCH maintainer.
>
> I only modify x86, arm, arm64 and riscv, other architectures such as
> sh, powerpc and s390 are better to be kept kexec code as-is so they
> are not touched.
>
> Since v1:
> - collect Reviewed-by tag
> - fix misleading commit msg.
>
> Jisheng Zhang (5):
> kexec: make crashk_res, crashk_low_res and crash_notes symbols always
> visible
> riscv: mm: init: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> x86/setup: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm64: mm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
>
> arch/arm/kernel/setup.c | 7 +++----
> arch/arm64/mm/init.c | 9 +++------
> arch/riscv/mm/init.c | 6 ++----
> arch/x86/kernel/setup.c | 10 +++-------
> include/linux/kexec.h | 12 ++++++------
> 5 files changed, 17 insertions(+), 27 deletions(-)
>
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jisheng Zhang <jszhang@kernel.org>, akpm@linux-foundation.org
Cc: Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, hpa@zytor.com,
Eric Biederman <ebiederm@xmission.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, Alexandre ghiti <alex@ghiti.fr>
Subject: Re: [PATCH v2 0/5] kexec: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
Date: Thu, 20 Jan 2022 17:50:19 +0800 [thread overview]
Message-ID: <20220120095019.GA4579@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211206160514.2000-1-jszhang@kernel.org>
On 12/07/21 at 12:05am, Jisheng Zhang wrote:
> Replace the conditional compilation using "#ifdef CONFIG_KEXEC_CORE"
> by a check for "IS_ENABLED(CONFIG_KEXEC_CORE)", to simplify the code
> and increase compile coverage.
Only checked the x86 patch, but the whole patchset looks good to me,
thanks, Jisheng.
Acked-by: Baoquan He <bhe@redhat.com>
Maybe Andrew can help pick this whole series lest each patch need be taken
care of by its own ARCH maintainer.
>
> I only modify x86, arm, arm64 and riscv, other architectures such as
> sh, powerpc and s390 are better to be kept kexec code as-is so they
> are not touched.
>
> Since v1:
> - collect Reviewed-by tag
> - fix misleading commit msg.
>
> Jisheng Zhang (5):
> kexec: make crashk_res, crashk_low_res and crash_notes symbols always
> visible
> riscv: mm: init: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> x86/setup: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm64: mm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
>
> arch/arm/kernel/setup.c | 7 +++----
> arch/arm64/mm/init.c | 9 +++------
> arch/riscv/mm/init.c | 6 ++----
> arch/x86/kernel/setup.c | 10 +++-------
> include/linux/kexec.h | 12 ++++++------
> 5 files changed, 17 insertions(+), 27 deletions(-)
>
> --
> 2.34.1
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jisheng Zhang <jszhang@kernel.org>, akpm@linux-foundation.org
Cc: Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, hpa@zytor.com,
Eric Biederman <ebiederm@xmission.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, Alexandre ghiti <alex@ghiti.fr>
Subject: Re: [PATCH v2 0/5] kexec: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
Date: Thu, 20 Jan 2022 17:50:19 +0800 [thread overview]
Message-ID: <20220120095019.GA4579@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211206160514.2000-1-jszhang@kernel.org>
On 12/07/21 at 12:05am, Jisheng Zhang wrote:
> Replace the conditional compilation using "#ifdef CONFIG_KEXEC_CORE"
> by a check for "IS_ENABLED(CONFIG_KEXEC_CORE)", to simplify the code
> and increase compile coverage.
Only checked the x86 patch, but the whole patchset looks good to me,
thanks, Jisheng.
Acked-by: Baoquan He <bhe@redhat.com>
Maybe Andrew can help pick this whole series lest each patch need be taken
care of by its own ARCH maintainer.
>
> I only modify x86, arm, arm64 and riscv, other architectures such as
> sh, powerpc and s390 are better to be kept kexec code as-is so they
> are not touched.
>
> Since v1:
> - collect Reviewed-by tag
> - fix misleading commit msg.
>
> Jisheng Zhang (5):
> kexec: make crashk_res, crashk_low_res and crash_notes symbols always
> visible
> riscv: mm: init: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> x86/setup: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm64: mm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
>
> arch/arm/kernel/setup.c | 7 +++----
> arch/arm64/mm/init.c | 9 +++------
> arch/riscv/mm/init.c | 6 ++----
> arch/x86/kernel/setup.c | 10 +++-------
> include/linux/kexec.h | 12 ++++++------
> 5 files changed, 17 insertions(+), 27 deletions(-)
>
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Jisheng Zhang <jszhang@kernel.org>, akpm@linux-foundation.org
Cc: Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, hpa@zytor.com,
Eric Biederman <ebiederm@xmission.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
kexec@lists.infradead.org, Alexandre ghiti <alex@ghiti.fr>
Subject: Re: [PATCH v2 0/5] kexec: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
Date: Thu, 20 Jan 2022 17:50:19 +0800 [thread overview]
Message-ID: <20220120095019.GA4579@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20211206160514.2000-1-jszhang@kernel.org>
On 12/07/21 at 12:05am, Jisheng Zhang wrote:
> Replace the conditional compilation using "#ifdef CONFIG_KEXEC_CORE"
> by a check for "IS_ENABLED(CONFIG_KEXEC_CORE)", to simplify the code
> and increase compile coverage.
Only checked the x86 patch, but the whole patchset looks good to me,
thanks, Jisheng.
Acked-by: Baoquan He <bhe@redhat.com>
Maybe Andrew can help pick this whole series lest each patch need be taken
care of by its own ARCH maintainer.
>
> I only modify x86, arm, arm64 and riscv, other architectures such as
> sh, powerpc and s390 are better to be kept kexec code as-is so they
> are not touched.
>
> Since v1:
> - collect Reviewed-by tag
> - fix misleading commit msg.
>
> Jisheng Zhang (5):
> kexec: make crashk_res, crashk_low_res and crash_notes symbols always
> visible
> riscv: mm: init: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> x86/setup: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm64: mm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
> arm: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef
>
> arch/arm/kernel/setup.c | 7 +++----
> arch/arm64/mm/init.c | 9 +++------
> arch/riscv/mm/init.c | 6 ++----
> arch/x86/kernel/setup.c | 10 +++-------
> include/linux/kexec.h | 12 ++++++------
> 5 files changed, 17 insertions(+), 27 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-01-20 9:50 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 16:05 [PATCH v2 0/5] kexec: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` [PATCH v2 1/5] kexec: make crashk_res, crashk_low_res and crash_notes symbols always visible Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` [PATCH v2 2/5] riscv: mm: init: use IS_ENABLED(CONFIG_KEXEC_CORE) instead of #ifdef Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2022-01-11 17:29 ` Palmer Dabbelt
2022-01-11 17:29 ` Palmer Dabbelt
2022-01-11 17:29 ` Palmer Dabbelt
2022-01-11 17:29 ` Palmer Dabbelt
2021-12-06 16:05 ` [PATCH v2 3/5] x86/setup: " Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` [PATCH v2 4/5] arm64: mm: " Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` [PATCH v2 5/5] arm: " Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2021-12-06 16:05 ` Jisheng Zhang
2022-01-16 13:38 ` [PATCH v2 0/5] kexec: " Baoquan He
2022-01-16 13:38 ` Baoquan He
2022-01-16 13:38 ` Baoquan He
2022-01-16 13:38 ` Baoquan He
2022-01-18 14:13 ` Jisheng Zhang
2022-01-18 14:13 ` Jisheng Zhang
2022-01-18 14:13 ` Jisheng Zhang
2022-01-18 14:13 ` Jisheng Zhang
2022-01-19 8:08 ` Baoquan He
2022-01-19 8:08 ` Baoquan He
2022-01-19 8:08 ` Baoquan He
2022-01-19 8:08 ` Baoquan He
2022-01-19 8:52 ` Alexandre Ghiti
2022-01-19 8:52 ` Alexandre Ghiti
2022-01-19 8:52 ` Alexandre Ghiti
2022-01-19 8:52 ` Alexandre Ghiti
2022-01-19 9:33 ` Baoquan He
2022-01-19 9:33 ` Baoquan He
2022-01-19 9:33 ` Baoquan He
2022-01-19 9:33 ` Baoquan He
2022-01-19 11:44 ` Jisheng Zhang
2022-01-19 11:44 ` Jisheng Zhang
2022-01-19 11:44 ` Jisheng Zhang
2022-01-19 11:44 ` Jisheng Zhang
2022-01-20 9:45 ` Baoquan He
2022-01-20 9:45 ` Baoquan He
2022-01-20 9:45 ` Baoquan He
2022-01-20 9:45 ` Baoquan He
2022-01-20 9:50 ` Baoquan He [this message]
2022-01-20 9:50 ` Baoquan He
2022-01-20 9:50 ` Baoquan He
2022-01-20 9:50 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120095019.GA4579@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.