From: Stefan Binding <sbinding@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
Stefan Binding <sbinding@opensource.cirrus.com>,
linux-spi@vger.kernel.org
Subject: [PATCH v4 4/9] spi: Add API to count spi acpi resources
Date: Thu, 20 Jan 2022 13:43:21 +0000 [thread overview]
Message-ID: <20220120134326.5295-5-sbinding@opensource.cirrus.com> (raw)
In-Reply-To: <20220120134326.5295-1-sbinding@opensource.cirrus.com>
Some ACPI nodes may have more than one Spi Resource.
To be able to handle these case, its necessary to have
a way of counting these resources.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
drivers/spi/spi.c | 40 ++++++++++++++++++++++++++++++++++++++++
include/linux/spi/spi.h | 6 ++++++
2 files changed, 46 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 898cc9931490..8c0c2e26609a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2325,6 +2325,46 @@ struct acpi_spi_lookup {
int irq_index;
};
+static int acpi_spi_count(struct acpi_resource *ares, void *data)
+{
+ struct acpi_resource_spi_serialbus *sb;
+ int *count = data;
+
+ if (ares->type != ACPI_RESOURCE_TYPE_SERIAL_BUS)
+ return 1;
+
+ sb = &ares->data.spi_serial_bus;
+ if (sb->type != ACPI_RESOURCE_SERIAL_TYPE_SPI)
+ return 1;
+
+ *count = *count + 1;
+
+ return 1;
+}
+
+/**
+ * acpi_spi_count_resources - Count the number of SpiSerialBus resources
+ * @adev: ACPI device
+ *
+ * Returns the number of SpiSerialBus resources in the ACPI-device's
+ * resource-list; or a negative error code.
+ */
+int acpi_spi_count_resources(struct acpi_device *adev)
+{
+ LIST_HEAD(r);
+ int count = 0;
+ int ret;
+
+ ret = acpi_dev_get_resources(adev, &r, acpi_spi_count, &count);
+ if (ret < 0)
+ return ret;
+
+ acpi_dev_free_resource_list(&r);
+
+ return count;
+}
+EXPORT_SYMBOL_GPL(acpi_spi_count_resources);
+
static void acpi_spi_parse_apple_properties(struct acpi_device *dev,
struct acpi_spi_lookup *lookup)
{
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 1a34fd0f6ca2..25a82729f8da 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -764,6 +764,7 @@ extern void spi_unregister_controller(struct spi_controller *ctlr);
extern struct spi_device *acpi_spi_device_alloc(struct spi_controller *ctlr,
struct acpi_device *adev,
int index, int irq_index);
+int acpi_spi_count_resources(struct acpi_device *adev);
#else
static inline struct spi_device *acpi_spi_device_alloc(struct spi_controller *ctlr,
struct acpi_device *adev,
@@ -771,6 +772,11 @@ static inline struct spi_device *acpi_spi_device_alloc(struct spi_controller *ct
{
return ERR_PTR(-EOPNOTSUPP);
}
+
+int acpi_spi_count_resources(struct acpi_device *adev)
+{
+ return -EOPNOTSUPP;
+}
#endif
/*
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Binding <sbinding@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<patches@opensource.cirrus.com>,
Stefan Binding <sbinding@opensource.cirrus.com>
Subject: [PATCH v4 4/9] spi: Add API to count spi acpi resources
Date: Thu, 20 Jan 2022 13:43:21 +0000 [thread overview]
Message-ID: <20220120134326.5295-5-sbinding@opensource.cirrus.com> (raw)
In-Reply-To: <20220120134326.5295-1-sbinding@opensource.cirrus.com>
Some ACPI nodes may have more than one Spi Resource.
To be able to handle these case, its necessary to have
a way of counting these resources.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
drivers/spi/spi.c | 40 ++++++++++++++++++++++++++++++++++++++++
include/linux/spi/spi.h | 6 ++++++
2 files changed, 46 insertions(+)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 898cc9931490..8c0c2e26609a 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2325,6 +2325,46 @@ struct acpi_spi_lookup {
int irq_index;
};
+static int acpi_spi_count(struct acpi_resource *ares, void *data)
+{
+ struct acpi_resource_spi_serialbus *sb;
+ int *count = data;
+
+ if (ares->type != ACPI_RESOURCE_TYPE_SERIAL_BUS)
+ return 1;
+
+ sb = &ares->data.spi_serial_bus;
+ if (sb->type != ACPI_RESOURCE_SERIAL_TYPE_SPI)
+ return 1;
+
+ *count = *count + 1;
+
+ return 1;
+}
+
+/**
+ * acpi_spi_count_resources - Count the number of SpiSerialBus resources
+ * @adev: ACPI device
+ *
+ * Returns the number of SpiSerialBus resources in the ACPI-device's
+ * resource-list; or a negative error code.
+ */
+int acpi_spi_count_resources(struct acpi_device *adev)
+{
+ LIST_HEAD(r);
+ int count = 0;
+ int ret;
+
+ ret = acpi_dev_get_resources(adev, &r, acpi_spi_count, &count);
+ if (ret < 0)
+ return ret;
+
+ acpi_dev_free_resource_list(&r);
+
+ return count;
+}
+EXPORT_SYMBOL_GPL(acpi_spi_count_resources);
+
static void acpi_spi_parse_apple_properties(struct acpi_device *dev,
struct acpi_spi_lookup *lookup)
{
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 1a34fd0f6ca2..25a82729f8da 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -764,6 +764,7 @@ extern void spi_unregister_controller(struct spi_controller *ctlr);
extern struct spi_device *acpi_spi_device_alloc(struct spi_controller *ctlr,
struct acpi_device *adev,
int index, int irq_index);
+int acpi_spi_count_resources(struct acpi_device *adev);
#else
static inline struct spi_device *acpi_spi_device_alloc(struct spi_controller *ctlr,
struct acpi_device *adev,
@@ -771,6 +772,11 @@ static inline struct spi_device *acpi_spi_device_alloc(struct spi_controller *ct
{
return ERR_PTR(-EOPNOTSUPP);
}
+
+int acpi_spi_count_resources(struct acpi_device *adev)
+{
+ return -EOPNOTSUPP;
+}
#endif
/*
--
2.25.1
next prev parent reply other threads:[~2022-01-20 13:46 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 13:43 [PATCH v4 0/9] Support Spi in i2c-multi-instantiate driver Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 13:43 ` [PATCH v4 1/9] spi: Make spi_alloc_device and spi_add_device public again Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 14:39 ` Hans de Goede
2022-01-20 14:39 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 2/9] spi: Create helper API to lookup ACPI info for spi device Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 14:37 ` Hans de Goede
2022-01-20 14:37 ` Hans de Goede
2022-01-20 17:05 ` kernel test robot
2022-01-20 17:05 ` kernel test robot
2022-01-20 17:05 ` kernel test robot
2022-01-20 17:15 ` kernel test robot
2022-01-20 17:15 ` kernel test robot
2022-01-20 13:43 ` [PATCH v4 3/9] spi: Support selection of the index of the ACPI Spi Resource before alloc Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 15:03 ` Hans de Goede
2022-01-20 15:03 ` Hans de Goede
2022-01-20 13:43 ` Stefan Binding [this message]
2022-01-20 13:43 ` [PATCH v4 4/9] spi: Add API to count spi acpi resources Stefan Binding
2022-01-20 14:39 ` Hans de Goede
2022-01-20 14:39 ` Hans de Goede
2022-01-20 15:04 ` Hans de Goede
2022-01-20 15:04 ` Hans de Goede
2022-01-20 17:05 ` kernel test robot
2022-01-20 13:43 ` [PATCH v4 5/9] platform/x86: i2c-multi-instantiate: Rename it for a generic bus driver name Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 15:05 ` Hans de Goede
2022-01-20 15:05 ` Hans de Goede
2022-01-20 18:34 ` Rafael J. Wysocki
2022-01-20 18:34 ` Rafael J. Wysocki
2022-01-20 18:39 ` Hans de Goede
2022-01-20 18:39 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 6/9] platform/x86: bus-multi-instantiate: Reorganize I2C functions Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 15:13 ` Hans de Goede
2022-01-20 15:13 ` Hans de Goede
2022-01-20 16:03 ` Hans de Goede
2022-01-20 16:03 ` Hans de Goede
2022-01-20 16:17 ` Hans de Goede
2022-01-20 16:17 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 7/9] platform/x86: bus-multi-instantiate: Add SPI support Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 16:30 ` Hans de Goede
2022-01-20 16:30 ` Hans de Goede
2022-01-20 13:43 ` [PATCH v4 8/9] ALSA: hda/realtek: Add support for HP Laptops Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 15:27 ` Takashi Iwai
2022-01-20 15:27 ` Takashi Iwai
2022-01-21 14:32 ` Stefan Binding
2022-01-21 14:32 ` Stefan Binding
2022-01-21 14:39 ` Takashi Iwai
2022-01-21 14:39 ` Takashi Iwai
2022-01-20 13:43 ` [PATCH v4 9/9] ACPI / scan: Create platform device for CS35L41 Stefan Binding
2022-01-20 13:43 ` Stefan Binding
2022-01-20 16:31 ` Hans de Goede
2022-01-20 16:31 ` Hans de Goede
2022-01-20 16:34 ` [PATCH v4 0/9] Support Spi in i2c-multi-instantiate driver Hans de Goede
2022-01-20 16:34 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120134326.5295-5-sbinding@opensource.cirrus.com \
--to=sbinding@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.